)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"30effbacdbed25de55ec17d6a24333297fc71336","unresolved":false,"context_lines":[{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"        shared \u003d self._check_shared_storage_test_file(filename)"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"        if block_migration:"},{"line_number":2316,"context_line":"            if shared:"},{"line_number":2317,"context_line":"                reason \u003d _(\"Block migration can not be used \""},{"line_number":2318,"context_line":"                           \"with shared storage.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtKw%3D","line":2315,"updated":"2012-11-29 16:04:49.000000000","message":"Might also be worth checking whether block_migration was specified, when is_volume_backed is true, since we don\u0027t have the code to block migrate a volume backed root?","commit_id":"668ffd73d729f548690f42c759ab0aed481ac30c"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"ac7d1eb10d8396d713bc677b871839df891fe2db","unresolved":false,"context_lines":[{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"        shared \u003d self._check_shared_storage_test_file(filename)"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"        if block_migration:"},{"line_number":2316,"context_line":"            if shared:"},{"line_number":2317,"context_line":"                reason \u003d _(\"Block migration can not be used \""},{"line_number":2318,"context_line":"                           \"with shared storage.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FsPs%3D","line":2315,"in_reply_to":"AAAAMH%2F%2FtKw%3D","updated":"2012-11-30 05:24:45.000000000","message":"there is already code for block migration of volume backed root. So i think checking whether block_migration was specified when is_volume_backed is true is not required.","commit_id":"668ffd73d729f548690f42c759ab0aed481ac30c"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"67ed3247b795237e0cc5df33299d7fe98ae7b9a6","unresolved":false,"context_lines":[{"line_number":2307,"context_line":""},{"line_number":2308,"context_line":"        shared \u003d self._check_shared_storage_test_file(filename)"},{"line_number":2309,"context_line":""},{"line_number":2310,"context_line":"        if block_migration:"},{"line_number":2311,"context_line":"            if shared:"},{"line_number":2312,"context_line":"                reason \u003d _(\"Block migration can not be used \""},{"line_number":2313,"context_line":"                           \"with shared storage.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Frtk%3D","side":"PARENT","line":2310,"updated":"2012-11-30 17:20:52.000000000","message":"We should make sure we catch/prevent block migrate requests with volume backed roots.","commit_id":"37df2052d7b9666c72478de79b46a60b15c9f4fd"},{"author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"change_message_id":"acdd6ffc4ab3b2b31f73c72bb211603460ef774b","unresolved":false,"context_lines":[{"line_number":2307,"context_line":""},{"line_number":2308,"context_line":"        shared \u003d self._check_shared_storage_test_file(filename)"},{"line_number":2309,"context_line":""},{"line_number":2310,"context_line":"        if block_migration:"},{"line_number":2311,"context_line":"            if shared:"},{"line_number":2312,"context_line":"                reason \u003d _(\"Block migration can not be used \""},{"line_number":2313,"context_line":"                           \"with shared storage.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fq5c%3D","side":"PARENT","line":2310,"in_reply_to":"AAAAMH%2F%2Frtk%3D","updated":"2012-12-02 06:39:44.000000000","message":"Understood, but can you please explain why we should prevent block migration for volume backed roots without shared storage?\nI referred to this doc regarding migration. http://docs.openstack.org/folsom/openstack-compute/admin/content/configuring-migrations.html","commit_id":"37df2052d7b9666c72478de79b46a60b15c9f4fd"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"c3c00021d330e3449cd9107f297d30aa1b0c3cdd","unresolved":false,"context_lines":[{"line_number":2319,"context_line":""},{"line_number":2320,"context_line":"        elif not shared and not is_volume_backed:"},{"line_number":2321,"context_line":"            reason \u003d _(\"Live migration can not be used \""},{"line_number":2322,"context_line":"                       \"without shared storage.\")"},{"line_number":2323,"context_line":"            raise exception.InvalidSharedStorage(reason\u003dreason, path\u003dsource)"},{"line_number":2324,"context_line":"        dest_check_data.update({\"is_shared_storage\": shared})"},{"line_number":2325,"context_line":"        return dest_check_data"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F%2BWM%3D","line":2322,"updated":"2012-12-04 11:52:02.000000000","message":"Should this reason be updated?","commit_id":"86e3e074e8715f06998a81b94359ab712aed70a1"}]}