)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a513542ab950a619dcadf21d5a22cd03c0793017","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        try:"},{"line_number":259,"context_line":"            length \u003d len(valid_values)"},{"line_number":260,"context_line":"        except TypeError:"},{"line_number":261,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":262,"context_line":"        if length \u003d\u003d 0:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":264,"context_line":"        self._valid_values \u003d valid_values"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_8a58f8fb","line":261,"updated":"2015-04-07 16:19:03.000000000","message":"If this is dev-only when we hit this, do we need the translatable message?  I\u0027d think not, and thus avoid the string freeze exception.","commit_id":"80b168865a4e7a5c74eba78b9a69e57d0de4511a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"a6b0e410adf87fc3d5475e9db96809dd873888cb","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        try:"},{"line_number":259,"context_line":"            length \u003d len(valid_values)"},{"line_number":260,"context_line":"        except TypeError:"},{"line_number":261,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":262,"context_line":"        if length \u003d\u003d 0:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":264,"context_line":"        self._valid_values \u003d valid_values"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_e07e85ad","line":261,"updated":"2015-04-07 17:07:53.000000000","message":"Agree with Matt.  This is dev facing and the value of the check is greater than the value of the translation so I would leave it off for now.  But these messages could be better.  Something like \"valid_values must be an iterable type\" here and \"valid_values must not be empty\" below.","commit_id":"60a2138938725d148870f7d3c2214503c0c02ede"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7ecc535c42b8361ffb21b8d196931be6a46ccd3","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        try:"},{"line_number":259,"context_line":"            length \u003d len(valid_values)"},{"line_number":260,"context_line":"        except TypeError:"},{"line_number":261,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":262,"context_line":"        if length \u003d\u003d 0:"},{"line_number":263,"context_line":"            raise ValueError(_(\u0027valid_values is required\u0027))"},{"line_number":264,"context_line":"        self._valid_values \u003d valid_values"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_3bf93c81","line":261,"in_reply_to":"9aa53dc9_e07e85ad","updated":"2015-04-07 17:20:36.000000000","message":"Yep, was trying to keep it to one string if we were going to translate it after string freeze.","commit_id":"60a2138938725d148870f7d3c2214503c0c02ede"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"41324da6b3f22eedd675dca1f3c9ebfba4f4dfda","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class Enum(String):"},{"line_number":257,"context_line":"    def __init__(self, valid_values, **kwargs):"},{"line_number":258,"context_line":"        try:"},{"line_number":259,"context_line":"            length \u003d len(valid_values)"},{"line_number":260,"context_line":"        except TypeError:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_ba42e53c","line":257,"updated":"2015-04-07 17:50:22.000000000","message":"I would have preferred simpler code:\n\n    try:\n        if not(len(valid_values)):\n            raise ValueError(\"Blah...\")\n    except TypeError:\n            raise ValueError(\"Blah...\")","commit_id":"c741f98e048dc45f7f70232790b951b2b9ddf713"}]}