)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c3c30ac7aea8c2b37920f233775115d30b3eefdf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In hyperv, xen and vmware, these api don\u0027t pass migrate_data to the"},{"line_number":10,"context_line":"live migration recover method. So if live migration failed, the"},{"line_number":11,"context_line":"instance\u0027s image will be deleted in cleanup action if the instance"},{"line_number":12,"context_line":"is using shared block device like ceph rbd."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug: 1439609"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_55d61e28","line":12,"updated":"2015-09-21 23:26:59.000000000","message":"Can we have more detail about where and how shared storage is being deleted currently (describe the bug more)? I see some checking for \u0027is_shared_block_storage\u0027 in _live_migration_cleanup_flags, but I don\u0027t see any code that sets that key in migrate_data anywhere.","commit_id":"f4337d881d91d11744c7be56af515e6a59d2adce"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"29770bc61678948bf74772d62e220fbd05fc889c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The method _rollback_live_migration() requires migrate_data to calculate"},{"line_number":10,"context_line":"if it will do cleanup or destroy_disks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In hyperv, xen and vmware, these api don\u0027t pass migrate_data to the"},{"line_number":13,"context_line":"live migration recover method. So if live migration failed, the"},{"line_number":14,"context_line":"instance\u0027s image will be deleted in cleanup action if the instance"},{"line_number":15,"context_line":"is using shared block device like ceph rbd."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a68dd71_1bc55d5a","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":25},"updated":"2016-01-27 23:29:57.000000000","message":"When I saw this mentioned I looked for changes in the vmware driver and there aren\u0027t any in this patch. Then I found vmware doesn\u0027t implement the live_migration method at all, so it seems unrelated to this fix","commit_id":"f1b54de5286712cf171248cf6d2f8d3e7fa2372d"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"c3d944cebe64daee85272c928106ae64e2606a40","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The method _rollback_live_migration() requires migrate_data to calculate"},{"line_number":10,"context_line":"if it will do cleanup or destroy_disks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In hyperv, xen and vmware, these api don\u0027t pass migrate_data to the"},{"line_number":13,"context_line":"live migration recover method. So if live migration failed, the"},{"line_number":14,"context_line":"instance\u0027s image will be deleted in cleanup action if the instance"},{"line_number":15,"context_line":"is using shared block device like ceph rbd."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_857ed5e2","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":25},"in_reply_to":"9a68dd71_1bc55d5a","updated":"2016-01-28 02:26:25.000000000","message":"Done","commit_id":"f1b54de5286712cf171248cf6d2f8d3e7fa2372d"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"750f3f101e562a8d2277b08f85388d8157ee720b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        \"\"\"Live migration of an instance to another host.\"\"\""},{"line_number":305,"context_line":"        self._vmops.live_migration(context, instance, dest,"},{"line_number":306,"context_line":"                                   post_method, recover_method,"},{"line_number":307,"context_line":"                                   block_migration, migrate_data)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def rollback_live_migration_at_destination(self, context, instance,"},{"line_number":310,"context_line":"                                               network_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_0483eccd","line":307,"updated":"2015-04-23 06:16:22.000000000","message":"The method does not have the parameter \u0027migrate_data\u0027","commit_id":"ffe7c457ade2e2f819e461ea2254e2025cdec275"}]}