)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"413295b55e1b933262f890dba54c3f557cf65b58","unresolved":false,"context_lines":[{"line_number":12,"context_line":"it as the option --uuid. The parameter is currently being ignored"},{"line_number":13,"context_line":"by the nova-network manager. This change sets the uuid when creating"},{"line_number":14,"context_line":"the network if it has been specified."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1441931"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib29e632b09905f557a7a6910d58207ed91cdc047"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa53dc9_1513925c","line":15,"updated":"2015-04-09 13:00:26.000000000","message":"Shouldn\u0027t this have a \"Depends-On: Ib5933b1405c0761ff727e04cda0c502a826c8eaf\" so we run the cells job against that devstack change to show it works?","commit_id":"b8f890198f6258004d757bb74655ed29f0968208"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e92117d592e0da1688d6772bf8160afb005d78cc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"it as the option --uuid. The parameter is currently being ignored"},{"line_number":13,"context_line":"by the nova-network manager. This change sets the uuid when creating"},{"line_number":14,"context_line":"the network if it has been specified."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1441931"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib29e632b09905f557a7a6910d58207ed91cdc047"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aa53dc9_d5ec0af5","line":15,"in_reply_to":"9aa53dc9_1513925c","updated":"2015-04-09 13:17:45.000000000","message":"We would want this the other way right?  Have the Devstack change depend on this since this allows that to work.","commit_id":"b8f890198f6258004d757bb74655ed29f0968208"}],"nova/network/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"28426243c47e2107c4870936544eab6df52b6943","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        subnets \u003d itertools.izip_longest(subnets_v4, subnets_v6)"},{"line_number":1313,"context_line":"        for index, (subnet_v4, subnet_v6) in enumerate(subnets):"},{"line_number":1314,"context_line":"            net \u003d objects.Network(context\u003dcontext)"},{"line_number":1315,"context_line":"            uuid \u003d kwargs.get(\u0027uuid\u0027)"},{"line_number":1316,"context_line":"            if uuid:"},{"line_number":1317,"context_line":"                net.uuid \u003d uuid"},{"line_number":1318,"context_line":"            net.bridge \u003d bridge"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_0f5496c7","line":1315,"updated":"2015-04-09 16:58:01.000000000","message":"So uuid is not nullable, i wondering to know if we can pass it to nullable. \n\n  uuid \u003d kwargs.get(\u0027uuid\u0027, \"\")\n\nWe can probably set it to an empty string by default but that will make an unnecessary write to the database.","commit_id":"4209ab30be91b345bf6c9a0165af14c692ca26bd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ed2fedfd2931dfd1369eb438ec0078c17b186179","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        subnets \u003d itertools.izip_longest(subnets_v4, subnets_v6)"},{"line_number":1313,"context_line":"        for index, (subnet_v4, subnet_v6) in enumerate(subnets):"},{"line_number":1314,"context_line":"            net \u003d objects.Network(context\u003dcontext)"},{"line_number":1315,"context_line":"            uuid \u003d kwargs.get(\u0027uuid\u0027)"},{"line_number":1316,"context_line":"            if uuid:"},{"line_number":1317,"context_line":"                net.uuid \u003d uuid"},{"line_number":1318,"context_line":"            net.bridge \u003d bridge"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_cf4c6ea0","line":1315,"in_reply_to":"9aa53dc9_0f5496c7","updated":"2015-04-09 17:15:57.000000000","message":"I considered similar, but at the db layer uuid is generated and overwritten if something is passed. So we could generate our own uuid to pass as a default here, but I thought maybe it\u0027s better to leave that logic in the db layer.\n\n https://github.com/openstack/nova/blob/af4ce3e/nova/db/sqlalchemy/api.py#L2800-L2803","commit_id":"4209ab30be91b345bf6c9a0165af14c692ca26bd"}],"nova/tests/unit/network/test_manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c8f488d48ad07d453de09a1f42e55b164dfbc19a","unresolved":false,"context_lines":[{"line_number":2271,"context_line":"        net \u003d nets[0]"},{"line_number":2272,"context_line":"        self.assertEqual(label, net[\u0027label\u0027])"},{"line_number":2273,"context_line":"        self.assertEqual(cidr, net[\u0027cidr\u0027])"},{"line_number":2274,"context_line":"        self.assertEqual(uuid, net[\u0027uuid\u0027])"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"    @mock.patch(\u0027nova.db.network_get_all\u0027)"},{"line_number":2277,"context_line":"    def test_create_networks_cidr_already_used(self, get_all):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_648000c1","line":2274,"updated":"2015-04-09 07:53:53.000000000","message":"nit: I would have left the unittest as it is and would have added a check for if the uuid is passed, but wrt the criticity, I think we can merge it.","commit_id":"b8f890198f6258004d757bb74655ed29f0968208"}]}