)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec26ec71bd46f0863992200368dc323a818b6aac","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                                                      count\u003dnum_networks))"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        if cidr:"},{"line_number":1267,"context_line":"            # NOTE(jkoelker): This replaces the _validate_cidrs call and"},{"line_number":1268,"context_line":"            #                 prevents looping multiple times"},{"line_number":1269,"context_line":"            try:"},{"line_number":1270,"context_line":"                nets \u003d objects.NetworkList.get_all(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_ce57cf58","side":"PARENT","line":1267,"updated":"2015-04-09 17:58:23.000000000","message":"I would have probably left this part in here, then passed nets to the new _validate_cidr method that can just worry about validation and not have to return the network objects list, which makes it a bit clunky.","commit_id":"c99d7ab0384d9b7bbcc78c9cf6086aac9baaee6b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"de7e5a995be79b55543b3b01c0cc42e25b74301b","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"                                                      count\u003dnum_networks))"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        if cidr:"},{"line_number":1267,"context_line":"            # NOTE(jkoelker): This replaces the _validate_cidrs call and"},{"line_number":1268,"context_line":"            #                 prevents looping multiple times"},{"line_number":1269,"context_line":"            try:"},{"line_number":1270,"context_line":"                nets \u003d objects.NetworkList.get_all(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_0e4c979c","side":"PARENT","line":1267,"in_reply_to":"9aa53dc9_ce57cf58","updated":"2015-04-09 18:01:29.000000000","message":"Makes sense","commit_id":"c99d7ab0384d9b7bbcc78c9cf6086aac9baaee6b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71196f3e0e45e739e7e0a8e9e07c0c9a5e47bd07","unresolved":false,"context_lines":[{"line_number":1370,"context_line":""},{"line_number":1371,"context_line":"            if CONF.network_manager \u003d\u003d \u0027nova.network.manager.VlanManager\u0027:"},{"line_number":1372,"context_line":"                vlan \u003d kwargs.get(\u0027vlan\u0027, None)"},{"line_number":1373,"context_line":"                if not vlan:"},{"line_number":1374,"context_line":"                    index_vlan \u003d index + num_used_nets"},{"line_number":1375,"context_line":"                    vlan \u003d kwargs[\u0027vlan_start\u0027] + index_vlan"},{"line_number":1376,"context_line":"                    used_vlans \u003d [x.vlan for x in nets]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_916fa82a","line":1373,"updated":"2015-04-09 18:18:18.000000000","message":"This is completely beside the point of the patch, but if cidr is False, this will blow up since num_used_nets won\u0027t be set.  Maybe it\u0027s a case that wouldn\u0027t happen.","commit_id":"3d3083562371fb1ffb1a89d791cfd469035873a6"}]}