)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8615fd294c548323238d50179818b683fb27c4ce","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    if instance_cell.pagesize and instance_cell.pagesize !\u003d MEMPAGES_SMALL:"},{"line_number":767,"context_line":"        # NOTE(sahid): The condition \"instance_cell.pagesize !\u003d MEMPAGES_SMALL\""},{"line_number":768,"context_line":"        # if for backward compatibility with instance that explicity request"},{"line_number":769,"context_line":"        # to use small pages. Can be removed for M*."},{"line_number":770,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":771,"context_line":"            host_cell, instance_cell)"},{"line_number":772,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_5a18fe74","line":769,"updated":"2015-04-10 12:08:16.000000000","message":"We can\u0027t really even remove this I think so this comment is missleading (unless we online-migrate DB using objects or a one shot script).\n\nThat might be a better approach.","commit_id":"b9cb49c5c9eb5991bc4f8a72563ec0f4a4f09ef2"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"26de96becd9706b8ff236267466919ab28c4fabc","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    if instance_cell.pagesize and instance_cell.pagesize !\u003d MEMPAGES_SMALL:"},{"line_number":767,"context_line":"        # NOTE(sahid): The condition \"instance_cell.pagesize !\u003d MEMPAGES_SMALL\""},{"line_number":768,"context_line":"        # if for backward compatibility with instance that explicity request"},{"line_number":769,"context_line":"        # to use small pages. Can be removed for M*."},{"line_number":770,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":771,"context_line":"            host_cell, instance_cell)"},{"line_number":772,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_4b17b151","line":769,"in_reply_to":"7aaa499b_4be21105","updated":"2015-04-13 09:56:07.000000000","message":"Well you can\u0027t really disallow MEMPAGES_SMALL because that will break for people having it in their flavors/images after they upgrade.\n\nLuckily - this case is easy, we can just accept it and disregard it (right?)\n\nIf that is the case we maybe don\u0027t need the object stuff (thou it would be nice to clean up the stuff left in the DB)","commit_id":"b9cb49c5c9eb5991bc4f8a72563ec0f4a4f09ef2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f1d8108e5cd31108a0197a0646ee83a88395c3be","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    if instance_cell.pagesize and instance_cell.pagesize !\u003d MEMPAGES_SMALL:"},{"line_number":767,"context_line":"        # NOTE(sahid): The condition \"instance_cell.pagesize !\u003d MEMPAGES_SMALL\""},{"line_number":768,"context_line":"        # if for backward compatibility with instance that explicity request"},{"line_number":769,"context_line":"        # to use small pages. Can be removed for M*."},{"line_number":770,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":771,"context_line":"            host_cell, instance_cell)"},{"line_number":772,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_4be21105","line":769,"in_reply_to":"9aa53dc9_5a18fe74","updated":"2015-04-13 09:40:36.000000000","message":"Well after this change we should not be able to request for a MEMPAGES_SMALL and instances already running with this request will pass here only when resize/migrate. but yes perhaps we should keep this.\n\nI feel better to let this migration happening incrementally","commit_id":"b9cb49c5c9eb5991bc4f8a72563ec0f4a4f09ef2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"948b426a65e11c9125850befc6915a954ccda3c1","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        elif request \u003d\u003d \"large\":"},{"line_number":814,"context_line":"            return MEMPAGES_LARGE"},{"line_number":815,"context_line":"        elif request \u003d\u003d \"small\":"},{"line_number":816,"context_line":"            return MEMPAGES_SMALL"},{"line_number":817,"context_line":"        else:"},{"line_number":818,"context_line":"            try:"},{"line_number":819,"context_line":"                request \u003d int(request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_acc1a830","side":"PARENT","line":816,"updated":"2015-04-13 12:55:08.000000000","message":"So if users have flavor/image with a request \u003d\u003d \"small\" we have to return None to do not break process. I need to update this part.","commit_id":"6b69b705481958bc55f9d4e29732b09a45f392a5"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"5831abf9d9f3dd02c844d9b69de4a9627aee5bf3","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # is for backward compatibility with instance that explicity have"},{"line_number":769,"context_line":"        # requested to use small pages."},{"line_number":770,"context_line":"        # MEMPAGES_SMALL is no longer supported and this condition will ensure"},{"line_number":771,"context_line":"        # to clean cells of a pagesize request when migrate/resize."},{"line_number":772,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":773,"context_line":"            host_cell, instance_cell)"},{"line_number":774,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_bc5e2f10","line":771,"updated":"2015-04-15 05:15:23.000000000","message":"If using the MEMPAGES_SMALL, maybe, we need not to generate an instance numa topology.","commit_id":"b520049ae4ee11cfeac4bdf1272caa6f9fd21107"},{"author":{"_account_id":11530,"name":"zhangtralon","email":"ztralon@hotmail.com","username":"zhangtralon"},"change_message_id":"3f47e9a89893f1f68eea7a79506974e719c32cbb","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # is for backward compatibility with instance that explicity have"},{"line_number":769,"context_line":"        # requested to use small pages."},{"line_number":770,"context_line":"        # MEMPAGES_SMALL is no longer supported and this condition will ensure"},{"line_number":771,"context_line":"        # to clean cells of a pagesize request when migrate/resize."},{"line_number":772,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":773,"context_line":"            host_cell, instance_cell)"},{"line_number":774,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_db9efe06","line":771,"in_reply_to":"7aaa499b_5430179e","updated":"2015-04-20 03:14:05.000000000","message":"I mean that if users set the pagesize equal to MEMPAGES_SMALL, we need not to generate the numa topology in nova-api process.","commit_id":"b520049ae4ee11cfeac4bdf1272caa6f9fd21107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4d1cc34a16ceba54a5be7a5132d9269968f7745f","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # is for backward compatibility with instance that explicity have"},{"line_number":769,"context_line":"        # requested to use small pages."},{"line_number":770,"context_line":"        # MEMPAGES_SMALL is no longer supported and this condition will ensure"},{"line_number":771,"context_line":"        # to clean cells of a pagesize request when migrate/resize."},{"line_number":772,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":773,"context_line":"            host_cell, instance_cell)"},{"line_number":774,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_5430179e","line":771,"in_reply_to":"7aaa499b_bc5e2f10","updated":"2015-04-15 11:38:33.000000000","message":"I\u0027m not sure to understand, if we are here it\u0027s because the instance already defines a numa topology. Can you give me more detail about your assumption ?","commit_id":"b520049ae4ee11cfeac4bdf1272caa6f9fd21107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e5e623734a039e7449daeb7568864f83cb5a44e3","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # is for backward compatibility with instance that explicity have"},{"line_number":769,"context_line":"        # requested to use small pages."},{"line_number":770,"context_line":"        # MEMPAGES_SMALL is no longer supported and this condition will ensure"},{"line_number":771,"context_line":"        # to clean cells of a pagesize request when migrate/resize."},{"line_number":772,"context_line":"        pagesize \u003d _numa_cell_supports_pagesize_request("},{"line_number":773,"context_line":"            host_cell, instance_cell)"},{"line_number":774,"context_line":"        if not pagesize:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_819462e2","line":771,"in_reply_to":"dac4157f_db9efe06","updated":"2015-04-21 07:39:19.000000000","message":"Yes, this is done by the change line 816","commit_id":"b520049ae4ee11cfeac4bdf1272caa6f9fd21107"}]}