)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        super(ComputeManager, self).__init__(service_name\u003d\"compute\","},{"line_number":692,"context_line":"                                             *args, **kwargs)"},{"line_number":693,"context_line":"        self.additional_endpoints.append(_ComputeV4Proxy(self))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        # NOTE(russellb) Load the driver last.  It may call back into the"},{"line_number":696,"context_line":"        # compute manager via the virtapi, so we want it to be fully"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_0b14899d","line":693,"updated":"2015-04-09 17:53:28.000000000","message":"This adds the class below as an allowed interface for RPC dispatch.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b36f7f9b8573bd06e90fc5777f9f6da5c3b54680","unresolved":false,"context_lines":[{"line_number":2494,"context_line":"                     is_first_time, node, legacy_bdm_in_spec):"},{"line_number":2495,"context_line":"        # NOTE(alaski) This method should be deprecated when the scheduler and"},{"line_number":2496,"context_line":"        # compute rpc interfaces are bumped to 4.x, and slated for removal in"},{"line_number":2497,"context_line":"        # 5.x as it is no longer used."},{"line_number":2498,"context_line":""},{"line_number":2499,"context_line":"        if filter_properties is None:"},{"line_number":2500,"context_line":"            filter_properties \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_b1b86c76","line":2497,"updated":"2015-04-09 18:22:27.000000000","message":"This can be updated to indicate the deprecation.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":6548,"context_line":"        self.driver.unquiesce(context, instance, image_meta)"},{"line_number":6549,"context_line":""},{"line_number":6550,"context_line":""},{"line_number":6551,"context_line":"class _ComputeV4Proxy(object):"},{"line_number":6552,"context_line":""},{"line_number":6553,"context_line":"    target \u003d messaging.Target(version\u003d\u00274.0\u0027)"},{"line_number":6554,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_eb31655b","line":6551,"updated":"2015-04-09 17:53:28.000000000","message":"This goes away early in Lemming. It purely serves to handle v4.0 requests and forward them to the manager above.  Things (calls, arguments, etc) that were deprecated in 3.x are removed here, or worked around.\n\nWhen we drop 3.x, we delete this and apply the same cleanups above.\n\nThe purpose of this is to allow us to receive 3.x messages and 4.x messages at the same time (i.e. juno or mid-kilo computes, along with kilo-final computes).","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b36f7f9b8573bd06e90fc5777f9f6da5c3b54680","unresolved":false,"context_lines":[{"line_number":6548,"context_line":"        self.driver.unquiesce(context, instance, image_meta)"},{"line_number":6549,"context_line":""},{"line_number":6550,"context_line":""},{"line_number":6551,"context_line":"class _ComputeV4Proxy(object):"},{"line_number":6552,"context_line":""},{"line_number":6553,"context_line":"    target \u003d messaging.Target(version\u003d\u00274.0\u0027)"},{"line_number":6554,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_311b3ccc","line":6551,"in_reply_to":"9aa53dc9_d1b1b002","updated":"2015-04-09 18:22:27.000000000","message":"+1.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b471c606f6b189fe7ba335e0356c89dda07646e","unresolved":false,"context_lines":[{"line_number":6548,"context_line":"        self.driver.unquiesce(context, instance, image_meta)"},{"line_number":6549,"context_line":""},{"line_number":6550,"context_line":""},{"line_number":6551,"context_line":"class _ComputeV4Proxy(object):"},{"line_number":6552,"context_line":""},{"line_number":6553,"context_line":"    target \u003d messaging.Target(version\u003d\u00274.0\u0027)"},{"line_number":6554,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_d1b1b002","line":6551,"in_reply_to":"9aa53dc9_eb31655b","updated":"2015-04-09 18:10:32.000000000","message":"This would be a useful comment in the code.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":6573,"context_line":"    def attach_volume(self, ctxt, instance, bdm):"},{"line_number":6574,"context_line":"        return self.manager.attach_volume(ctxt, None, None,"},{"line_number":6575,"context_line":"                                          instance\u003dinstance,"},{"line_number":6576,"context_line":"                                          bdm\u003dbdm)"},{"line_number":6577,"context_line":""},{"line_number":6578,"context_line":"    def change_instance_metadata(self, ctxt, instance, diff):"},{"line_number":6579,"context_line":"        return self.manager.change_instance_metadata(ctxt, instance, diff)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4b4731bc","line":6576,"updated":"2015-04-09 17:53:28.000000000","message":"Example here: we don\u0027t send mountpoint or volume_id in v4.0, so we just pass None up to the manager above, which still has to maintain compatibility for if they\u0027re present.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b36f7f9b8573bd06e90fc5777f9f6da5c3b54680","unresolved":false,"context_lines":[{"line_number":6573,"context_line":"    def attach_volume(self, ctxt, instance, bdm):"},{"line_number":6574,"context_line":"        return self.manager.attach_volume(ctxt, None, None,"},{"line_number":6575,"context_line":"                                          instance\u003dinstance,"},{"line_number":6576,"context_line":"                                          bdm\u003dbdm)"},{"line_number":6577,"context_line":""},{"line_number":6578,"context_line":"    def change_instance_metadata(self, ctxt, instance, diff):"},{"line_number":6579,"context_line":"        return self.manager.change_instance_metadata(ctxt, instance, diff)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_9156885a","line":6576,"in_reply_to":"9aa53dc9_4b4731bc","updated":"2015-04-09 18:22:27.000000000","message":"This, and any other instances, would also be useful to have commented in the code.  Then someone doesn\u0027t have to duplicate your analysis later when this is removed.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"848628ceed754f9a1b63ad6c069a38be98a53d4f","unresolved":false,"context_lines":[{"line_number":6598,"context_line":"        return self.manager.detach_interface(ctxt, instance, port_id)"},{"line_number":6599,"context_line":""},{"line_number":6600,"context_line":"    def detach_volume(self, ctxt, instance, volume_id):"},{"line_number":6601,"context_line":"        return self.manager.detach_volume(ctxt, volume_id, instance)"},{"line_number":6602,"context_line":""},{"line_number":6603,"context_line":"    def finish_resize(self, ctxt, disk_info, image, instance,"},{"line_number":6604,"context_line":"                      reservations, migration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_ba5a81f0","line":6601,"updated":"2015-04-09 19:22:57.000000000","message":"doh","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d1528f59bd3952a16596645bb893e6d847f269e1","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        super(ComputeManager, self).__init__(service_name\u003d\"compute\","},{"line_number":692,"context_line":"                                             *args, **kwargs)"},{"line_number":693,"context_line":"        self.additional_endpoints.append(_ComputeV4Proxy(self))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        # NOTE(russellb) Load the driver last.  It may call back into the"},{"line_number":696,"context_line":"        # compute manager via the virtapi, so we want it to be fully"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_7fd06bf6","line":693,"updated":"2015-04-09 19:04:30.000000000","message":"I wonder if it wouldn\u0027t be better to have a ComputeV3Proxy and leave the methods here but moving the deprecated ones in there ? I would make clearer to see what methods are removed, like run_instance() IMHO.","commit_id":"6fda4daf24f5ad673c740095f417d3bd0cb45067"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        if self.client.can_send_version(current):"},{"line_number":313,"context_line":"            return current"},{"line_number":314,"context_line":"        else:"},{"line_number":315,"context_line":"            return legacy"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    # Cells overrides this"},{"line_number":318,"context_line":"    def get_client(self, target, version_cap, serializer):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_8b6f792a","line":315,"updated":"2015-04-09 17:53:28.000000000","message":"This is just a helper function that chooses between current and legacy for cases where we are going to send the same thing for either, but just need to choose the right version.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                           parameter for the remote method."},{"line_number":331,"context_line":"        :param host: This is the host to send the message to."},{"line_number":332,"context_line":"        \u0027\u0027\u0027"},{"line_number":333,"context_line":"        version \u003d self._compat_ver(\u00274.0\u0027, \u00273.0\u0027)"},{"line_number":334,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":335,"context_line":"        cctxt.cast(ctxt, \u0027add_aggregate_host\u0027,"},{"line_number":336,"context_line":"                   aggregate\u003daggregate, host\u003dhost_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_eb660550","line":333,"updated":"2015-04-09 17:53:28.000000000","message":"Example here: message has been the same for a long time, we just need to use the right version in the message.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    def attach_volume(self, ctxt, instance, volume_id, mountpoint, bdm\u003dNone):"},{"line_number":356,"context_line":"        kw \u003d {\u0027instance\u0027: instance, \u0027bdm\u0027: bdm}"},{"line_number":357,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":358,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":359,"context_line":"        else:"},{"line_number":360,"context_line":"            version \u003d \u00273.16\u0027"},{"line_number":361,"context_line":"            kw[\u0027mountpoint\u0027] \u003d mountpoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4b4cd1c7","line":358,"updated":"2015-04-09 17:53:28.000000000","message":"Per the note from ndipanov to the left, we just don\u0027t include those older parameters if we\u0027re making a 4.0 call.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    def detach_volume(self, ctxt, instance, volume_id):"},{"line_number":460,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":461,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":462,"context_line":"        elif self.client.can_send_version(\u00273.25\u0027):"},{"line_number":463,"context_line":"            version \u003d \u00273.25\u0027"},{"line_number":464,"context_line":"        else:"},{"line_number":465,"context_line":"            version \u003d \u00273.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4be3b1a4","line":462,"updated":"2015-04-09 17:53:28.000000000","message":"4.0 and 3.25 are functionally the same, we just need to send the right version. This is one pattern you will see below where we were modifying the call for the older version. Thus, I just kept this pattern to make the delta small and easy to understand. When we drop 4.x the entire if block will go away.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b471c606f6b189fe7ba335e0356c89dda07646e","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    def detach_volume(self, ctxt, instance, volume_id):"},{"line_number":460,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":461,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":462,"context_line":"        elif self.client.can_send_version(\u00273.25\u0027):"},{"line_number":463,"context_line":"            version \u003d \u00273.25\u0027"},{"line_number":464,"context_line":"        else:"},{"line_number":465,"context_line":"            version \u003d \u00273.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_91c68898","line":462,"in_reply_to":"9aa53dc9_4be3b1a4","updated":"2015-04-09 18:10:32.000000000","message":"I guess we don\u0027t use:\n\nversion \u003d self._compat_ver(\u00274.0\u0027, \u00273.25\u0027)\n\nBecause we have the 3.0 case also, damn it\u0027s hairy hide.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":719,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":720,"context_line":"            msg_args[\u0027clean_shutdown\u0027] \u003d clean_shutdown"},{"line_number":721,"context_line":"            msg_args[\u0027rescue_image_ref\u0027] \u003d rescue_image_ref"},{"line_number":722,"context_line":"        elif self.client.can_send_version(\u00273.37\u0027):"},{"line_number":723,"context_line":"            version \u003d \u00273.37\u0027"},{"line_number":724,"context_line":"            msg_args[\u0027clean_shutdown\u0027] \u003d clean_shutdown"},{"line_number":725,"context_line":"            msg_args[\u0027rescue_image_ref\u0027] \u003d rescue_image_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_cb9c6110","line":722,"updated":"2015-04-09 17:53:28.000000000","message":"Yes, this is copying code, but it\u0027s easier to understand than adding some complicated version-choosing statements. This goes away when lemming opens, so it\u0027s worth it for clarity, IMHO.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9d619f6975d433732421d5d3c394f0c9a08da63c","unresolved":false,"context_lines":[{"line_number":825,"context_line":"              \u0027device_type\u0027: device_type, \u0027return_bdm_object\u0027: True}"},{"line_number":826,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":827,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":828,"context_line":"            del kw[\u0027return_bdm_object\u0027]"},{"line_number":829,"context_line":"        elif self.client.can_send_version(\u00273.35\u0027):"},{"line_number":830,"context_line":"            version \u003d \u00273.35\u0027"},{"line_number":831,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_ebc285e8","line":828,"updated":"2015-04-09 17:53:28.000000000","message":"In 4.0 it\u0027s assumed that we will return a BDM object, so we don\u0027t need to keep sending the flag.","commit_id":"ea238822f7589d96c603a30b3da0596d024e6ae2"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d1528f59bd3952a16596645bb893e6d847f269e1","unresolved":false,"context_lines":[{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":773,"context_line":"        cctxt.cast(ctxt, \u0027run_instance\u0027, **msg_kwargs)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def set_admin_password(self, ctxt, instance, new_pass):"},{"line_number":776,"context_line":"        version \u003d \u00273.8\u0027"},{"line_number":777,"context_line":"        cctxt \u003d self.client.prepare(server\u003d_compute_host(None, instance),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_1f06ff85","side":"PARENT","line":774,"updated":"2015-04-09 19:04:30.000000000","message":"Yay ! \\o/","commit_id":"8fda81041a0f4492461b40cdc3894a9ae239a36f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfcf0a867425a6ad2887bf886a64a700a4a8ec12","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        # storage was buggy (potential loss of data) before version 3.32."},{"line_number":377,"context_line":"        # Since we need to support live migration with older clients, we need"},{"line_number":378,"context_line":"        # to warn the operator of this possibility. The logic below tries to"},{"line_number":379,"context_line":"        # decide if a warning should be emitted, assuming the positive if"},{"line_number":380,"context_line":"        # not sure. This can be removed when we bump to RPC API version 4.0."},{"line_number":381,"context_line":"        if data:"},{"line_number":382,"context_line":"            if data.get(\u0027is_shared_block_storage\u0027) is not False:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_8adf6a39","line":379,"updated":"2015-04-09 22:25:03.000000000","message":"Anything to change with this?","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3033c9af80807d706e31fd7306aa1f25aab52e92","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        # storage was buggy (potential loss of data) before version 3.32."},{"line_number":377,"context_line":"        # Since we need to support live migration with older clients, we need"},{"line_number":378,"context_line":"        # to warn the operator of this possibility. The logic below tries to"},{"line_number":379,"context_line":"        # decide if a warning should be emitted, assuming the positive if"},{"line_number":380,"context_line":"        # not sure. This can be removed when we bump to RPC API version 4.0."},{"line_number":381,"context_line":"        if data:"},{"line_number":382,"context_line":"            if data.get(\u0027is_shared_block_storage\u0027) is not False:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_8a008a67","line":379,"in_reply_to":"9aa53dc9_8adf6a39","updated":"2015-04-09 22:29:43.000000000","message":"It just goes away when we dump 3.x. Otherwise it doesn\u0027t need anything, no.","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfcf0a867425a6ad2887bf886a64a700a4a8ec12","unresolved":false,"context_lines":[{"line_number":825,"context_line":"              \u0027device_type\u0027: device_type, \u0027return_bdm_object\u0027: True}"},{"line_number":826,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":827,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":828,"context_line":"            del kw[\u0027return_bdm_object\u0027]"},{"line_number":829,"context_line":"        elif self.client.can_send_version(\u00273.35\u0027):"},{"line_number":830,"context_line":"            version \u003d \u00273.35\u0027"},{"line_number":831,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_6acc266a","line":828,"updated":"2015-04-09 22:25:03.000000000","message":"Why is this needed for 4.0 but not 3.35?","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3033c9af80807d706e31fd7306aa1f25aab52e92","unresolved":false,"context_lines":[{"line_number":825,"context_line":"              \u0027device_type\u0027: device_type, \u0027return_bdm_object\u0027: True}"},{"line_number":826,"context_line":"        if self.client.can_send_version(\u00274.0\u0027):"},{"line_number":827,"context_line":"            version \u003d \u00274.0\u0027"},{"line_number":828,"context_line":"            del kw[\u0027return_bdm_object\u0027]"},{"line_number":829,"context_line":"        elif self.client.can_send_version(\u00273.35\u0027):"},{"line_number":830,"context_line":"            version \u003d \u00273.35\u0027"},{"line_number":831,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_aa090e86","line":828,"in_reply_to":"9aa53dc9_6acc266a","updated":"2015-04-09 22:29:43.000000000","message":"Before 3.35, the parameter didn\u0027t exist, which is why it\u0027s removed in the else below. At 3.35, we added that to indicate that we\u0027re a new-enough client to expect an object back. In 4.0, that is assumed, so we don\u0027t need to pass the flag anymore.\n\nThat\u0027s why the manager method in the 4.0 proxy doesn\u0027t take this as an argument, and why it passes it as always true to the 3.x manager. When we drop the 3.x stuff, we\u0027ll just always return an object and not support receiving this flag (like the 4.x proxy does now).","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cfcf0a867425a6ad2887bf886a64a700a4a8ec12","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            requested_networks\u003dNone, security_groups\u003dNone,"},{"line_number":991,"context_line":"            block_device_mapping\u003dNone, node\u003dNone, limits\u003dNone):"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":994,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":995,"context_line":"            version \u003d \u00273.40\u0027"},{"line_number":996,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_cae332d8","line":993,"updated":"2015-04-09 22:25:03.000000000","message":"Why not just:\n\nversion \u003d self._compat_ver(\u00274.0\u0027, \u00273.40\u0027)","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3033c9af80807d706e31fd7306aa1f25aab52e92","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            requested_networks\u003dNone, security_groups\u003dNone,"},{"line_number":991,"context_line":"            block_device_mapping\u003dNone, node\u003dNone, limits\u003dNone):"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":994,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":995,"context_line":"            version \u003d \u00273.40\u0027"},{"line_number":996,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_aa80eebf","line":993,"in_reply_to":"9aa53dc9_cae332d8","updated":"2015-04-09 22:29:43.000000000","message":"Could, I was just mirroring the pattern below.","commit_id":"ebfa09fa197a1d88d1b3ab1f308232c3df7dc009"}]}