)]}'
{"id":"openstack%2Fnova~172693","triplet_id":"openstack%2Fnova~master~Ib151c3d67cc91957d8a7dedc4cdaf8c4de1da6c7","project":"openstack/nova","branch":"master","topic":"Bug1436897","hashtags":[],"change_id":"Ib151c3d67cc91957d8a7dedc4cdaf8c4de1da6c7","subject":"Fix the race condition in instance_create when checking for duplicate hostname","status":"ABANDONED","created":"2015-04-12 01:24:39.000000000","updated":"2015-05-21 07:57:10.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ca899fa60f3699928d3b41177d67b342177c816a","_number":172693,"virtual_id_number":172693,"owner":{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-04-12 02:38:11.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-04-12 02:24:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-04-13 09:45:06.000000000","_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},{"date":"2015-04-12 01:40:13.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":1,"date":"2015-04-12 01:48:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},{"value":-1,"date":"2015-04-12 09:02:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":-1,"date":"2015-04-12 15:10:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-12 01:40:13.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-04-12 01:48:43.000000000","updated_by":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-04-12 02:24:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-04-12 02:38:11.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-04-12 09:02:38.000000000","updated_by":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"reviewer":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"state":"REVIEWER"},{"updated":"2015-04-12 15:10:25.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"}],"messages":[{"id":"b47287e6cf3933be68ca5111d5afb988dd7eab62","author":{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},"date":"2015-04-12 01:24:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"68b862308b8085487c0f30f431152ebc45fbd8e4","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2015-04-12 01:40:13.000000000","message":"Patch Set 1:\n\n* pci-test http://198.175.100.33/172693/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2ea23dd8f8f713b1f5ac03cf5be70752429d0bf9","author":{"_account_id":9578,"name":"DB Datasets CI","email":"turbo-hipster@lists.rcbops.com","username":"turbo-hipster","tags":["SERVICE_USER"]},"date":"2015-04-12 01:48:43.000000000","message":"Patch Set 1: Verified+1\n\nDatabase migration testing successful.\n\n- real-db-upgrade_nova_mysql_devstack_131007:th-mysql http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_mysql_devstack_131007:th-mysql/1b1403b11a0144e5b9b1f4bf92a76c77/index.html : SUCCESS in 23m 26s\n- real-db-upgrade_nova_mysql_user_001:th-mysql http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_mysql_user_001:th-mysql/4db23c2f3c164d4fb969838785f2468a/index.html : SUCCESS in 21m 07s\n- real-db-upgrade_nova_percona_devstack_131007:th-percona http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_percona_devstack_131007:th-percona/5ec0c0ea38f34944bed1a7904d6a90e7/index.html : SUCCESS in 19m 47s\n- real-db-upgrade_nova_percona_user_001:th-percona http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_percona_user_001:th-percona/6c47b1f9474e44838ddaf9f0d06d6ef5/index.html : SUCCESS in 21m 43s\n- real-db-upgrade_nova_mysql_user_002:th-mysql http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_mysql_user_002:th-mysql/4da8eabf01ab4dc49ad5620524165f28/index.html : SUCCESS in 19m 57s\n- real-db-upgrade_nova_percona_user_002:th-percona http://www.rcbops.com/turbo_hipster/results/93/172693/1/check/real-db-upgrade_nova_percona_user_002:th-percona/63b96d8bb77245d3aa21b7b7766292dd/index.html : SUCCESS in 18m 47s\n\nTo recheck, leave \u0027recheck migrations\u0027 as a comment. More information: https://wiki.openstack.org/wiki/ThirdPartySystems/DB_Datasets_CI","accounts_in_message":[],"_revision_number":1},{"id":"b2fbfbcf1bc8acf72e1857449c226ffe7c884d84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-12 02:24:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-pep8 http://logs.openstack.org/93/172693/1/check/gate-nova-pep8/8986187/ : SUCCESS in 10m 37s\n- gate-nova-docs http://docs-draft.openstack.org/93/172693/1/check/gate-nova-docs/bcbfd35//doc/build/html/ : SUCCESS in 9m 18s\n- gate-nova-python27 http://logs.openstack.org/93/172693/1/check/gate-nova-python27/dcd9a1c/ : SUCCESS in 13m 24s\n- check-tempest-dsvm-full http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-full/87218cd/ : SUCCESS in 50m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-postgres-full/7abb562/ : SUCCESS in 46m 03s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-neutron-full/d13f501/ : SUCCESS in 48m 09s\n- check-grenade-dsvm http://logs.openstack.org/93/172693/1/check/check-grenade-dsvm/f8e995e/ : SUCCESS in 37m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/93/172693/1/check/gate-tempest-dsvm-large-ops/985228f/ : SUCCESS in 20m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/93/172693/1/check/gate-tempest-dsvm-neutron-large-ops/121fe3f/ : SUCCESS in 19m 27s\n- check-devstack-dsvm-cells http://logs.openstack.org/93/172693/1/check/check-devstack-dsvm-cells/9f14243/ : SUCCESS in 19m 14s\n- gate-nova-tox-functional http://logs.openstack.org/93/172693/1/check/gate-nova-tox-functional/1393bba/ : SUCCESS in 15m 11s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/93/172693/1/check/check-grenade-dsvm-partial-ncpu/e61a828/ : SUCCESS in 35m 53s\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-ironic-pxe_ssh/7486f23/ : SUCCESS in 29m 38s\n- check-tempest-dsvm-nova-v21-full http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-nova-v21-full/6502d7b/ : SUCCESS in 43m 51s\n- check-tempest-dsvm-cells http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-cells/9559bc6/ : FAILURE in 35m 51s (non-voting)\n- check-tempest-dsvm-full-ceph http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-full-ceph/4c16acb/ : SUCCESS in 42m 49s\n- check-tempest-dsvm-aiopcpu-full http://logs.openstack.org/93/172693/1/check/check-tempest-dsvm-aiopcpu-full/5419b4e/ : FAILURE in 58m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3736bb48be9e5eb4c94c0d539509c2a01e0087e8","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2015-04-12 02:38:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- hyper-v-ci http://64.119.130.115/172693/1/ : SUCCESS in 1h 12m 48s","accounts_in_message":[],"_revision_number":1},{"id":"f55a2e49561031ba3ca6889230e6d8e3dfae3b1b","author":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"date":"2015-04-12 09:02:38.000000000","message":"Patch Set 1: Code-Review-1\n\nNo.  You\u0027ve just swapped two race conditions without fixing any of it.","accounts_in_message":[],"_revision_number":1},{"id":"d920ffd37244b78e66a1b9dcb398ad9402ca0892","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2015-04-12 15:10:25.000000000","message":"Patch Set 1: Code-Review-1\n\nyes, I don\u0027t think this fix the race.","accounts_in_message":[],"_revision_number":1},{"id":"baf37d71ac79b016b993ed5acbc2316f120b0ecb","author":{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},"date":"2015-04-13 09:45:06.000000000","message":"Patch Set 1:\n\nyes, it is, I agree with you two guys, do you have any good idea for this issue?","accounts_in_message":[],"_revision_number":1},{"id":"56dfa1687f0c9051e5a5891bb60f2e28ab95f804","author":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"date":"2015-04-13 11:08:39.000000000","message":"Patch Set 1:\n\nStore instance record in database, do all checks and if anything fails - delete record and return error.  Can\u0027t think of a better solution.\n\nIn this case two requests with same hostname will both fail.  Not a big deal, since our use-case for this race condition is when request is being timed-out on client and then retry happens.","accounts_in_message":[],"_revision_number":1},{"id":"f944d0ec0fbf60677f34d7cf7a11bd3a7a6cadc5","author":{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},"date":"2015-05-21 07:57:10.000000000","message":"Abandoned\n\nI can\u0027t find good solution","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4d57a1ad11d02975e2a080b7ff8891a0908209cc","revisions":{"4d57a1ad11d02975e2a080b7ff8891a0908209cc":{"kind":"REWORK","_number":1,"created":"2015-04-12 01:24:39.000000000","uploader":{"_account_id":7653,"name":"Zhengguang Ou","email":"zhengguangou@gmail.com","username":"Zhengguang"},"ref":"refs/changes/93/172693/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/172693/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/172693/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/172693/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/172693/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/172693/1"}}},"commit":{"parents":[{"commit":"7b63c104b9b92c68fa6c0ec88426b9eada7660df","subject":"Merge \"Reserve 10 migrations for backports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7b63c104b9b92c68fa6c0ec88426b9eada7660df"}]}],"author":{"name":"Zhengguang","email":"zhengguangou@gmail.com","date":"2015-04-11 15:32:07.000000000","tz":480},"committer":{"name":"Zhengguang","email":"zhengguangou@gmail.com","date":"2015-04-11 15:32:07.000000000","tz":480},"subject":"Fix the race condition in instance_create when checking for duplicate hostname","message":"Fix the race condition in instance_create when checking for\nduplicate hostname\n\nThere is a race condition in instance_create, that allows creation\nseveral instances with duplicate hostname. Before storing instance\nrecord in database, there is a query for existing records with same\nhostname. However, when we have two instances, running\n_get_sec_group_models() for first instance, then second instance\nwith same hostname will pass through _validate_unique_server_name(),\nthere will be duplicates. This patch reverses them order to fix the\nrace condition.\n\nChange-Id: Ib151c3d67cc91957d8a7dedc4cdaf8c4de1da6c7\nCloses-Bug: #1436897\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4d57a1ad11d02975e2a080b7ff8891a0908209cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4d57a1ad11d02975e2a080b7ff8891a0908209cc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"7b63c104b9b92c68fa6c0ec88426b9eada7660df","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}