)]}'
{"nova/tests/integrated/api_samples/OS-DCF/image-list-resp.json.tpl":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"00385b8d20a7de92ba28c31e739740eb204f215b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        },"},{"line_number":65,"context_line":"        {"},{"line_number":66,"context_line":"            \"created\": \"%(timestamp)s\","},{"line_number":67,"context_line":"            \"id\": \"a2459075-d96c-40d5-893e-577ff92e721c\","},{"line_number":68,"context_line":"            \"links\": ["},{"line_number":69,"context_line":"                {"},{"line_number":70,"context_line":"                    \"href\": \"%(host)s/v2/openstack/images/a2459075-d96c-40d5-893e-577ff92e721c\","}],"source_content_type":"text/x-smarty","patch_set":4,"id":"AAAAMX%2F%2F668%3D","line":67,"updated":"2012-12-06 22:42:56.000000000","message":"forgot this id","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"00385b8d20a7de92ba28c31e739740eb204f215b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        {"},{"line_number":95,"context_line":"            \"OS-DCF:diskConfig\": \"MANUAL\","},{"line_number":96,"context_line":"            \"created\": \"%(timestamp)s\","},{"line_number":97,"context_line":"            \"id\": \"a440c04b-79fa-479c-bed1-0b816eaec379\","},{"line_number":98,"context_line":"            \"links\": ["},{"line_number":99,"context_line":"                {"},{"line_number":100,"context_line":"                    \"href\": \"%(host)s/v2/openstack/images/a440c04b-79fa-479c-bed1-0b816eaec379\","}],"source_content_type":"text/x-smarty","patch_set":4,"id":"AAAAMX%2F%2F664%3D","line":97,"updated":"2012-12-06 22:42:56.000000000","message":"forgot id","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"}],"nova/tests/integrated/test_api_samples.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"8c1739fda7ba17e3cb0fe0c3f9fc9ede6a6f3e09","unresolved":false,"context_lines":[{"line_number":1670,"context_line":""},{"line_number":1671,"context_line":"    def test_create_server(self):"},{"line_number":1672,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1673,"context_line":"        return uuid"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    def test_list_servers_detail(self):"},{"line_number":1676,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Flc%3D","line":1673,"updated":"2012-12-03 12:30:52.000000000","message":"I don\u0027t think this test, the way it is,  is really needed since we already test post server and you don\u0027t call it anywhere else.\nIf you want to keep it here I would do passing disk config options in the requisition instead of using the one from _post_server (I encourage it)","commit_id":"757276de74acb1c2719aeead804985ad378d4fbd"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"8c1739fda7ba17e3cb0fe0c3f9fc9ede6a6f3e09","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1687,"context_line":"        response \u003d self._do_get(\u0027servers/%s\u0027 % uuid)"},{"line_number":1688,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":1689,"context_line":"        subs[\u0027hostid\u0027] \u003d \u0027[a-f0-9]+\u0027"},{"line_number":1690,"context_line":"        return self._verify_response(\u0027server-get-resp\u0027, subs, response)"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    def test_update_server(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Fls%3D","line":1689,"updated":"2012-12-03 12:30:52.000000000","message":"you forgot assertEqual of response status","commit_id":"757276de74acb1c2719aeead804985ad378d4fbd"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"8c1739fda7ba17e3cb0fe0c3f9fc9ede6a6f3e09","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"    def test_update_server(self):"},{"line_number":1693,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1694,"context_line":"        response \u003d self._do_put(\u0027servers/%s\u0027 % uuid,"},{"line_number":1695,"context_line":"                                \u0027server-update-put-req\u0027, {})"},{"line_number":1696,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":1697,"context_line":"        subs[\u0027hostid\u0027] \u003d \u0027[a-f0-9]+\u0027"},{"line_number":1698,"context_line":"        return self._verify_response(\u0027server-update-put-resp\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Flo%3D","line":1695,"updated":"2012-12-03 12:30:52.000000000","message":"you forgot assertEqual of response status","commit_id":"757276de74acb1c2719aeead804985ad378d4fbd"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"8c1739fda7ba17e3cb0fe0c3f9fc9ede6a6f3e09","unresolved":false,"context_lines":[{"line_number":1704,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":1705,"context_line":"                                 \u0027server-resize-post-req\u0027, {})"},{"line_number":1706,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1707,"context_line":"        self.assertEqual(response.read(), \"\")"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def test_rebuild_server(self):"},{"line_number":1710,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Flk%3D","line":1707,"updated":"2012-12-03 12:30:52.000000000","message":"Not really important but I would add a NOTE here pointing to the bug that you\u0027ve opened. Maybe this blank can be removed on the next version \u003d)","commit_id":"757276de74acb1c2719aeead804985ad378d4fbd"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"00385b8d20a7de92ba28c31e739740eb204f215b","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"class DiskConfigJsonTest(ServersSampleBase):"},{"line_number":1858,"context_line":"    extension_name \u003d (\"nova.api.openstack.compute.contrib.disk_config.\""},{"line_number":1859,"context_line":"                      \"Disk_config\")"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def test_list_servers_detail(self):"},{"line_number":1862,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1863,"context_line":"        response \u003d self._do_get(\u0027servers/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F66U%3D","line":1860,"updated":"2012-12-06 22:42:56.000000000","message":"I probably didn\u0027t make myself clear on that first review hehe... \nSo I would like to see the server create test, as you did there, but the request body should have some reference for your disk config instead of just create it automatically without specifying it. Like this:\n {\n    \"server\": {\n        \"name\": \"server-1\",\n        \"imageRef\": \"cedef40a-ed67-4d10-800e-17455edce175\",\n        \"flavorRef\" : \"1\",\n        \"OS_DCF:diskConfig\": \"MANUAL\"\n    }\n}","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"a24b08088433af1e70e3f34a3e38a27c8a541ddd","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"class DiskConfigJsonTest(ServersSampleBase):"},{"line_number":1858,"context_line":"    extension_name \u003d (\"nova.api.openstack.compute.contrib.disk_config.\""},{"line_number":1859,"context_line":"                      \"Disk_config\")"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def test_list_servers_detail(self):"},{"line_number":1862,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1863,"context_line":"        response \u003d self._do_get(\u0027servers/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F62Q%3D","line":1860,"in_reply_to":"AAAAMX%2F%2F620%3D","updated":"2012-12-07 00:00:22.000000000","message":"My mistake, you\u0027re right... I\u0027ll keep the -1 cause of those id to be replaced in the in tpl file","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"e0185545e35e7b3baedf43ca48a9212799c21bd5","unresolved":false,"context_lines":[{"line_number":1857,"context_line":"class DiskConfigJsonTest(ServersSampleBase):"},{"line_number":1858,"context_line":"    extension_name \u003d (\"nova.api.openstack.compute.contrib.disk_config.\""},{"line_number":1859,"context_line":"                      \"Disk_config\")"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def test_list_servers_detail(self):"},{"line_number":1862,"context_line":"        uuid \u003d self._post_server()"},{"line_number":1863,"context_line":"        response \u003d self._do_get(\u0027servers/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F620%3D","line":1860,"in_reply_to":"AAAAMX%2F%2F66U%3D","updated":"2012-12-06 23:47:24.000000000","message":"But I think it does. See: https://review.openstack.org/#/c/17298/4/nova/tests/integrated/api_samples/OS-DCF/server-post-req.json.tpl . It has specific data for the DiskConfig extension.","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e988158c537c5439a6f57c89ab410108e4191939","unresolved":false,"context_lines":[{"line_number":1894,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":1895,"context_line":"        # NOTE(tmello): Resize does not return response body"},{"line_number":1896,"context_line":"        # Bug #1085213."},{"line_number":1897,"context_line":"        self.assertEqual(response.read(), \"\")"},{"line_number":1898,"context_line":""},{"line_number":1899,"context_line":"    def test_rebuild_server(self):"},{"line_number":1900,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F7HU%3D","line":1897,"updated":"2012-12-06 20:20:36.000000000","message":"What happens when you just have a blank template file? If that works instead of checking for a blank response like you did here, then you\u0027ll just have to update the template file when the bug is fixed. Instead of also updating the test as you will with this approach.\n\nBut, if having the blank template file doesn\u0027t work then I think that this is fine.","commit_id":"33963fb6dc2c6586d6a09444a760b1b486a3d0aa"}]}