)]}'
{"nova/network/manager.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2748c5b6ef9aa60a2f3bd302313a06b1cc6ffae4","unresolved":false,"context_lines":[{"line_number":2083,"context_line":""},{"line_number":2084,"context_line":"        if not CONF.fake_network:"},{"line_number":2085,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":2086,"context_line":"            # NOTE(dprince): dhcp DB queries require admin context"},{"line_number":2087,"context_line":"            admin_context \u003d context.get_admin_context()"},{"line_number":2088,"context_line":"            self.driver.update_dhcp(admin_context, dev, network)"},{"line_number":2089,"context_line":"            if(CONF.use_ipv6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Fv4%3D","line":2086,"updated":"2012-12-03 08:31:43.000000000","message":"Contexts become useless when we create them inside inner methods. Or I misunderstood something?","commit_id":"0f9b1a30a029e9fa697c8bd98aff12e4058124d2"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"f19898f8e43ed1c63034c2f6d3ed586d20194541","unresolved":false,"context_lines":[{"line_number":2083,"context_line":""},{"line_number":2084,"context_line":"        if not CONF.fake_network:"},{"line_number":2085,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":2086,"context_line":"            # NOTE(dprince): dhcp DB queries require admin context"},{"line_number":2087,"context_line":"            admin_context \u003d context.get_admin_context()"},{"line_number":2088,"context_line":"            self.driver.update_dhcp(admin_context, dev, network)"},{"line_number":2089,"context_line":"            if(CONF.use_ipv6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2FfE%3D","line":2086,"in_reply_to":"AAAAMX%2F%2F%2Fho%3D","updated":"2012-12-03 15:01:45.000000000","message":"Dan: I think that we shouldn\u0027t relax admin context requirement in this method. We should create admin context in public (external) methods that call this private (internal) method. For example in allocate_fixed_ip:\n\nself._setup_network_on_host(context, network). \n\nI think that it is misleading because when I was reading this part of code I was pretty sure that _setup_network_on_host can be called with user_context.","commit_id":"0f9b1a30a029e9fa697c8bd98aff12e4058124d2"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"32a8b71da832a6faa3c35f767b7e8d20a44ef3ea","unresolved":false,"context_lines":[{"line_number":2083,"context_line":""},{"line_number":2084,"context_line":"        if not CONF.fake_network:"},{"line_number":2085,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":2086,"context_line":"            # NOTE(dprince): dhcp DB queries require admin context"},{"line_number":2087,"context_line":"            admin_context \u003d context.get_admin_context()"},{"line_number":2088,"context_line":"            self.driver.update_dhcp(admin_context, dev, network)"},{"line_number":2089,"context_line":"            if(CONF.use_ipv6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2Fho%3D","line":2086,"in_reply_to":"AAAAMX%2F%2F%2Fv4%3D","updated":"2012-12-03 14:17:42.000000000","message":"Boris: In general what you are saying is correct. Using admin context is something to be avoided if at all possible. In this case however we need the normal user context (which is now passed for resize_ actions) to be able to make the update_dhcp call which makes the associated db.network_get_associated_fixed_ips call.\n\nEssentially this fixes a regresssion in 14e2ed3... which means that users can no longer perform resize_confirm, revert operations.\n\nI suppose another option is to relax the admin context requirement on db.network_get_associated_fixed_ips but that seemed like a bad idea.\n\nSimply passing the admin context only to the update_dhcp function seemed like a reasonable solution to me.","commit_id":"0f9b1a30a029e9fa697c8bd98aff12e4058124d2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"90e59a72cdf83afc561aeb6356bb03696a25c394","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"        if not CONF.fake_network:"},{"line_number":2085,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":2086,"context_line":"            # NOTE(dprince): dhcp DB queries require admin context"},{"line_number":2087,"context_line":"            admin_context \u003d context.get_admin_context()"},{"line_number":2088,"context_line":"            self.driver.update_dhcp(admin_context, dev, network)"},{"line_number":2089,"context_line":"            if(CONF.use_ipv6):"},{"line_number":2090,"context_line":"                self.driver.update_ra(ctxt, dev, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2B%2BM%3D","line":2087,"updated":"2012-12-03 20:58:41.000000000","message":"admin_context \u003d ctxt.elevated()","commit_id":"0f9b1a30a029e9fa697c8bd98aff12e4058124d2"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"dff9775c6b97f3c5c02c533f1f0f9c096caabb94","unresolved":false,"context_lines":[{"line_number":2085,"context_line":"            dev \u003d self.driver.get_dev(network)"},{"line_number":2086,"context_line":"            # NOTE(dprince): dhcp DB queries require admin context"},{"line_number":2087,"context_line":"            admin_context \u003d context.get_admin_context()"},{"line_number":2088,"context_line":"            self.driver.update_dhcp(admin_context, dev, network)"},{"line_number":2089,"context_line":"            if(CONF.use_ipv6):"},{"line_number":2090,"context_line":"                self.driver.update_ra(ctxt, dev, network)"},{"line_number":2091,"context_line":"                gateway \u003d utils.get_my_linklocal(dev)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F%2B%2BA%3D","line":2088,"updated":"2012-12-03 21:02:09.000000000","message":"I feel like we should pass the regular context to the driver.  If the driver implementation somehow needs admin context, it can elevate there.  Not all drivers may need to do this..","commit_id":"0f9b1a30a029e9fa697c8bd98aff12e4058124d2"}]}