)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"689d8a0d7e038fc3cae93d33e3902dc88c41aa7e","unresolved":false,"context_lines":[{"line_number":5816,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":5817,"context_line":"            block_device_info)"},{"line_number":5818,"context_line":""},{"line_number":5819,"context_line":"        if len(block_device_mapping):"},{"line_number":5820,"context_line":"            LOG.debug(\u0027Connecting volumes before live migration.\u0027,"},{"line_number":5821,"context_line":"                      instance\u003dinstance)"},{"line_number":5822,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_edec232b","line":5819,"updated":"2015-04-14 11:58:30.000000000","message":"why not just have a debug log in the for loop below. that is far more informative and you can also provide the connection info","commit_id":"f25fbd6c15ba4f2a82f7cec112c2f10995dcc741"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1fafcabefd1e6b66ff487e8953a4d0f040633073","unresolved":false,"context_lines":[{"line_number":5816,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":5817,"context_line":"            block_device_info)"},{"line_number":5818,"context_line":""},{"line_number":5819,"context_line":"        if len(block_device_mapping):"},{"line_number":5820,"context_line":"            LOG.debug(\u0027Connecting volumes before live migration.\u0027,"},{"line_number":5821,"context_line":"                      instance\u003dinstance)"},{"line_number":5822,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_5e085f2d","line":5819,"in_reply_to":"7aaa499b_edec232b","updated":"2015-04-14 13:18:18.000000000","message":"Because I believe the connection info has userid/password credentials in it which I didn\u0027t want to log.","commit_id":"f25fbd6c15ba4f2a82f7cec112c2f10995dcc741"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"689d8a0d7e038fc3cae93d33e3902dc88c41aa7e","unresolved":false,"context_lines":[{"line_number":5842,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":5843,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":5844,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":5845,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":5846,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":5847,"context_line":"        for cnt in range(max_retry):"},{"line_number":5848,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_0dd18f57","line":5845,"updated":"2015-04-14 11:58:30.000000000","message":"consider moving this to line 5849 and you can have the count logged too","commit_id":"f25fbd6c15ba4f2a82f7cec112c2f10995dcc741"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1fafcabefd1e6b66ff487e8953a4d0f040633073","unresolved":false,"context_lines":[{"line_number":5842,"context_line":"        # ensure_filtering_rules_for_instance, to ensure bridge is set up"},{"line_number":5843,"context_line":"        # Retry operation is necessary because continuously request comes,"},{"line_number":5844,"context_line":"        # concurrent request occurs to iptables, then it complains."},{"line_number":5845,"context_line":"        LOG.debug(\u0027Plugging VIFs before live migration.\u0027, instance\u003dinstance)"},{"line_number":5846,"context_line":"        max_retry \u003d CONF.live_migration_retry_count"},{"line_number":5847,"context_line":"        for cnt in range(max_retry):"},{"line_number":5848,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_f9ff45ff","line":5845,"in_reply_to":"7aaa499b_0dd18f57","updated":"2015-04-14 13:18:18.000000000","message":"That\u0027s already logged in the warning.","commit_id":"f25fbd6c15ba4f2a82f7cec112c2f10995dcc741"}]}