)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c689395ba64387a53b898087987796d93f7944e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-22 15:53:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evaucate failed do to recreate not support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab921fb_705082d4","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":37},"updated":"2015-04-26 06:51:35.000000000","message":"evaucate \u003d\u003e evacuate\ndo \u003d\u003e due\nsupport \u003d\u003e supported","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"232cb45c6d332ea2266f00e41972d69fd7de583d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-22 15:53:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evaucate failed do to recreate not support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab921fb_5646934f","line":7,"in_reply_to":"bab921fb_705082d4","updated":"2015-04-27 00:47:17.000000000","message":"Done","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"4edfc78d149f27a1949d2daab952ac33c53ddfe1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-27 08:39:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evaucate do failed due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5ad0253b_17820f53","line":7,"updated":"2015-04-28 19:48:57.000000000","message":"typo: evaucate -\u003e evacuate\n\nnit: evacuate do failed -\u003e evaluate fails","commit_id":"52e17515040f2189039cb9148497c80bbf20b2b1"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"b2102aa9f620e2231658c9d92ed6651db48a100a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-27 08:39:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evaucate do failed due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5ad0253b_a25f7b0d","line":7,"in_reply_to":"5ad0253b_17820f53","updated":"2015-04-29 12:51:30.000000000","message":"thanks Joel.\nI believe it should be evacuate do failed -\u003e evacuate fails.\n\nhaha ... it\u0027s so difficult a word to remember.","commit_id":"52e17515040f2189039cb9148497c80bbf20b2b1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"07660a5ed2e931bd328fac1a5cee22d42d8e83bc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evacuate fails due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"},{"line_number":11,"context_line":"and power_state to None"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_f730ba09","line":9,"updated":"2015-04-29 15:08:14.000000000","message":"will resize lead to InstanceRecreateNotSupported?","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ad128678891d2a8cefa70854459eb55f90baac85","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set power state to None when evacuate fails due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/resize, the power_state"},{"line_number":10,"context_line":"is still running, we need to set back vm_state to ERROR, task_state to None"},{"line_number":11,"context_line":"and power_state to None"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_f5b72ed6","line":9,"in_reply_to":"3acd31a7_f730ba09","updated":"2015-05-04 02:17:39.000000000","message":"no, it won\u0027t lead, I will remove resize.","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"c7351262076b47fc496e0cd60bc3124b83e35c82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-08 13:52:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set correct power state when evaucate do failed due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/rebuild, vm_state is set to"},{"line_number":10,"context_line":"ERROR, but we still need to set correct power_state, which should be from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_fdddb7e0","line":7,"updated":"2015-05-08 21:26:18.000000000","message":"nit: evaucate do failed -\u003e evacuate fails","commit_id":"473cd638d0e6dbda7ac2fd368e12c3623448fda3"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a0569eb8b47680bf7ab3d2d009cccbc583469600","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-08 13:52:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set correct power state when evaucate do failed due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/rebuild, vm_state is set to"},{"line_number":10,"context_line":"ERROR, but we still need to set correct power_state, which should be from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9af37de9_ee67ba23","line":7,"in_reply_to":"1aca2d91_fdddb7e0","updated":"2015-05-11 01:45:15.000000000","message":"Done","commit_id":"473cd638d0e6dbda7ac2fd368e12c3623448fda3"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"cba7cb53a61bb5babe53df5e53e301ebabdd4791","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eli Qiao \u003cliyong.qiao@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-11 09:42:42 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set correct power state when evaucate fails due to recreate not supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we get InstanceRecreateNotSupported in evacuate/rebuild, vm_state is set to"},{"line_number":10,"context_line":"ERROR, but we still need to set correct power_state, which should be from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9af37de9_8dbb860e","line":7,"updated":"2015-05-11 13:07:41.000000000","message":"typo: whoops! missed the spelling correction for *evacuate*","commit_id":"09404f202fda2a84b2f615f2998d85e8a77c539c"}],"nova/compute/manager.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"201c7a59dd25a891fd9cf1d2051357d4f4892d04","unresolved":false,"context_lines":[{"line_number":6379,"context_line":"            raise error.inner_exception"},{"line_number":6380,"context_line":""},{"line_number":6381,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6382,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR, power_state\u0027"},{"line_number":6383,"context_line":"                              \u0027 to None after %(error)s\u0027),"},{"line_number":6384,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6385,"context_line":"                          instance_uuid\u003dinstance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_a49319fa","line":6382,"updated":"2015-04-20 13:05:37.000000000","message":"very tiny nit: if you respin, please change this so that the space between the two strings is at the end of the the first line, and not at the beginning of the second. See L6364-5 for what I mean.","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"195b691e5ff602fdbf60c688744c70b4aad079b9","unresolved":false,"context_lines":[{"line_number":6379,"context_line":"            raise error.inner_exception"},{"line_number":6380,"context_line":""},{"line_number":6381,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6382,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR, power_state\u0027"},{"line_number":6383,"context_line":"                              \u0027 to None after %(error)s\u0027),"},{"line_number":6384,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6385,"context_line":"                          instance_uuid\u003dinstance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_e2ee85eb","line":6382,"in_reply_to":"dac4157f_a49319fa","updated":"2015-04-21 02:02:41.000000000","message":"sure, I hope that, but it will exceed 80 if I put it at the end of first line, any way I will adjust the words as your suggestion .\nthanks :)\n-Eli","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dca44026080b0cbe1a2e4d5b0350c8a7ddfcb305","unresolved":false,"context_lines":[{"line_number":6385,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":6386,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":6387,"context_line":"                if quotas:"},{"line_number":6388,"context_line":"                    quotas.rollback()"},{"line_number":6389,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6390,"context_line":"                                               task_state\u003dNone,"},{"line_number":6391,"context_line":"                                               power_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_5f73cf15","line":6388,"updated":"2015-04-14 02:43:26.000000000","message":"should we need a check of power_state by \"self._get_power_state(context, instance)\" here ?","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"195b691e5ff602fdbf60c688744c70b4aad079b9","unresolved":false,"context_lines":[{"line_number":6385,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":6386,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":6387,"context_line":"                if quotas:"},{"line_number":6388,"context_line":"                    quotas.rollback()"},{"line_number":6389,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6390,"context_line":"                                               task_state\u003dNone,"},{"line_number":6391,"context_line":"                                               power_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_c25ee1e8","line":6388,"in_reply_to":"7aaa499b_5f73cf15","updated":"2015-04-21 02:02:41.000000000","message":"hi liusheng,\nin this situation, i am not quite sure, actually , we don\u0027t need this patch if we want to get power_state again since the power state is correct.\n\nas you can see from this bug description, it\u0027s vm_state is error but power_state is running.","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c689395ba64387a53b898087987796d93f7944e5","unresolved":false,"context_lines":[{"line_number":6390,"context_line":"            raise error.inner_exception"},{"line_number":6391,"context_line":""},{"line_number":6392,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6393,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6394,"context_line":"                              \u0027power_state to None after %(error)s\u0027),"},{"line_number":6395,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6396,"context_line":"                          instance_uuid\u003dinstance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_d04d0e3f","line":6393,"updated":"2015-04-26 06:51:35.000000000","message":"why do we need the exception trace here. A specific exception is raised. Can we have a LOG.error or LOG.warning?","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"232cb45c6d332ea2266f00e41972d69fd7de583d","unresolved":false,"context_lines":[{"line_number":6390,"context_line":"            raise error.inner_exception"},{"line_number":6391,"context_line":""},{"line_number":6392,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6393,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6394,"context_line":"                              \u0027power_state to None after %(error)s\u0027),"},{"line_number":6395,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6396,"context_line":"                          instance_uuid\u003dinstance_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_9612eb55","line":6393,"in_reply_to":"bab921fb_d04d0e3f","updated":"2015-04-27 00:47:17.000000000","message":"Done","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c689395ba64387a53b898087987796d93f7944e5","unresolved":false,"context_lines":[{"line_number":6392,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6393,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6394,"context_line":"                              \u0027power_state to None after %(error)s\u0027),"},{"line_number":6395,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6396,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":6397,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":6398,"context_line":"                if quotas:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_b04a9a24","line":6395,"updated":"2015-04-26 06:51:35.000000000","message":"minor not - when there is one parameter we do not need a dictionary","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"232cb45c6d332ea2266f00e41972d69fd7de583d","unresolved":false,"context_lines":[{"line_number":6392,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6393,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6394,"context_line":"                              \u0027power_state to None after %(error)s\u0027),"},{"line_number":6395,"context_line":"                          {\u0027error\u0027: error},"},{"line_number":6396,"context_line":"                          instance_uuid\u003dinstance_uuid)"},{"line_number":6397,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":6398,"context_line":"                if quotas:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_761bd773","line":6395,"in_reply_to":"bab921fb_b04a9a24","updated":"2015-04-27 00:47:17.000000000","message":"Done","commit_id":"1f13a8222e98d5945afb589df3b23765b57362fa"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"07660a5ed2e931bd328fac1a5cee22d42d8e83bc","unresolved":false,"context_lines":[{"line_number":6431,"context_line":"                if quotas:"},{"line_number":6432,"context_line":"                    quotas.rollback()"},{"line_number":6433,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6434,"context_line":"                                               task_state\u003dNone,"},{"line_number":6435,"context_line":"                                               power_state\u003dNone)"},{"line_number":6436,"context_line":""},{"line_number":6437,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_97d506bb","line":6434,"updated":"2015-04-29 15:08:14.000000000","message":"I think you handling rebuild_instance function\nthen why we need set task_state \u003d None, after all\nwe have reverts_task_state to reset task state?\n\nif it doesn\u0027t work , we should find why it didn\u0027t work","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d743ac6a18dc79ce8043593fb83f799bf739f32d","unresolved":false,"context_lines":[{"line_number":6431,"context_line":"                if quotas:"},{"line_number":6432,"context_line":"                    quotas.rollback()"},{"line_number":6433,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6434,"context_line":"                                               task_state\u003dNone,"},{"line_number":6435,"context_line":"                                               power_state\u003dNone)"},{"line_number":6436,"context_line":""},{"line_number":6437,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_58c52b8c","line":6434,"in_reply_to":"3acd31a7_97d506bb","updated":"2015-05-07 02:46:40.000000000","message":"hi jichenjc, the task_stack can be reverted by reverts_task_state.\nthanks, you are right.","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ad128678891d2a8cefa70854459eb55f90baac85","unresolved":false,"context_lines":[{"line_number":6431,"context_line":"                if quotas:"},{"line_number":6432,"context_line":"                    quotas.rollback()"},{"line_number":6433,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6434,"context_line":"                                               task_state\u003dNone,"},{"line_number":6435,"context_line":"                                               power_state\u003dNone)"},{"line_number":6436,"context_line":""},{"line_number":6437,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_b5b1b6e3","line":6434,"in_reply_to":"3acd31a7_97d506bb","updated":"2015-05-04 02:17:39.000000000","message":"sorry, I don\u0027t think I get what your mean, can you please detail more?","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"07660a5ed2e931bd328fac1a5cee22d42d8e83bc","unresolved":false,"context_lines":[{"line_number":6432,"context_line":"                    quotas.rollback()"},{"line_number":6433,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6434,"context_line":"                                               task_state\u003dNone,"},{"line_number":6435,"context_line":"                                               power_state\u003dNone)"},{"line_number":6436,"context_line":""},{"line_number":6437,"context_line":"        except Exception:"},{"line_number":6438,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_68c16b80","line":6435,"updated":"2015-04-29 15:08:14.000000000","message":"the power_state should not be changed ?","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ad128678891d2a8cefa70854459eb55f90baac85","unresolved":false,"context_lines":[{"line_number":6432,"context_line":"                    quotas.rollback()"},{"line_number":6433,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6434,"context_line":"                                               task_state\u003dNone,"},{"line_number":6435,"context_line":"                                               power_state\u003dNone)"},{"line_number":6436,"context_line":""},{"line_number":6437,"context_line":"        except Exception:"},{"line_number":6438,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_35afe682","line":6435,"in_reply_to":"3acd31a7_68c16b80","updated":"2015-05-04 02:17:39.000000000","message":"can you please check the origin bug report for why I set it back to None?","commit_id":"c6c274816af0b7f6e6685fa195c4aa3d934f2131"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"c7351262076b47fc496e0cd60bc3124b83e35c82","unresolved":false,"context_lines":[{"line_number":6458,"context_line":""},{"line_number":6459,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6460,"context_line":"            LOG.warning(_LW(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6461,"context_line":"                            \u0027power_state to None after %s\u0027),"},{"line_number":6462,"context_line":"                        error, instance_uuid\u003dinstance_uuid)"},{"line_number":6463,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":6464,"context_line":"                if quotas:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_bd917ff3","line":6461,"updated":"2015-05-08 21:26:18.000000000","message":"Please update message with the correct power_state from self._get_power_state (in with block below).","commit_id":"473cd638d0e6dbda7ac2fd368e12c3623448fda3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0bf5ecafa9f4afd42ddc9ae27bb58750eb704bb6","unresolved":false,"context_lines":[{"line_number":751,"context_line":"                      \u0027trying to set it to ERROR\u0027,"},{"line_number":752,"context_line":"                      instance_uuid\u003dinstance_uuid)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    def _set_instance_obj_error_state(self, context, instance):"},{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":757,"context_line":"            instance.save()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_f640a409","line":754,"updated":"2015-05-11 12:07:41.000000000","message":"this function","commit_id":"09404f202fda2a84b2f615f2998d85e8a77c539c"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"cba7cb53a61bb5babe53df5e53e301ebabdd4791","unresolved":false,"context_lines":[{"line_number":6464,"context_line":"            raise error.inner_exception"},{"line_number":6465,"context_line":""},{"line_number":6466,"context_line":"        except exception.InstanceRecreateNotSupported as error:"},{"line_number":6467,"context_line":"            power_stat \u003d self._get_power_state(context, instance)"},{"line_number":6468,"context_line":"            LOG.warning(_LW(\u0027Setting instance vm_state to ERROR,\u0027"},{"line_number":6469,"context_line":"                            \u0027power_state to %(power_state)s after %(error)s\u0027),"},{"line_number":6470,"context_line":"                        {\u0027power_state\u0027: power_stat, \u0027error\u0027: error},"}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_4d0a3ed4","line":6467,"updated":"2015-05-11 13:07:41.000000000","message":"nit: power_stat -\u003e power_state","commit_id":"09404f202fda2a84b2f615f2998d85e8a77c539c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0bf5ecafa9f4afd42ddc9ae27bb58750eb704bb6","unresolved":false,"context_lines":[{"line_number":6473,"context_line":"                if quotas:"},{"line_number":6474,"context_line":"                    quotas.rollback()"},{"line_number":6475,"context_line":"                self._set_instance_error_state(context, instance,"},{"line_number":6476,"context_line":"                                               power_state\u003dpower_stat)"},{"line_number":6477,"context_line":""},{"line_number":6478,"context_line":"        except Exception:"},{"line_number":6479,"context_line":"            LOG.exception(_LE(\u0027Setting instance vm_state to ERROR\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_96f6f8d5","line":6476,"updated":"2015-05-11 12:07:41.000000000","message":"can we use the function above? \nseems it\u0027s more common to use instance.save directly? \nso we can write like \n\ninstance.power_state \u003d self._get_power_state(context, instance)\n(actually I am not sure whether this is needed)\nself._set_instance_obj_error_state(context, instance) \n\n\nand I submit a patch on this to change the usage of \nthis ..","commit_id":"09404f202fda2a84b2f615f2998d85e8a77c539c"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"201c7a59dd25a891fd9cf1d2051357d4f4892d04","unresolved":false,"context_lines":[{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._instance_update\u0027)"},{"line_number":2122,"context_line":"    def test_error_out_instance_on_exception_inst_recreate_not_supported(self,"},{"line_number":2123,"context_line":"        inst_update_mock):"},{"line_number":2124,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":"        def do_test():"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_c45bad53","line":2123,"updated":"2015-04-20 13:05:37.000000000","message":"This line needs to either:\na) be indented to line up with the \u0027self\u0027 of the previous line, or\nb) indented two levels (i.e., 8 spaces)\n\nThe current indentation makes this look as though the second line of the method is part of the method body, and not part of the signature line.","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"195b691e5ff602fdbf60c688744c70b4aad079b9","unresolved":false,"context_lines":[{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._instance_update\u0027)"},{"line_number":2122,"context_line":"    def test_error_out_instance_on_exception_inst_recreate_not_supported(self,"},{"line_number":2123,"context_line":"        inst_update_mock):"},{"line_number":2124,"context_line":"        instance \u003d fake_instance.fake_instance_obj(self.context)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":"        def do_test():"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_e2c5655b","line":2123,"in_reply_to":"dac4157f_c45bad53","updated":"2015-04-21 02:02:41.000000000","message":"hi Ed, good catch, I will update it.\n\nthanks for reviewing.\n-Eli.","commit_id":"8c918d51ff365dd03136415c231e4ab65e77fba4"}]}