)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ad1a4cfac82e83dcf275700215f4c5d754a46fcf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Neutron supports port_security_enabled\u003dFalse feature which means that no"},{"line_number":10,"context_line":"security group is enabled for an instance port. But Nova automatically"},{"line_number":11,"context_line":"adds \u0027default\u0027 security group even if no group is specified in a"},{"line_number":12,"context_line":"request. It leads to difficulties in the use of the featrue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves default initialization of an instance security groups"},{"line_number":15,"context_line":"to nova-network only related code. This gives a chance to Neutron to set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_b86e5e94","line":12,"updated":"2015-05-15 15:25:18.000000000","message":"featrue \u003d\u003e feature","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"1602bccbd841984fd05db111ae6c90e338be1ebc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Neutron supports port_security_enabled\u003dFalse feature which means that no"},{"line_number":10,"context_line":"security group is enabled for an instance port. But Nova automatically"},{"line_number":11,"context_line":"adds \u0027default\u0027 security group even if no group is specified in a"},{"line_number":12,"context_line":"request. It leads to difficulties in the use of the featrue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves default initialization of an instance security groups"},{"line_number":15,"context_line":"to nova-network only related code. This gives a chance to Neutron to set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_6a9fbab4","line":12,"in_reply_to":"7a016987_b86e5e94","updated":"2015-05-18 17:41:41.000000000","message":"Done","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ad1a4cfac82e83dcf275700215f4c5d754a46fcf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"operation, if no group is specified in a request."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1175464"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_d8fa3abd","line":22,"updated":"2015-05-15 15:25:18.000000000","message":"This requires a DocImpact - this changes the current default behavior","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"1602bccbd841984fd05db111ae6c90e338be1ebc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"operation, if no group is specified in a request."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1175464"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_3db7ce87","line":22,"in_reply_to":"7a016987_d8fa3abd","updated":"2015-05-18 17:41:41.000000000","message":"I rolled back the change which could be a formal reason of this tag.","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5cced0b671216f080b11e0bc406b6b8a478a3c56","unresolved":false,"context_lines":[{"line_number":17,"context_line":"specified in a request for create instance, that feature cannot be used."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch moves default initialization of an instance security groups"},{"line_number":20,"context_line":"to nova-network only related code. This gives a chance to expirenced"},{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_13b35f4e","line":20,"range":{"start_line":20,"start_character":58,"end_line":20,"end_character":68},"updated":"2015-09-06 09:39:52.000000000","message":"expirenced \u003d\u003e experienced","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"d893abf9d16d2bc3261ba67a412041114e97f234","unresolved":false,"context_lines":[{"line_number":17,"context_line":"specified in a request for create instance, that feature cannot be used."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch moves default initialization of an instance security groups"},{"line_number":20,"context_line":"to nova-network only related code. This gives a chance to expirenced"},{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_ac253b5d","line":20,"in_reply_to":"da20952f_13b35f4e","updated":"2015-09-12 08:11:54.000000000","message":"Done","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5cced0b671216f080b11e0bc406b6b8a478a3c56","unresolved":false,"context_lines":[{"line_number":20,"context_line":"to nova-network only related code. This gives a chance to expirenced"},{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_b384f35d","line":23,"updated":"2015-09-06 09:39:52.000000000","message":"secrurity \u003d\u003e security","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"d893abf9d16d2bc3261ba67a412041114e97f234","unresolved":false,"context_lines":[{"line_number":20,"context_line":"to nova-network only related code. This gives a chance to expirenced"},{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_cc2aef2c","line":23,"in_reply_to":"da20952f_b384f35d","updated":"2015-09-12 08:11:54.000000000","message":"Done","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"905c2e1e426b68f361ae9e1a3fd93b69c2186b2e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_2ec65f68","line":24,"updated":"2015-08-30 05:15:17.000000000","message":"I think that we should have UpgradeImpact flag here. Otherwise the code is good","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2bcbf1954a514d826e62c552166654f1ca20a7d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_8e01ab3a","line":24,"in_reply_to":"da20952f_2ec65f68","updated":"2015-08-30 05:54:41.000000000","message":"@garyk, but why we need it? Default behavior is not changed. A cloud admin doesn\u0027t have to do something to enable this feature. And Nova doesn\u0027t have correspoinding config settings. What upgrade procedure do you mean?\n\nDoes your comment mean that my last atempt to write a clear commit message failed?","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5cced0b671216f080b11e0bc406b6b8a478a3c56","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 secrurity group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_737adb78","line":24,"in_reply_to":"da20952f_8e01ab3a","updated":"2015-09-06 09:39:52.000000000","message":"No, your explanation is fine","commit_id":"32fe5dbf138c31c2b34dfd4613c9d066f0b3e4df"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fdd4fee08d6cb76a0c840102bf972b0e60d3c733","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not specify default security group to Neutron by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron supports port_security_enabled\u003dFalse feature which means that"},{"line_number":10,"context_line":"security groups are unavailable for ports of a network. It is a user"},{"line_number":11,"context_line":"defined setting for a user created network. It is True by default which"},{"line_number":12,"context_line":"means that security groups are available, and Neutron sets \u0027default\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_fce6b642","line":9,"updated":"2015-09-17 17:14:43.000000000","message":"How are people getting around the nova bug here today if they have port_security_enabled\u003dFalse?  Do they create the port separately in neutron and then provide that on the server-create request to nova?","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2cf653a02597c75f8328f963b659efd076ba21da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not specify default security group to Neutron by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron supports port_security_enabled\u003dFalse feature which means that"},{"line_number":10,"context_line":"security groups are unavailable for ports of a network. It is a user"},{"line_number":11,"context_line":"defined setting for a user created network. It is True by default which"},{"line_number":12,"context_line":"means that security groups are available, and Neutron sets \u0027default\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_5bb64cdd","line":9,"in_reply_to":"ba15a1d1_77782ef9","updated":"2015-09-22 03:13:25.000000000","message":"Hmm, they try, but Nova fails in this case as well: https://bugs.launchpad.net/nova/+bug/1460630","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"c1fb44c5282a6b2ce6833891c60591c124df5c5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not specify default security group to Neutron by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron supports port_security_enabled\u003dFalse feature which means that"},{"line_number":10,"context_line":"security groups are unavailable for ports of a network. It is a user"},{"line_number":11,"context_line":"defined setting for a user created network. It is True by default which"},{"line_number":12,"context_line":"means that security groups are available, and Neutron sets \u0027default\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_77782ef9","line":9,"in_reply_to":"ba15a1d1_fce6b642","updated":"2015-09-21 11:59:33.000000000","message":"Yes, they do. E.g.see http://blog.otherwiseguy.com/trying-out-the-ml2-port-security-extension/#launchingavmusingtheportsecuritydisabledport","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d208e6c6beb3c06e8f481fba27b61863ac27c429","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 security group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_06bebbfe","line":24,"updated":"2015-09-17 16:40:23.000000000","message":"We should probably at least have a DocImpact in here as a reminder that we should add a note to the liberty release notes about this change.  For better or worse, this is the behavior of the API today, so regardless of how experienced the users are, it\u0027s technically an API change.  If we weren\u0027t going to do a microversion for this, we should at least be advertising that the behavior is going to change and we\u0027d start with the release notes.\n\nThat goes back to what garyk was saying about UpgradeImpact tagging.","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"cce172b0a28977ac3914ba2e22a635b8e5e8eb61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 security group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_ccce2483","line":24,"in_reply_to":"ba15a1d1_06bebbfe","updated":"2015-09-22 06:02:52.000000000","message":"Done","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"c1fb44c5282a6b2ce6833891c60591c124df5c5a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"users to use port_security_enabled\u003dFalse feature. But it does not affect"},{"line_number":22,"context_line":"regular users, which do not use this feature, and do not specify"},{"line_number":23,"context_line":"\u0027default\u0027 security group."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #1175464"},{"line_number":26,"context_line":"Change-Id: I043901491f60ea76dfbae879ce6e56acbd12f30c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba15a1d1_da54c122","line":24,"in_reply_to":"ba15a1d1_06bebbfe","updated":"2015-09-21 11:59:33.000000000","message":"Well, ok. If so many people want this, i\u0027ll do it. But frankly i think this is just a bug fix. See http://lists.openstack.org/pipermail/openstack-dev/2015-July/069703.html","commit_id":"abe1b19b71ed595b10043c7e4fe80eb4cc8b7bb7"}],"nova/compute/api.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"29260c05c47786996e42861ec2e9ff2958d1e495","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        the project."},{"line_number":497,"context_line":"        \"\"\""},{"line_number":498,"context_line":"        for secgroup in secgroups:"},{"line_number":499,"context_line":"            # NOTE(sdague): default is handled special"},{"line_number":500,"context_line":"            if secgroup \u003d\u003d \"default\":"},{"line_number":501,"context_line":"                continue"},{"line_number":502,"context_line":"            if not self.security_group_api.get(context, secgroup):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d4f3a171","line":499,"updated":"2015-06-01 03:45:27.000000000","message":"need changes here?","commit_id":"b4b1d002be148d9147ae55339af5d256850f5ee7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"62a3fe696d17b4a8009d809b18eb89fbc65b8832","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        the project."},{"line_number":497,"context_line":"        \"\"\""},{"line_number":498,"context_line":"        for secgroup in secgroups:"},{"line_number":499,"context_line":"            # NOTE(sdague): default is handled special"},{"line_number":500,"context_line":"            if secgroup \u003d\u003d \"default\":"},{"line_number":501,"context_line":"                continue"},{"line_number":502,"context_line":"            if not self.security_group_api.get(context, secgroup):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ef012606","line":499,"in_reply_to":"7a016987_d4f3a171","updated":"2015-06-01 04:03:45.000000000","message":"i don\u0027t think so. this method checks specified group names, but the default group could be specified as well. e.g. if the user wants to set two groups for his instance, the default and a custom one","commit_id":"b4b1d002be148d9147ae55339af5d256850f5ee7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9765e034da0f8dcd671b1120b1addb564a1c5a3f","unresolved":false,"context_lines":[{"line_number":4148,"context_line":""},{"line_number":4149,"context_line":"    def populate_security_groups(self, instance, security_groups):"},{"line_number":4150,"context_line":"        if not security_groups:"},{"line_number":4151,"context_line":"            # Set default security group"},{"line_number":4152,"context_line":"            security_groups \u003d [\u0027default\u0027]"},{"line_number":4153,"context_line":"        instance.security_groups \u003d security_group_obj.make_secgroup_list("},{"line_number":4154,"context_line":"            security_groups)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_81262dcc","line":4151,"updated":"2015-05-29 14:30:52.000000000","message":"As you said,the sg\u0027s default value should be empty .Why should this be \u0027default\u0027?","commit_id":"b4b1d002be148d9147ae55339af5d256850f5ee7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ff9a0f95c423d456292bf5f8a34b20e094c77b8a","unresolved":false,"context_lines":[{"line_number":4148,"context_line":""},{"line_number":4149,"context_line":"    def populate_security_groups(self, instance, security_groups):"},{"line_number":4150,"context_line":"        if not security_groups:"},{"line_number":4151,"context_line":"            # Set default security group"},{"line_number":4152,"context_line":"            security_groups \u003d [\u0027default\u0027]"},{"line_number":4153,"context_line":"        instance.security_groups \u003d security_group_obj.make_secgroup_list("},{"line_number":4154,"context_line":"            security_groups)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_88a75e4f","line":4151,"in_reply_to":"7a016987_37a7bb51","updated":"2015-05-30 00:09:53.000000000","message":"Thanks","commit_id":"b4b1d002be148d9147ae55339af5d256850f5ee7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"4f247dc1a6ffcb154fba329c9380f46a49b91076","unresolved":false,"context_lines":[{"line_number":4148,"context_line":""},{"line_number":4149,"context_line":"    def populate_security_groups(self, instance, security_groups):"},{"line_number":4150,"context_line":"        if not security_groups:"},{"line_number":4151,"context_line":"            # Set default security group"},{"line_number":4152,"context_line":"            security_groups \u003d [\u0027default\u0027]"},{"line_number":4153,"context_line":"        instance.security_groups \u003d security_group_obj.make_secgroup_list("},{"line_number":4154,"context_line":"            security_groups)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_37a7bb51","line":4151,"in_reply_to":"7a016987_81262dcc","updated":"2015-05-29 15:21:44.000000000","message":"This is nova-network related code. We must still set the default group for nova-network.\n\nThis function is a part of nova-network related implementation (SecurityGroupApi) of SecurityGroupBase abstract class (nova.network.security_group.security_group_base). Neutron driver has its own implementation (nova.network.security_group.neutron_driver.SecurityGroupApi).","commit_id":"b4b1d002be148d9147ae55339af5d256850f5ee7"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7f35f175a9a196a593ddb854dedaea53cdb248e4","unresolved":false,"context_lines":[{"line_number":7562,"context_line":"        self.assertEqual(task_states.SCHEDULING, instance[\u0027task_state\u0027])"},{"line_number":7563,"context_line":"        self.assertEqual(1, instance[\u0027launch_index\u0027])"},{"line_number":7564,"context_line":"        self.assertIsNotNone(instance.get(\u0027uuid\u0027))"},{"line_number":7565,"context_line":"        self.assertIs(list, type(instance.security_groups.objects))"},{"line_number":7566,"context_line":"        self.assertEqual(1, len(instance.security_groups.objects))"},{"line_number":7567,"context_line":"        self.assertEqual(\u0027default\u0027, instance.security_groups.objects[0].name)"},{"line_number":7568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_af7dccb2","line":7565,"updated":"2015-04-15 08:31:37.000000000","message":"wondering if this assert is really needed","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"1602bccbd841984fd05db111ae6c90e338be1ebc","unresolved":false,"context_lines":[{"line_number":7562,"context_line":"        self.assertEqual(task_states.SCHEDULING, instance[\u0027task_state\u0027])"},{"line_number":7563,"context_line":"        self.assertEqual(1, instance[\u0027launch_index\u0027])"},{"line_number":7564,"context_line":"        self.assertIsNotNone(instance.get(\u0027uuid\u0027))"},{"line_number":7565,"context_line":"        self.assertIs(list, type(instance.security_groups.objects))"},{"line_number":7566,"context_line":"        self.assertEqual(1, len(instance.security_groups.objects))"},{"line_number":7567,"context_line":"        self.assertEqual(\u0027default\u0027, instance.security_groups.objects[0].name)"},{"line_number":7568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_eaabaad4","line":7565,"in_reply_to":"7a016987_5aad6530","updated":"2015-05-18 17:41:41.000000000","message":"Done","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0f11b5d5312801b4d52484851fa5574136dc347f","unresolved":false,"context_lines":[{"line_number":7562,"context_line":"        self.assertEqual(task_states.SCHEDULING, instance[\u0027task_state\u0027])"},{"line_number":7563,"context_line":"        self.assertEqual(1, instance[\u0027launch_index\u0027])"},{"line_number":7564,"context_line":"        self.assertIsNotNone(instance.get(\u0027uuid\u0027))"},{"line_number":7565,"context_line":"        self.assertIs(list, type(instance.security_groups.objects))"},{"line_number":7566,"context_line":"        self.assertEqual(1, len(instance.security_groups.objects))"},{"line_number":7567,"context_line":"        self.assertEqual(\u0027default\u0027, instance.security_groups.objects[0].name)"},{"line_number":7568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5aad6530","line":7565,"in_reply_to":"7aaa499b_af7dccb2","updated":"2015-05-14 02:31:55.000000000","message":"I\u0027m guessing it\u0027s being done because the old assert compared to [] which verifies both the length and the type implicitly. That said, I don\u0027t think it\u0027s really needed.\n\nAlso, the usual way to assert type is:\n\n self.assertIsInstance(instance.security_groups.objects, list)","commit_id":"1459c625920c27163eeff84e79d52501b5bfa043"}]}