)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b1cdd5aaac6a05c389a6949c2b8fc635c0541e88","unresolved":false,"context_lines":[{"line_number":14,"context_line":"as bug #1407643."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Icbe698b30afe43cfcdd122c775b59af5a50a8741"},{"line_number":17,"context_line":"Closes-bug: #1407643"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_de36c3b3","line":17,"updated":"2015-09-02 23:23:46.000000000","message":"In the bug, the problem is that the user specified values exceeding the max allowed by libvirt, for example. So I think we shouldn\u0027t have Closes-Bug in this patch (it doesn\u0027t fix the problem described in the bug). You can put \"Related-Bug\" instead to have this patch linked to the issue without having it switch the bug to \"Fix Committed\"","commit_id":"dbceba8927c78ad71330e97cf803fa88c6219ee7"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":16839,"name":"Cale Rath","email":"ctrath@us.ibm.com","username":"ctrath"},"change_message_id":"0d6545eb24cb43a587523c654ebf3012f45b5469","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"        obj.vif_outbound_peak \u003d 65536"},{"line_number":1177,"context_line":"        obj.vif_outbound_burst \u003d 6553"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":1180,"context_line":"        self.assertXmlEqual(xml, \"\"\""},{"line_number":1181,"context_line":"            \u003cinterface type\u003d\"ethernet\"\u003e"},{"line_number":1182,"context_line":"              \u003cmac address\u003d\"DE:AD:BE:EF:CA:FE\"/\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_ba7f09de","line":1179,"updated":"2015-09-04 15:24:37.000000000","message":"shouldn\u0027t we be checking for these limits in the to_xml() method and throw an exception if the condition is not met?  It seems to me, at minimum, that we should at least log that the set value is not in range.","commit_id":"7882551b3b76fb8b99441f32bb8652e9f1bad1ea"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f9b8aaac39849f4a1f550280874c4ffca857a4bd","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"        obj.vif_outbound_peak \u003d 65536"},{"line_number":1177,"context_line":"        obj.vif_outbound_burst \u003d 6553"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":1180,"context_line":"        self.assertXmlEqual(xml, \"\"\""},{"line_number":1181,"context_line":"            \u003cinterface type\u003d\"ethernet\"\u003e"},{"line_number":1182,"context_line":"              \u003cmac address\u003d\"DE:AD:BE:EF:CA:FE\"/\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b3534539","line":1179,"in_reply_to":"da20952f_ba7f09de","updated":"2015-09-08 18:18:25.000000000","message":"This patch is just setting more reasonable values in the unit tests, to help people who might use the unit tests as a guide.\n\nThat aside, I think because the limits depend on the virt driver, we can\u0027t validate at the API level before the driver gets the data. The user will see the error from the virt driver in the instance fault after the instance goes into ERROR state, so it is still communicated.","commit_id":"7882551b3b76fb8b99441f32bb8652e9f1bad1ea"}]}