)]}'
{"nova/objects/block_device.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2b6e3dc6354491130a50a1d8c7723e00c021c123","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # bdm.  We don\u0027t want to sync that call as it may not have a"},{"line_number":140,"context_line":"        # device_name yet, so when a later update comes it wouldn\u0027t find this"},{"line_number":141,"context_line":"        # bdm and would create a second one."},{"line_number":142,"context_line":"        if cell_type \u003d\u003d \u0027compute\u0027 and not update_or_create:"},{"line_number":143,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":144,"context_line":"            cells_api.bdm_update_or_create_at_top("},{"line_number":145,"context_line":"                    context, self, create\u003dcells_create)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_ad9bcec8","line":142,"updated":"2015-05-13 08:20:12.000000000","message":"Can we not just check whether device_name is set? (I\u0027m considering the way the docstring is written \"Normally only used when creating the instance for the first time.\" i.e. not guaranteed","commit_id":"8881a80399b5a74586a9f8ddfea9120125ed711c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1919b6a919559a86e9ceed393651e9f5fe06a3d2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # bdm.  We don\u0027t want to sync that call as it may not have a"},{"line_number":140,"context_line":"        # device_name yet, so when a later update comes it wouldn\u0027t find this"},{"line_number":141,"context_line":"        # bdm and would create a second one."},{"line_number":142,"context_line":"        if cell_type \u003d\u003d \u0027compute\u0027 and not update_or_create:"},{"line_number":143,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":144,"context_line":"            cells_api.bdm_update_or_create_at_top("},{"line_number":145,"context_line":"                    context, self, create\u003dcells_create)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_b0290d3a","line":142,"in_reply_to":"9a0c5dc1_ad9bcec8","updated":"2015-06-11 18:48:51.000000000","message":"When I wrote this update_or_create was only set to True when creating it the first time.  But the issue is related to device_name so that is a better check.","commit_id":"8881a80399b5a74586a9f8ddfea9120125ed711c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9dd3d28dfd8d6ed428422eeca21a6df5d789f84a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # so if we sync up with no device_name an entry will be created that"},{"line_number":141,"context_line":"        # will not be found on a later update_or_create call and a second bdm"},{"line_number":142,"context_line":"        # create will occur."},{"line_number":143,"context_line":"        if cell_type \u003d\u003d \u0027compute\u0027 and db_bdm.get(\u0027device_name\u0027) is not None:"},{"line_number":144,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":145,"context_line":"            cells_api.bdm_update_or_create_at_top("},{"line_number":146,"context_line":"                    context, self, create\u003dcells_create)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_bb92804a","line":143,"range":{"start_line":143,"start_character":38,"end_line":143,"end_character":63},"updated":"2015-06-18 09:47:03.000000000","message":"do we also need to take the mount_device into consideration here?","commit_id":"0516f2165ea21a3962e7671b83b9bdda4064fb42"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6403f3c40b03f1b2722e003b745e723d573a99b7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # so if we sync up with no device_name an entry will be created that"},{"line_number":141,"context_line":"        # will not be found on a later update_or_create call and a second bdm"},{"line_number":142,"context_line":"        # create will occur."},{"line_number":143,"context_line":"        if cell_type \u003d\u003d \u0027compute\u0027 and db_bdm.get(\u0027device_name\u0027) is not None:"},{"line_number":144,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":145,"context_line":"            cells_api.bdm_update_or_create_at_top("},{"line_number":146,"context_line":"                    context, self, create\u003dcells_create)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f84240ad","line":143,"range":{"start_line":143,"start_character":38,"end_line":143,"end_character":63},"in_reply_to":"fa32b979_bb92804a","updated":"2015-06-18 14:03:45.000000000","message":"No.  We just need to ensure that any bdm created at the top cell can be looked up later.  Since the lookup is based on instance uuid and bdm device_name we need to make sure we don\u0027t send a message to create a bdm without a device_name.","commit_id":"0516f2165ea21a3962e7671b83b9bdda4064fb42"}]}