)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee479961b077e65b98bf8f80c3f22451e9e1ed89","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When backporting a FixedIP object to the version 1.1 and less"},{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_d71bdec8","line":11,"updated":"2015-06-04 15:45:29.000000000","message":"Where is the commit that added this?  I see the network object was in the initial 1.0 version of the FixedIP object:\n\n92f281e7a04f27c90cfccc11261880213718ae8b","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5fa010f4d0972fde31d0ec4bb2484f0708e9f90f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When backporting a FixedIP object to the version 1.1 and less"},{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_f23268f1","line":11,"in_reply_to":"5afe65bd_d71bdec8","updated":"2015-06-04 15:47:56.000000000","message":"I mean I see that fixedip and network objects are version 1.1 in icehouse, but the 1.2 thing is confusing me.","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"c3d9e16974005ebc1aec278779c707710568efbc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When backporting a FixedIP object to the version 1.1 and less"},{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_673d328e","line":11,"in_reply_to":"5afe65bd_f23268f1","updated":"2015-06-18 12:10:13.000000000","message":"I understand your confusion. Let me explain.\nIn the beginning we have FixedIp v1.0 and Network v1.0.\nAfter that version of FixedIp was dumped and we have FexedIp v1.1 and Network v1.0\n\nNext two commits changed version of Network to v1.2, but these commits does NOT dump FixedIp version :(\n\n275a165cf0e74112d7ec9addacb1f84d703977c8\n\nad6051bb5c2b62a0de6708cd2d7ac1e3cfd8f1d3\n\nIn fact we should have two new versions of FixedIp between v1.1 and v1.2. Something like:\n\n    class FixedIp():\n    # Version 1.0: Initial version\n    # Version 1.1: Added virtual_interface field\n    # Version 1.1.1: Network \u003c\u003d 1.1\n    # Version 1.1.2: Network \u003c\u003d 1.2\n    # Version 1.2: Instance version 1.14\n\nBut we forgot about dumping when we changed Network version.\n\nSo I think that the most right way will be to backport these objects to v1.1 (like in IceHouse)","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f290b493fadd3c1bed5cdb6d68412791a079a588","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When backporting a FixedIP object to the version 1.1 and less"},{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_7f9e1aba","line":11,"in_reply_to":"fa32b979_673d328e","updated":"2015-06-18 13:08:01.000000000","message":"Honestly, I think it would be worth at least mentioning those 2 changes in the commit msg.","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4872183a147757a76897785d7cc02504e7c63c74","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"},{"line_number":15,"context_line":"a FixedIP object of version 1.1 with an embedded Network"},{"line_number":16,"context_line":"object of 1.2, Icehouse then incorrectly tries to backport"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_63a2514d","line":13,"updated":"2015-05-28 08:58:03.000000000","message":"Technically, we only support N-1 upgrades right ?\n\nI\u0027m not against patching the dependency version but I just wonder if that\u0027s the right way to update it on master, since the update will only concern Liberty nodes (which would then talk to Icehouse computes)","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"473b92a353c4a1ef8ff89f0109a344a580eb9a51","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"},{"line_number":15,"context_line":"a FixedIP object of version 1.1 with an embedded Network"},{"line_number":16,"context_line":"object of 1.2, Icehouse then incorrectly tries to backport"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_a68f3422","line":13,"in_reply_to":"7a016987_63a2514d","updated":"2015-05-28 10:35:59.000000000","message":"Honestly, I tried to fix it in kilo. But at one moment kilo was released and patch was moved to the liberty. I have another patch to the juno https://review.openstack.org/#/c/175839/ and I think I have to create another one for the kilo.","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f290b493fadd3c1bed5cdb6d68412791a079a588","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This backporting is needed when we use Icehouse compute."},{"line_number":14,"context_line":"In this case nova-conductor sends back"},{"line_number":15,"context_line":"a FixedIP object of version 1.1 with an embedded Network"},{"line_number":16,"context_line":"object of 1.2, Icehouse then incorrectly tries to backport"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_bf8fc273","line":13,"in_reply_to":"7a016987_a68f3422","updated":"2015-06-18 13:08:01.000000000","message":"So, I\u0027m not exactly good at stable branch, but I think we should at least backport that change to Kilo","commit_id":"589c751d1e27fc337b1db83568ac27a11cb1c1e9"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"fda72c37e055330646172757401ed8dc3c22249d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next two commits changed version of Network to v1.2,"},{"line_number":14,"context_line":"but these commits does NOT dump FixedIp version:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"275a165cf0e74112d7ec9addacb1f84d703977c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a50d1a3_1c74e633","line":13,"updated":"2015-07-22 15:33:46.000000000","message":"nit: Next -\u003e The following","commit_id":"3fe9e10f69972a884c6fa6b81cae774418a08eae"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"6cd00c91f70ed1025770fc7ed78c7ddb2f0cc738","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we must backport Network object to version 1.1, because since"},{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next two commits changed version of Network to v1.2,"},{"line_number":14,"context_line":"but these commits does NOT dump FixedIp version:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"275a165cf0e74112d7ec9addacb1f84d703977c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a50d1a3_b19926c6","line":13,"in_reply_to":"3a50d1a3_1c74e633","updated":"2015-07-23 11:46:12.000000000","message":"Done","commit_id":"3fe9e10f69972a884c6fa6b81cae774418a08eae"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"fda72c37e055330646172757401ed8dc3c22249d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next two commits changed version of Network to v1.2,"},{"line_number":14,"context_line":"but these commits does NOT dump FixedIp version:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"275a165cf0e74112d7ec9addacb1f84d703977c8"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a50d1a3_bcb292e3","line":14,"updated":"2015-07-22 15:33:46.000000000","message":"nit: does -\u003e do","commit_id":"3fe9e10f69972a884c6fa6b81cae774418a08eae"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"6cd00c91f70ed1025770fc7ed78c7ddb2f0cc738","unresolved":false,"context_lines":[{"line_number":11,"context_line":"version 1.2, FixedIp object uses Network object v1.2."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Next two commits changed version of Network to v1.2,"},{"line_number":14,"context_line":"but these commits does NOT dump FixedIp version:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"275a165cf0e74112d7ec9addacb1f84d703977c8"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a50d1a3_d194f28b","line":14,"in_reply_to":"3a50d1a3_bcb292e3","updated":"2015-07-23 11:46:12.000000000","message":"Done","commit_id":"3fe9e10f69972a884c6fa6b81cae774418a08eae"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"0f2828acff42b3c315d9099f780e858810b8d32d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    class FixedIp():"},{"line_number":24,"context_line":"    # Version 1.0: Initial version"},{"line_number":25,"context_line":"    # Version 1.1: Added virtual_interface field"},{"line_number":26,"context_line":"    # Version 1.1.1: Network \u003c\u003d 1.1"},{"line_number":27,"context_line":"    # Version 1.1.2: Network \u003c\u003d 1.2"},{"line_number":28,"context_line":"    # Version 1.2: Instance version 1.14"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_8bae207f","line":26,"updated":"2015-07-23 19:08:10.000000000","message":"This part of your commit message is very confusing and contradictory to what you actually implemented. You\u0027re saying we should make it with .z versioning, but in the actual change, you just update the obj_relationships without changing the versioning of FixedIP.","commit_id":"ebb2830a92cd90aa4904ac957391034bc7689b9c"}],"nova/objects/fixed_ip.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"0f2828acff42b3c315d9099f780e858810b8d32d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class FixedIP(obj_base.NovaPersistentObject, obj_base.NovaObject,"},{"line_number":32,"context_line":"              obj_base.NovaObjectDictCompat):"},{"line_number":33,"context_line":"    # Version 1.0: Initial version"},{"line_number":34,"context_line":"    # Version 1.1: Added virtual_interface field"},{"line_number":35,"context_line":"    # Version 1.2: Instance version 1.14"},{"line_number":36,"context_line":"    # Version 1.3: Instance 1.15"},{"line_number":37,"context_line":"    # Version 1.4: Added default_route field"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_6bf63490","line":34,"updated":"2015-07-23 19:08:10.000000000","message":"you should note in the version 1.2 comment here the new obj_relationships mapping you are adding below. That way we get to maintain history (even if we are re-writing it).\n\nThis kind of change was also done here (https://review.openstack.org/#/c/201280/9/nova/objects/instance.py) and we should probably stay consistent with how we\u0027re rewriting history.","commit_id":"ebb2830a92cd90aa4904ac957391034bc7689b9c"}]}