)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6487ee8b77a3a1464d972d0ebab11ab3afaacb5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Resource tracker: unable to restart nova compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The resource tracker calculates its used reousrces. In certain cases"},{"line_number":10,"context_line":"of failed migrations and an instance being deleted the resource tracker"},{"line_number":11,"context_line":"causes an exception in nova compute. If this situation arises then nova"},{"line_number":12,"context_line":"compute may not even be able to restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aa745d1_7d7c9720","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":50},"updated":"2015-04-15 18:36:47.000000000","message":"\"resources\" is misspelled.","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fafc0288e5ccc0cc92111d6e53ed9340c50c07c5","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                instance \u003d migration.instance"},{"line_number":710,"context_line":"            except exception.InstanceNotFound:"},{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_ae74a735","line":712,"updated":"2015-04-15 12:21:19.000000000","message":"could we at least log a warning so this issue is not lost?","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ca236380c311a8bc628ec48108862191655f997e","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                instance \u003d migration.instance"},{"line_number":710,"context_line":"            except exception.InstanceNotFound:"},{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_d1cd5686","line":712,"in_reply_to":"7aaa499b_ae74a735","updated":"2015-04-15 12:47:51.000000000","message":"sure i will add a log","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fafc0288e5ccc0cc92111d6e53ed9340c50c07c5","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"},{"line_number":716,"context_line":"                continue"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_2eae5781","line":714,"updated":"2015-04-15 12:21:19.000000000","message":"I am guessing pre object you didn\u0027t get an exception? Do we still need this clause?","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"285d3fa3afdc23a8a70573b68eaa831146aa8071","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"},{"line_number":716,"context_line":"                continue"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_14a84cda","line":714,"in_reply_to":"7aaa499b_11b3beea","updated":"2015-04-15 12:59:42.000000000","message":"agreed, just thinking we probably need to look into why this if statement is here, I suspect this is now unreachable due to the above exception being added.","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6487ee8b77a3a1464d972d0ebab11ab3afaacb5","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"},{"line_number":716,"context_line":"                continue"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_9d864312","line":714,"in_reply_to":"7aaa499b_14a84cda","updated":"2015-04-15 18:36:47.000000000","message":"Yep, migration.instance is an @property, which means it always does the lookup and thus either returns an instance or triggers the above exception clause.","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ca236380c311a8bc628ec48108862191655f997e","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                continue"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"            if not instance:"},{"line_number":715,"context_line":"                # migration referencing deleted instance"},{"line_number":716,"context_line":"                continue"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_11b3beea","line":714,"in_reply_to":"7aaa499b_2eae5781","updated":"2015-04-15 12:47:51.000000000","message":"the exception is due to a change in the last two or three weeks. prior to this i did not have the issues that i am having now...","commit_id":"26fe91a2ef11b81956bd5a8bd48546b883c0e08f"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"81590e8e5885389b96e2a1661e47bb02d8b4057e","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for migration in migrations:"},{"line_number":708,"context_line":"            try:"},{"line_number":709,"context_line":"                instance \u003d migration.instance"},{"line_number":710,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                LOG.debug(\u0027Migration instance not found: %s\u0027, e)"},{"line_number":713,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_eda33f4e","line":710,"updated":"2015-04-20 08:47:08.000000000","message":"so this relies on this always triggering a lazy-load, but that may not be the case always, right?\n\nSo we can explicitly look-up the instance every time, or actually (probably better), do both checks here (that it does nto trhow and that it is not None?","commit_id":"ee7a7446cc6947a6bacacb6cb514934cc22e5782"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"73ce284ac47cf5680b92b37839a483b1ff2b33dd","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for migration in migrations:"},{"line_number":708,"context_line":"            try:"},{"line_number":709,"context_line":"                instance \u003d migration.instance"},{"line_number":710,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                LOG.debug(\u0027Migration instance not found: %s\u0027, e)"},{"line_number":713,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_56e2bca0","line":710,"in_reply_to":"dac4157f_76f2609c","updated":"2015-04-20 10:05:52.000000000","message":"nice tidy up, thanks.","commit_id":"ee7a7446cc6947a6bacacb6cb514934cc22e5782"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6bed71fc24600a5b857ba239c66a803daf291e6e","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for migration in migrations:"},{"line_number":708,"context_line":"            try:"},{"line_number":709,"context_line":"                instance \u003d migration.instance"},{"line_number":710,"context_line":"            except exception.InstanceNotFound as e:"},{"line_number":711,"context_line":"                # migration referencing deleted instance"},{"line_number":712,"context_line":"                LOG.debug(\u0027Migration instance not found: %s\u0027, e)"},{"line_number":713,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_76f2609c","line":710,"in_reply_to":"dac4157f_eda33f4e","updated":"2015-04-20 10:02:20.000000000","message":"Just read the code and migration.instance will actually _always_ cause a load, so the above is not relevant.","commit_id":"ee7a7446cc6947a6bacacb6cb514934cc22e5782"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"73ce284ac47cf5680b92b37839a483b1ff2b33dd","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"    @mock.patch(\u0027nova.objects.MigrationList.get_in_progress_by_host_and_node\u0027)"},{"line_number":1088,"context_line":"    def test_deleted_instances_with_migrations(self, mock_migration_list):"},{"line_number":1089,"context_line":"        migration \u003d objects.Migration(context\u003dself.context,"},{"line_number":1090,"context_line":"                                      instance_uuid\u003d\u0027invalid\u0027)"},{"line_number":1091,"context_line":"        mock_migration_list.return_value \u003d [migration]"},{"line_number":1092,"context_line":"        self.tracker.update_available_resource(self.context)"},{"line_number":1093,"context_line":"        self.assertEqual(0, self.tracker.compute_node[\u0027memory_mb_used\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_f6d0b0cb","line":1090,"updated":"2015-04-20 10:05:52.000000000","message":"I have a preference for mocking out the call and explicitly raising the exception, mostly as it avoids any DB calls, but I guess this should work.","commit_id":"ee7a7446cc6947a6bacacb6cb514934cc22e5782"}]}