)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37409046f595d7cc23214043f9c89e440a3d08f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: enable a resize of instance with no root disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This address the issue when the user wishes to update the CPU"},{"line_number":10,"context_line":"or memory of the instance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"No changes to disks will be done if there is no root disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_26d49245","line":9,"updated":"2015-06-07 22:59:47.000000000","message":"s/address/addresses","commit_id":"dd5ccf7c5db2d03c46bbb5179f9e961d479ce386"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7313ef027de9f4afacf383d93ff29ee08e068999","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: enable a resize of instance with no root disk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This address the issue when the user wishes to update the CPU"},{"line_number":10,"context_line":"or memory of the instance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"No changes to disks will be done if there is no root disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3afb71cf_d22e8af9","line":9,"in_reply_to":"3afb71cf_26d49245","updated":"2015-06-08 10:58:27.000000000","message":"Done","commit_id":"dd5ccf7c5db2d03c46bbb5179f9e961d479ce386"}],"nova/tests/unit/virt/vmwareapi/test_vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a9c9b16a083769ca1a4559e7c1d74d14edbeb85a","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_ephemeral\u0027)"},{"line_number":555,"context_line":"    @mock.patch.object(ds_obj, \u0027get_datastore_by_ref\u0027,"},{"line_number":556,"context_line":"                       return_value\u003d\u0027fake-ds-ref\u0027)"},{"line_number":557,"context_line":"    @mock.patch.object(vm_util, \u0027get_vmdk_info\u0027)"},{"line_number":558,"context_line":"    def _test_resize_create_ephemerals(self, vmdk, datastore,"},{"line_number":559,"context_line":"                                       mock_get_vmdk_info,"},{"line_number":560,"context_line":"                                       mock_get_datastore_by_ref,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_55911b99","line":557,"updated":"2015-09-10 14:52:23.000000000","message":"hmm, this is an odd style, but it appears to work.","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5db6ebf0a050c9af63f9008403693c4df1a292c4","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_ephemeral\u0027)"},{"line_number":555,"context_line":"    @mock.patch.object(ds_obj, \u0027get_datastore_by_ref\u0027,"},{"line_number":556,"context_line":"                       return_value\u003d\u0027fake-ds-ref\u0027)"},{"line_number":557,"context_line":"    @mock.patch.object(vm_util, \u0027get_vmdk_info\u0027)"},{"line_number":558,"context_line":"    def _test_resize_create_ephemerals(self, vmdk, datastore,"},{"line_number":559,"context_line":"                                       mock_get_vmdk_info,"},{"line_number":560,"context_line":"                                       mock_get_datastore_by_ref,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_3b82a653","line":557,"in_reply_to":"ba15a1d1_22cccf34","updated":"2015-09-14 12:18:08.000000000","message":"hmm, not sure why I added that comment either :S","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c2d28a2d67348eee2ebdf2875ef74b8499760b2d","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_ephemeral\u0027)"},{"line_number":555,"context_line":"    @mock.patch.object(ds_obj, \u0027get_datastore_by_ref\u0027,"},{"line_number":556,"context_line":"                       return_value\u003d\u0027fake-ds-ref\u0027)"},{"line_number":557,"context_line":"    @mock.patch.object(vm_util, \u0027get_vmdk_info\u0027)"},{"line_number":558,"context_line":"    def _test_resize_create_ephemerals(self, vmdk, datastore,"},{"line_number":559,"context_line":"                                       mock_get_vmdk_info,"},{"line_number":560,"context_line":"                                       mock_get_datastore_by_ref,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_22cccf34","line":557,"in_reply_to":"da20952f_55911b99","updated":"2015-09-13 06:00:48.000000000","message":"i am not sure i understand the comment.","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37409046f595d7cc23214043f9c89e440a3d08f8","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1179,"context_line":"        if not vmdk.device:"},{"line_number":1180,"context_line":"            LOG.warning(_LW(\"No root disk attached!\"),"},{"line_number":1181,"context_line":"                        instance\u003dinstance)"},{"line_number":1182,"context_line":"            return"},{"line_number":1183,"context_line":"        ds_ref \u003d vmdk.device.backing.datastore"},{"line_number":1184,"context_line":"        datastore \u003d ds_util.get_datastore_by_ref(self._session, ds_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c6c5be8e","line":1181,"updated":"2015-06-07 22:59:47.000000000","message":"This can be combined onto one line.","commit_id":"dd5ccf7c5db2d03c46bbb5179f9e961d479ce386"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7313ef027de9f4afacf383d93ff29ee08e068999","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1179,"context_line":"        if not vmdk.device:"},{"line_number":1180,"context_line":"            LOG.warning(_LW(\"No root disk attached!\"),"},{"line_number":1181,"context_line":"                        instance\u003dinstance)"},{"line_number":1182,"context_line":"            return"},{"line_number":1183,"context_line":"        ds_ref \u003d vmdk.device.backing.datastore"},{"line_number":1184,"context_line":"        datastore \u003d ds_util.get_datastore_by_ref(self._session, ds_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_52f4da85","line":1181,"in_reply_to":"3afb71cf_c6c5be8e","updated":"2015-06-08 10:58:27.000000000","message":"Done","commit_id":"dd5ccf7c5db2d03c46bbb5179f9e961d479ce386"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"37409046f595d7cc23214043f9c89e440a3d08f8","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                               original_disk.parent,"},{"line_number":1269,"context_line":"                               original_disk.basename):"},{"line_number":1270,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance,"},{"line_number":1271,"context_line":"                                                vmdk.device)"},{"line_number":1272,"context_line":"            ds_util.disk_delete(self._session, dc_info.ref, vmdk.path)"},{"line_number":1273,"context_line":"            ds_util.disk_move(self._session, dc_info.ref,"},{"line_number":1274,"context_line":"                              str(original_disk), vmdk.path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_0642b610","line":1271,"updated":"2015-06-07 22:59:47.000000000","message":"This can be combined onto a single line as it was before the refactor into a method.","commit_id":"dd5ccf7c5db2d03c46bbb5179f9e961d479ce386"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a9c9b16a083769ca1a4559e7c1d74d14edbeb85a","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, vm_ref,"},{"line_number":1268,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1269,"context_line":"        if not vmdk.device:"},{"line_number":1270,"context_line":"            LOG.warning(_LW(\"No root disk attached!\"), instance\u003dinstance)"},{"line_number":1271,"context_line":"            return"},{"line_number":1272,"context_line":"        ds_ref \u003d vmdk.device.backing.datastore"},{"line_number":1273,"context_line":"        datastore \u003d ds_obj.get_datastore_by_ref(self._session, ds_ref)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_8ee8fd17","line":1270,"updated":"2015-09-10 14:52:23.000000000","message":"What is a VM without a root disk? just an in memory thing?\n\nIf this is a valid use case, maybe it should just be a debug message?","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ec383dbac072477baa938e5e9ea707100ff832e","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, vm_ref,"},{"line_number":1268,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1269,"context_line":"        if not vmdk.device:"},{"line_number":1270,"context_line":"            LOG.warning(_LW(\"No root disk attached!\"), instance\u003dinstance)"},{"line_number":1271,"context_line":"            return"},{"line_number":1272,"context_line":"        ds_ref \u003d vmdk.device.backing.datastore"},{"line_number":1273,"context_line":"        datastore \u003d ds_obj.get_datastore_by_ref(self._session, ds_ref)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_7be7be40","line":1270,"in_reply_to":"ba15a1d1_c2d073cc","updated":"2015-09-14 12:19:32.000000000","message":"agreed, I just don\u0027t know how you do that using the current Nova APIs.\n\ndisk_gb\u003d0 in the flavor means use the default size of the image in glance.\n\nmaybe you can do it using BDMs or something?","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c2d28a2d67348eee2ebdf2875ef74b8499760b2d","unresolved":false,"context_lines":[{"line_number":1267,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, vm_ref,"},{"line_number":1268,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1269,"context_line":"        if not vmdk.device:"},{"line_number":1270,"context_line":"            LOG.warning(_LW(\"No root disk attached!\"), instance\u003dinstance)"},{"line_number":1271,"context_line":"            return"},{"line_number":1272,"context_line":"        ds_ref \u003d vmdk.device.backing.datastore"},{"line_number":1273,"context_line":"        datastore \u003d ds_obj.get_datastore_by_ref(self._session, ds_ref)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_c2d073cc","line":1270,"in_reply_to":"da20952f_8ee8fd17","updated":"2015-09-13 06:00:48.000000000","message":"Done\n\nA VM without a root disk is one that just runs in memory. An example of this would be booting from a CD and it does not require any root disk","commit_id":"d5415b3802f06c6131a43a5f7c206316e9b5e924"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"53f4649cbedece45b502f49a52442cc0b772076f","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                    metadata\u003dmetadata)"},{"line_number":1392,"context_line":"        vm_util.reconfigure_vm(self._session, vm_ref, vm_resize_spec)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        # Reconfigure the disks if necessary"},{"line_number":1395,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, vm_ref,"},{"line_number":1396,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1397,"context_line":"        if vmdk.device:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_dd1a79c5","line":1394,"range":{"start_line":1394,"start_character":8,"end_line":1394,"end_character":44},"updated":"2016-03-03 23:25:15.000000000","message":"This comment should be move to line 1353 because the corresponding code is moved to the line.","commit_id":"9ba1557af9e438b9a083751074960fad3179fc53"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c55dff165d46e2c833ada228af39eea19dcefc9","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"                                                    metadata\u003dmetadata)"},{"line_number":1392,"context_line":"        vm_util.reconfigure_vm(self._session, vm_ref, vm_resize_spec)"},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        # Reconfigure the disks if necessary"},{"line_number":1395,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, vm_ref,"},{"line_number":1396,"context_line":"                                     uuid\u003dinstance.uuid)"},{"line_number":1397,"context_line":"        if vmdk.device:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_05d0c452","line":1394,"range":{"start_line":1394,"start_character":8,"end_line":1394,"end_character":44},"in_reply_to":"7af24918_dd1a79c5","updated":"2016-03-07 14:25:05.000000000","message":"I have removed this as there is already a comment there","commit_id":"9ba1557af9e438b9a083751074960fad3179fc53"}]}