)]}'
{"nova/conductor/rpcapi.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a1187751d930508c7cb0b59b2eaf957eb733deb2","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    * 2.1  - Make notify_usage_exists() take an instance object"},{"line_number":160,"context_line":"    * Remove bw_usage_update()"},{"line_number":161,"context_line":"    * Remove notify_usage_exists()"},{"line_number":162,"context_line":"    * Remove get_ec2_ids()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    ... Kilo supports message version 2.1.  So, any changes to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_91d39f38","line":161,"updated":"2015-04-17 20:16:30.000000000","message":"Maybe not that important, but get_ec2_ids() was removed after the kilo branch was cut so to be perfectly correct you should insert the message here.","commit_id":"12e4d77a03f75f78b77c6a006fc47c46d708af55"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"11163b6cab845417f2ad1cb19b971a58d7a67642","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    * 2.1  - Make notify_usage_exists() take an instance object"},{"line_number":160,"context_line":"    * Remove bw_usage_update()"},{"line_number":161,"context_line":"    * Remove notify_usage_exists()"},{"line_number":162,"context_line":"    * Remove get_ec2_ids()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    ... Kilo supports message version 2.1.  So, any changes to"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_ed30eda0","line":161,"in_reply_to":"3ab451fb_91d39f38","updated":"2015-04-19 05:01:43.000000000","message":"ok, thanks, will update","commit_id":"12e4d77a03f75f78b77c6a006fc47c46d708af55"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"7671207ff83b95195019f24fcb808418d14153a7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    * Remove service_create()"},{"line_number":165,"context_line":"    * Remove service_destroy()"},{"line_number":166,"context_line":"    * Remove service_update()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    \"\"\""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_1bd58d42","side":"PARENT","line":167,"updated":"2015-04-20 09:25:40.000000000","message":"nit: unrelated, please remove if you do another respin","commit_id":"dc06cf40c44eabcd99ad97486914515a839d2fc4"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b73da412f27293753432486e2b2f3f218853cb68","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    ... Icehouse supports message version 2.0.  So, any changes to"},{"line_number":143,"context_line":"    existing methods in 2.x after that point should be done such"},{"line_number":144,"context_line":"    that they can handle the version_cap being set to 2.0."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    * Remove instance_destroy()"},{"line_number":147,"context_line":"    * Remove compute_unrescue()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_c9f50684","line":144,"updated":"2015-04-20 12:39:57.000000000","message":"here all the remove comments are after the Icehouse comment although they are for 2.0","commit_id":"539ed63e94b2daf65d76c3bba2b24461282a42c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"004516d0303a4b183f5dd06c4846fa973b3e7908","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ... Kilo supports message version 2.1.  So, any changes to"},{"line_number":164,"context_line":"    existing methods in 2.x after that point should be done such"},{"line_number":165,"context_line":"    that they can handle the version_cap being set to 2.1."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    * Remove get_ec2_ids()"},{"line_number":168,"context_line":"    * Remove service_get_all_by()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_e941ea3a","line":165,"updated":"2015-04-20 12:30:16.000000000","message":"should this not be after all the remove statements, assuming they were all removed under v2.1","commit_id":"539ed63e94b2daf65d76c3bba2b24461282a42c3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bdfb5c85207a56e505249ffed420a49db7d993ff","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ... Kilo supports message version 2.1.  So, any changes to"},{"line_number":164,"context_line":"    existing methods in 2.x after that point should be done such"},{"line_number":165,"context_line":"    that they can handle the version_cap being set to 2.1."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    * Remove get_ec2_ids()"},{"line_number":168,"context_line":"    * Remove service_get_all_by()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_ffb4fcd1","line":165,"in_reply_to":"dac4157f_4909f694","updated":"2015-04-20 13:22:23.000000000","message":"Yes, those removed by Hans at https://review.openstack.org/#/c/149749/ and https://review.openstack.org/#/c/133664/21, and after kilo branch was cut.","commit_id":"539ed63e94b2daf65d76c3bba2b24461282a42c3"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b73da412f27293753432486e2b2f3f218853cb68","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ... Kilo supports message version 2.1.  So, any changes to"},{"line_number":164,"context_line":"    existing methods in 2.x after that point should be done such"},{"line_number":165,"context_line":"    that they can handle the version_cap being set to 2.1."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    * Remove get_ec2_ids()"},{"line_number":168,"context_line":"    * Remove service_get_all_by()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_4909f694","line":165,"in_reply_to":"dac4157f_e941ea3a","updated":"2015-04-20 12:39:57.000000000","message":"John, I asked for it to be placed here so that comments be placed in order with the release they were part of. All lines after this comment were done after kilo branch was cut.\n\nSee previously how it has been done.","commit_id":"539ed63e94b2daf65d76c3bba2b24461282a42c3"}],"nova/scheduler/rpcapi.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"5e46e7c06716c1bd2d013ae5886a628c0c13b910","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                sync_instance_info()  methods"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        ... Kilo support message version 4.2. So, any changes to existing"},{"line_number":95,"context_line":"        methods in 3.x after that point should be done such that they can"},{"line_number":96,"context_line":"        handle the version_cap being set to 4.2."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_1158cef9","line":95,"updated":"2015-04-16 07:59:03.000000000","message":"...changes to existing methods in 4.x","commit_id":"c8d59a4226b8b37a7c23ac371ac28d77c720844d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81aa335154f93e13c85d3b09f4c6f8c1dd6fbb7e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                sync_instance_info()  methods"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        ... Kilo support message version 4.2. So, any changes to existing"},{"line_number":95,"context_line":"        methods in 3.x after that point should be done such that they can"},{"line_number":96,"context_line":"        handle the version_cap being set to 4.2."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_0a03ec74","line":95,"in_reply_to":"5aa745d1_1158cef9","updated":"2015-04-16 11:38:48.000000000","message":"thanks :)","commit_id":"c8d59a4226b8b37a7c23ac371ac28d77c720844d"}]}