)]}'
{"nova/objects/task_log.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3c7dff6452f13a8a95d0fea52f76e9649d8165c0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def begin_task(self):"},{"line_number":54,"context_line":"        db.task_log_begin_task("},{"line_number":55,"context_line":"            self._context, self.task_name, self.period_beginning,"},{"line_number":56,"context_line":"            self.period_ending, self.host, task_items\u003dself.task_items,"},{"line_number":57,"context_line":"            message\u003dself.message)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_e6800cf9","line":56,"updated":"2015-06-11 08:59:37.000000000","message":"Maybe I am missing something here. Please see https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L5867\nThe task_items can be None and the same with the message. When the task object is created are these set to None?","commit_id":"d203bdbd4c52f2dc254acf2907ddc23ce329fd66"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"499c19e4e54f4f1e569c02ccb706b7f0a7e1a631","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def begin_task(self):"},{"line_number":54,"context_line":"        db.task_log_begin_task("},{"line_number":55,"context_line":"            self._context, self.task_name, self.period_beginning,"},{"line_number":56,"context_line":"            self.period_ending, self.host, task_items\u003dself.task_items,"},{"line_number":57,"context_line":"            message\u003dself.message)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_99d75dbf","line":56,"in_reply_to":"3afb71cf_e6800cf9","updated":"2015-06-11 20:05:51.000000000","message":"Right now, this is just going to be used in one place and that one will set both parameters, so not currently an issue. That said, the db api isn\u0027t perfect and could be changed to better fit how objects normally do things. E.g. just send the updated fields and let the db api fill in the blanks where needed.","commit_id":"d203bdbd4c52f2dc254acf2907ddc23ce329fd66"}],"nova/tests/unit/objects/test_task_log.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3c7dff6452f13a8a95d0fea52f76e9649d8165c0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u0027errors\u0027: 0,"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class _TestTaskLog(object):"},{"line_number":43,"context_line":"    @mock.patch(\u0027nova.db.task_log_get\u0027, return_value\u003dfake_task_log)"},{"line_number":44,"context_line":"    def test_get(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_06956831","line":41,"updated":"2015-06-11 08:59:37.000000000","message":"Would it be possible to have tests that actually write to and read from the DB?","commit_id":"d203bdbd4c52f2dc254acf2907ddc23ce329fd66"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"499c19e4e54f4f1e569c02ccb706b7f0a7e1a631","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u0027errors\u0027: 0,"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class _TestTaskLog(object):"},{"line_number":43,"context_line":"    @mock.patch(\u0027nova.db.task_log_get\u0027, return_value\u003dfake_task_log)"},{"line_number":44,"context_line":"    def test_get(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_796141d3","line":41,"in_reply_to":"3afb71cf_06956831","updated":"2015-06-11 20:05:51.000000000","message":"Sure. Is that something we want to have?","commit_id":"d203bdbd4c52f2dc254acf2907ddc23ce329fd66"}]}