)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"366e16b3e8ae80057661ae50145d84b09cfac9fd","unresolved":false,"context_lines":[{"line_number":5866,"context_line":"                errors +\u003d 1"},{"line_number":5867,"context_line":"        task_log.errors \u003d errors"},{"line_number":5868,"context_line":"        task_log.message \u003d ("},{"line_number":5869,"context_line":"            \u0027Instance usage audit ran for host %s, %s instances in %s seconds.\u0027"},{"line_number":5870,"context_line":"            % (self.host, num_instances, time.time() - start_time))"},{"line_number":5871,"context_line":"        task_log.end_task()"},{"line_number":5872,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_0141ac0b","line":5869,"updated":"2015-05-11 08:32:23.000000000","message":"we always use %(var)s way when there are more than one vars.","commit_id":"baf5e22e0ea7528930ea954d8cb5a039a2941748"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"7e4abf51809963e2b747ff7036835c8c6ee3babb","unresolved":false,"context_lines":[{"line_number":5866,"context_line":"                errors +\u003d 1"},{"line_number":5867,"context_line":"        task_log.errors \u003d errors"},{"line_number":5868,"context_line":"        task_log.message \u003d ("},{"line_number":5869,"context_line":"            \u0027Instance usage audit ran for host %s, %s instances in %s seconds.\u0027"},{"line_number":5870,"context_line":"            % (self.host, num_instances, time.time() - start_time))"},{"line_number":5871,"context_line":"        task_log.end_task()"},{"line_number":5872,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_44ffc201","line":5869,"in_reply_to":"9af37de9_0141ac0b","updated":"2015-05-11 08:38:22.000000000","message":"This is the same message as before. I haven\u0027t changed it. I\u0027ll change it though if I have to do another spin.","commit_id":"baf5e22e0ea7528930ea954d8cb5a039a2941748"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"811f308cbc25b032ed5cd73489a94850774d165b","unresolved":false,"context_lines":[{"line_number":5866,"context_line":"                errors +\u003d 1"},{"line_number":5867,"context_line":"        task_log.errors \u003d errors"},{"line_number":5868,"context_line":"        task_log.message \u003d ("},{"line_number":5869,"context_line":"            \u0027Instance usage audit ran for host %s, %s instances in %s seconds.\u0027"},{"line_number":5870,"context_line":"            % (self.host, num_instances, time.time() - start_time))"},{"line_number":5871,"context_line":"        task_log.end_task()"},{"line_number":5872,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9af37de9_442b42ec","line":5869,"in_reply_to":"9af37de9_44ffc201","updated":"2015-05-11 09:03:39.000000000","message":"yea, it isn\u0027t your fault. so let me +1!","commit_id":"baf5e22e0ea7528930ea954d8cb5a039a2941748"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0c304618f8e5a7d767fde808e2a8549b7318585e","unresolved":false,"context_lines":[{"line_number":5459,"context_line":"                  \u0027end_time\u0027: end,"},{"line_number":5460,"context_line":"                  \u0027number_instances\u0027: num_instances})"},{"line_number":5461,"context_line":"        start_time \u003d time.time()"},{"line_number":5462,"context_line":"        task_log \u003d objects.TaskLog(context)"},{"line_number":5463,"context_line":"        task_log.task_name \u003d \u0027instance_usage_audit\u0027"},{"line_number":5464,"context_line":"        task_log.period_beginning \u003d begin"},{"line_number":5465,"context_line":"        task_log.period_ending \u003d end"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_06bc48b9","line":5462,"updated":"2015-06-11 09:02:39.000000000","message":"why do we not pass all of the values when we create the task? Is that possible?","commit_id":"a06fbf5f4853676c90354b40d5f4e2ee86391df2"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"fb968d48b7e4d23aa8742231eb20c376b520860c","unresolved":false,"context_lines":[{"line_number":5459,"context_line":"                  \u0027end_time\u0027: end,"},{"line_number":5460,"context_line":"                  \u0027number_instances\u0027: num_instances})"},{"line_number":5461,"context_line":"        start_time \u003d time.time()"},{"line_number":5462,"context_line":"        task_log \u003d objects.TaskLog(context)"},{"line_number":5463,"context_line":"        task_log.task_name \u003d \u0027instance_usage_audit\u0027"},{"line_number":5464,"context_line":"        task_log.period_beginning \u003d begin"},{"line_number":5465,"context_line":"        task_log.period_ending \u003d end"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_dc2383a6","line":5462,"in_reply_to":"3afb71cf_06bc48b9","updated":"2015-06-11 20:17:54.000000000","message":"Not sure I understand what you mean? Everything is set on the object before calling task_log.begin_task(), which is when the task is created.","commit_id":"a06fbf5f4853676c90354b40d5f4e2ee86391df2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f40b507e477d415ff74516ea38c0ff0ad6bc3bd","unresolved":false,"context_lines":[{"line_number":5431,"context_line":"                  \u0027number_instances\u0027: num_instances})"},{"line_number":5432,"context_line":"        start_time \u003d time.time()"},{"line_number":5433,"context_line":"        task_log \u003d objects.TaskLog(context)"},{"line_number":5434,"context_line":"        task_log.task_name \u003d \u0027instance_usage_audit\u0027"},{"line_number":5435,"context_line":"        task_log.period_beginning \u003d begin"},{"line_number":5436,"context_line":"        task_log.period_ending \u003d end"},{"line_number":5437,"context_line":"        task_log.host \u003d self.host"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_404d0c98","line":5434,"updated":"2015-07-17 16:24:14.000000000","message":"I don\u0027t see a test for this, and it would be nice to have an enum type here. But we can fix that up later.","commit_id":"e3a9ad932bf86cc4cb6a98667cfa9d7354e60440"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0c304618f8e5a7d767fde808e2a8549b7318585e","unresolved":false,"context_lines":[{"line_number":5845,"context_line":""},{"line_number":5846,"context_line":"def _task_log_get_query(context, task_name, period_beginning,"},{"line_number":5847,"context_line":"                        period_ending, host\u003dNone, state\u003dNone, session\u003dNone):"},{"line_number":5848,"context_line":"    values \u003d {\u0027period_beginning\u0027: period_beginning,"},{"line_number":5849,"context_line":"              \u0027period_ending\u0027: period_ending}"},{"line_number":5850,"context_line":"    values \u003d convert_objects_related_datetimes(values, *values.keys())"},{"line_number":5851,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_06e328da","line":5848,"updated":"2015-06-11 09:02:39.000000000","message":"Can you please explain why we are doing this change?","commit_id":"a06fbf5f4853676c90354b40d5f4e2ee86391df2"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"fb968d48b7e4d23aa8742231eb20c376b520860c","unresolved":false,"context_lines":[{"line_number":5845,"context_line":""},{"line_number":5846,"context_line":"def _task_log_get_query(context, task_name, period_beginning,"},{"line_number":5847,"context_line":"                        period_ending, host\u003dNone, state\u003dNone, session\u003dNone):"},{"line_number":5848,"context_line":"    values \u003d {\u0027period_beginning\u0027: period_beginning,"},{"line_number":5849,"context_line":"              \u0027period_ending\u0027: period_ending}"},{"line_number":5850,"context_line":"    values \u003d convert_objects_related_datetimes(values, *values.keys())"},{"line_number":5851,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_1cd47b45","line":5848,"in_reply_to":"3afb71cf_06e328da","updated":"2015-06-11 20:17:54.000000000","message":"The datetime parameters the new object will receive gets serialized when the objects framework remotes the calls, so must be converted back to datetimes here.","commit_id":"a06fbf5f4853676c90354b40d5f4e2ee86391df2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f40b507e477d415ff74516ea38c0ff0ad6bc3bd","unresolved":false,"context_lines":[{"line_number":5843,"context_line":"                        period_ending, host\u003dNone, state\u003dNone, session\u003dNone):"},{"line_number":5844,"context_line":"    values \u003d {\u0027period_beginning\u0027: period_beginning,"},{"line_number":5845,"context_line":"              \u0027period_ending\u0027: period_ending}"},{"line_number":5846,"context_line":"    values \u003d convert_objects_related_datetimes(values, *values.keys())"},{"line_number":5847,"context_line":""},{"line_number":5848,"context_line":"    query \u003d model_query(context, models.TaskLog, session\u003dsession).\\"},{"line_number":5849,"context_line":"                     filter_by(task_name\u003dtask_name).\\"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_4b2e8dfb","line":5846,"range":{"start_line":5846,"start_character":13,"end_line":5846,"end_character":46},"updated":"2015-07-17 16:24:14.000000000","message":"I don\u0027t like this here, but it follows the pattern, so thats all good.","commit_id":"e3a9ad932bf86cc4cb6a98667cfa9d7354e60440"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9f40b507e477d415ff74516ea38c0ff0ad6bc3bd","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"            return instances"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        self.flags(instance_usage_audit\u003dTrue)"},{"line_number":1173,"context_line":"        self.stubs.Set(objects.TaskLog, \u0027get\u0027, fake_task_log)"},{"line_number":1174,"context_line":"        self.stubs.Set(objects.InstanceList,"},{"line_number":1175,"context_line":"                       \u0027get_active_by_window_joined\u0027, fake_get)"},{"line_number":1176,"context_line":"        self.stubs.Set(objects.TaskLog, \u0027begin_task\u0027, fake_task_log)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_8b1b35ca","line":1173,"updated":"2015-07-17 16:24:14.000000000","message":"I feel like we should test more of what is done on the tasklog object really, but not enough to delay this patch now.","commit_id":"e3a9ad932bf86cc4cb6a98667cfa9d7354e60440"}]}