)]}'
{"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"dcdc898395740227c1cb8a2565212144e6c0f3ec","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                fakelibvirt.VIR_NODE_CPU_STATS_ALL_CPUS, 0)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def test_write_instance_config(self):"},{"line_number":832,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":833,"context_line":"            mock_conn().defineXML.return_value \u003d \"dom\""},{"line_number":834,"context_line":"            self.assertEqual(\"dom\", self.host.write_instance_config(\"domxml\"))"},{"line_number":835,"context_line":"            mock_conn().defineXML.assert_called_once_with(\"domxml\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ad32947_c4816391","line":832,"updated":"2015-04-28 12:44:37.000000000","message":"Instead of doing nested contexts, just annotate the test with  @mock.patch.object(fakelibvirt.virConnect, \"defineXML\")","commit_id":"f6d6ae5661bb33b0d7be809fccf8d8921a2d0b34"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dc722bb81989ea36eeeaf7c35b1a0e5425589ead","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                fakelibvirt.VIR_NODE_CPU_STATS_ALL_CPUS, 0)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def test_write_instance_config(self):"},{"line_number":832,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":833,"context_line":"            mock_conn().defineXML.return_value \u003d \"dom\""},{"line_number":834,"context_line":"            self.assertEqual(\"dom\", self.host.write_instance_config(\"domxml\"))"},{"line_number":835,"context_line":"            mock_conn().defineXML.assert_called_once_with(\"domxml\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ad32947_1ad696c5","line":832,"in_reply_to":"7ad32947_c4816391","updated":"2015-04-28 13:19:24.000000000","message":"Done","commit_id":"f6d6ae5661bb33b0d7be809fccf8d8921a2d0b34"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"dcdc898395740227c1cb8a2565212144e6c0f3ec","unresolved":false,"context_lines":[{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def test_write_instance_config(self):"},{"line_number":832,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":833,"context_line":"            mock_conn().defineXML.return_value \u003d \"dom\""},{"line_number":834,"context_line":"            self.assertEqual(\"dom\", self.host.write_instance_config(\"domxml\"))"},{"line_number":835,"context_line":"            mock_conn().defineXML.assert_called_once_with(\"domxml\")"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ad32947_644f2f93","line":833,"updated":"2015-04-28 12:44:37.000000000","message":"The API should return a fakelibvirt.virDomain instance rather than a string.","commit_id":"f6d6ae5661bb33b0d7be809fccf8d8921a2d0b34"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"dc722bb81989ea36eeeaf7c35b1a0e5425589ead","unresolved":false,"context_lines":[{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def test_write_instance_config(self):"},{"line_number":832,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":833,"context_line":"            mock_conn().defineXML.return_value \u003d \"dom\""},{"line_number":834,"context_line":"            self.assertEqual(\"dom\", self.host.write_instance_config(\"domxml\"))"},{"line_number":835,"context_line":"            mock_conn().defineXML.assert_called_once_with(\"domxml\")"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ad32947_fa02ba3d","line":833,"in_reply_to":"7ad32947_644f2f93","updated":"2015-04-28 13:19:24.000000000","message":"Yeah...","commit_id":"f6d6ae5661bb33b0d7be809fccf8d8921a2d0b34"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0f60c43e0cb8e57f543c4ada907a5e2a7d4817e2","unresolved":false,"context_lines":[{"line_number":940,"context_line":"        stats[\"frequency\"] \u003d self.get_cpu_frequency()"},{"line_number":941,"context_line":"        return stats"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def define_xml(self, xml):"},{"line_number":944,"context_line":"        \"\"\"Defines a domain, but does not start it.\"\"\""},{"line_number":945,"context_line":"        return self.get_connection().defineXML(xml)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abe1de1_fd941fe9","line":943,"updated":"2015-04-27 09:27:42.000000000","message":"The libvirt API name is somewhat bizarre really. How about we call this \u0027write_instance_config\u0027 to make it a bit more obvious what it does. Also, document the return value type here too.","commit_id":"bd5384b332877fd227b6ccf5d01a3c8d4fcae704"}]}