)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"bcdea3fe22b2f3270f146da64bd9c13ac064fd8d","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        if self.apic:"},{"line_number":633,"context_line":"            features \u003d etree.Element(\"features\")"},{"line_number":634,"context_line":"            features.append(etree.Element(\"apic\"))"},{"line_number":635,"context_line":"            root.append(features)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def _format_devices(self, root):"},{"line_number":638,"context_line":"        if len(self.devices) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F8ww%3D","line":635,"updated":"2012-12-05 14:06:10.000000000","message":"This code is wrong. If both \u0027acpi\u0027 and \u0027apic\u0027 are set, you are duplicating the \u003cfeatures\u003e XML thus\n\n\u003cfeatures\u003e\n  \u003cacpi/\u003e\n\u003c/features\u003e\n\u003cfeatures\u003e\n  \u003capic/\u003e\n\u003c/features\u003e\n\nWhereas it should be\n\n\u003cfeatures\u003e\n  \u003cacpi/\u003e\n  \u003capic/\u003e\n\u003c/features\u003e\n\nThis would have been identified if you added a test case to  test_libvirt_config.py when making this change.","commit_id":"7f98abbb3b7def2a53e1edfbca5cc732fb939705"}]}