)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nha Pham \u003cphqnha@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-17 02:51:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Encrypted iSCSI volume has name too long"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_16a0cdf3","line":7,"updated":"2015-04-20 03:48:53.000000000","message":"has too long of a name","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nha Pham \u003cphqnha@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-17 02:51:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Encrypted iSCSI volume has name too long"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_4dbc6b6c","line":7,"in_reply_to":"dac4157f_16a0cdf3","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Encrypted iSCSI volume has name too long"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_b6afe1e2","line":9,"updated":"2015-04-20 03:48:53.000000000","message":"The Cryptsetup command requires the device name to be less than 128 characters.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Encrypted iSCSI volume has name too long"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_0db6738a","line":9,"in_reply_to":"dac4157f_b6afe1e2","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."},{"line_number":13,"context_line":"if iqn name has more than 127 characters, raise the error immediately."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6771a5bbcc8a0fc27b668191085cc6707f5c37e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_76b9492e","line":12,"updated":"2015-04-20 03:48:53.000000000","message":"...falls back to use the iqn name.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cryptsetup command requires device name has to be less than 128 characters."},{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."},{"line_number":13,"context_line":"if iqn name has more than 127 characters, raise the error immediately."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6771a5bbcc8a0fc27b668191085cc6707f5c37e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_adad4733","line":12,"in_reply_to":"dac4157f_76b9492e","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."},{"line_number":13,"context_line":"if iqn name has more than 127 characters, raise the error immediately."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6771a5bbcc8a0fc27b668191085cc6707f5c37e7"},{"line_number":16,"context_line":"Closes-Bug: #1439855"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_3682b153","line":13,"updated":"2015-04-20 03:48:53.000000000","message":"If the iqn name has more than 127 characters, raise an error immediately.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":10,"context_line":"To fix this issue, this patch tries to use volume uuid for device name"},{"line_number":11,"context_line":"(connection[\u0027data\u0027][\u0027volume_id\u0027]), which is always less than 128 characters."},{"line_number":12,"context_line":"If volume uuid is not available, it fallbacks to use iqn name as old version."},{"line_number":13,"context_line":"if iqn name has more than 127 characters, raise the error immediately."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6771a5bbcc8a0fc27b668191085cc6707f5c37e7"},{"line_number":16,"context_line":"Closes-Bug: #1439855"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dac4157f_8daa8318","line":13,"in_reply_to":"dac4157f_3682b153","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"39de04825329c346c19045ecb644b3be8fb5eb53","unresolved":false,"context_lines":[{"line_number":12,"context_line":"If volume uuid is not available, it falls back to use iqn name as old version."},{"line_number":13,"context_line":"if iqn name has more than 128 characters, raise an error immediately."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Because device name is changed to uuid, we update the rootwrap filter pattern for"},{"line_number":16,"context_line":"\"ln\" command to match with the new name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6771a5bbcc8a0fc27b668191085cc6707f5c37e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa32b979_0711c65c","line":15,"updated":"2015-06-18 12:22:03.000000000","message":"Since it will fall back to IQN, should we really remove the rootwrap filter? I\u0027m not well-versed  about the rootwrap thing, so ignore if this doesn\u0027t make sense..","commit_id":"557a2666c928472820d13713312e9236eec51689"}],"etc/nova/rootwrap.d/compute.filters":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"sg_scan: CommandFilter, sg_scan, root"},{"line_number":209,"context_line":"ln: RegExpFilter, ln, root, ln, --symbolic, --force, /dev/mapper/ip-.*-iscsi-iqn.*, /dev/disk/by-path/ip-.*-iscsi-iqn.*"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# nova/volume/encryptors.py:"},{"line_number":212,"context_line":"# nova/virt/libvirt/dmcrypt.py:"},{"line_number":213,"context_line":"cryptsetup: CommandFilter, cryptsetup, root"},{"line_number":214,"context_line":"ln: CommandFilter, ln, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"dac4157f_f6c9d9ad","line":211,"updated":"2015-04-20 03:48:53.000000000","message":"Add # nova/volume/encryptors/cryptsetup.py","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19a4df701aa4f6a1df44b6ecdbaac4bf3a455acd","unresolved":false,"context_lines":[{"line_number":208,"context_line":"sg_scan: CommandFilter, sg_scan, root"},{"line_number":209,"context_line":"ln: RegExpFilter, ln, root, ln, --symbolic, --force, /dev/mapper/ip-.*-iscsi-iqn.*, /dev/disk/by-path/ip-.*-iscsi-iqn.*"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# nova/volume/encryptors.py:"},{"line_number":212,"context_line":"# nova/virt/libvirt/dmcrypt.py:"},{"line_number":213,"context_line":"cryptsetup: CommandFilter, cryptsetup, root"},{"line_number":214,"context_line":"ln: CommandFilter, ln, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"dac4157f_b1b00b8d","line":211,"in_reply_to":"dac4157f_f6c9d9ad","updated":"2015-04-20 08:27:50.000000000","message":"yes","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"# nova/volume/encryptors.py:"},{"line_number":212,"context_line":"# nova/virt/libvirt/dmcrypt.py:"},{"line_number":213,"context_line":"cryptsetup: CommandFilter, cryptsetup, root"},{"line_number":214,"context_line":"ln: CommandFilter, ln, root"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# nova/virt/xenapi/vm_utils.py:"},{"line_number":217,"context_line":"xenstore-read: CommandFilter, xenstore-read, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"dac4157f_b696c192","line":214,"updated":"2015-04-20 03:48:53.000000000","message":"This might be best as a separate patch. Did the rootwrap for ln in nova/volume/encryptors/cryptsetup.py ever work?  Or maybe at least mention why this change was necessary as part of the commit message.\n\nI noticed there is already a rootwrap for \"ln\" above under # nova/virt/libvirt/volume.py.  Please modify this entry to use a RegExpFilter like above instead of a CommandFilter.  It limits the exposure.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19a4df701aa4f6a1df44b6ecdbaac4bf3a455acd","unresolved":false,"context_lines":[{"line_number":211,"context_line":"# nova/volume/encryptors.py:"},{"line_number":212,"context_line":"# nova/virt/libvirt/dmcrypt.py:"},{"line_number":213,"context_line":"cryptsetup: CommandFilter, cryptsetup, root"},{"line_number":214,"context_line":"ln: CommandFilter, ln, root"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"# nova/virt/xenapi/vm_utils.py:"},{"line_number":217,"context_line":"xenstore-read: CommandFilter, xenstore-read, root"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"dac4157f_6d1a8f70","line":214,"in_reply_to":"dac4157f_b696c192","updated":"2015-04-20 08:27:50.000000000","message":"I\u0027m agreed with this comment.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"}],"nova/volume/encryptors/cryptsetup.py":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"2beff286056e97fd4e5ff736af23d6a28df245c1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # if cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 127:"},{"line_number":51,"context_line":"            raise exception.Invalid(_(\"device name %s is too long\") %"},{"line_number":52,"context_line":"                                      self.dev_name)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ab451fb_116e8cc9","line":50,"updated":"2015-04-17 08:01:58.000000000","message":"I have tried it support 128 characters","commit_id":"51b1fc3ebb755f8ce1818ca2368241ff5d506040"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":45,"context_line":"        if \u0027volume_id\u0027 in connection_info[\u0027data\u0027]:"},{"line_number":46,"context_line":"            self.dev_name \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":47,"context_line":"        # if cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 128:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dac4157f_9665fde2","line":47,"updated":"2015-04-20 03:48:53.000000000","message":"if we cannot....","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":45,"context_line":"        if \u0027volume_id\u0027 in connection_info[\u0027data\u0027]:"},{"line_number":46,"context_line":"            self.dev_name \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":47,"context_line":"        # if cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 128:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dac4157f_6d172fee","line":47,"in_reply_to":"dac4157f_9665fde2","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7157e1bead278996b93ded124b79c8b023c5b04a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":51,"context_line":"            raise exception.Invalid(_(\"device name %s is too long\") %"},{"line_number":52,"context_line":"                                      self.dev_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get_passphrase(self, key):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dac4157f_f66d59cd","line":51,"updated":"2015-04-20 03:48:53.000000000","message":"probably better to say, \"device name %s is larger than max length of 128.\"  Just stating too long requires the deployer to examine code to find the limit.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":15038,"name":"Nha Pham","email":"phqnha@gmail.com","username":"phqnha"},"change_message_id":"ef2961f7989b336239045df8522df16ce5a49414","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":51,"context_line":"            raise exception.Invalid(_(\"device name %s is too long\") %"},{"line_number":52,"context_line":"                                      self.dev_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get_passphrase(self, key):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dac4157f_4dd34b39","line":51,"in_reply_to":"dac4157f_f66d59cd","updated":"2015-04-20 08:51:46.000000000","message":"Done","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19a4df701aa4f6a1df44b6ecdbaac4bf3a455acd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        else:"},{"line_number":49,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":50,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":51,"context_line":"            raise exception.Invalid(_(\"device name %s is too long\") %"},{"line_number":52,"context_line":"                                      self.dev_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get_passphrase(self, key):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dac4157f_51f9af4c","line":51,"in_reply_to":"dac4157f_f66d59cd","updated":"2015-04-20 08:27:50.000000000","message":"You can create a specific exception here.","commit_id":"299f2ec07e772cf7752a6e0efe87eeb824224c03"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"39de04825329c346c19045ecb644b3be8fb5eb53","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(CryptsetupEncryptor, self).__init__(connection_info, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # the device\u0027s path as given to libvirt -- e.g., /dev/disk/by-path/..."},{"line_number":41,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # the device\u0027s actual path on the compute host -- e.g., /dev/sd_"},{"line_number":44,"context_line":"        self.dev_path \u003d os.path.realpath(self.symlink_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_07e786ac","line":41,"updated":"2015-06-18 12:22:03.000000000","message":"as symlink_path is only used in the \u0027else\u0027 block, it could be moved there. Improves readability too.","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"447c3ea5f17ce0596cd954fadcddfa09228f9738","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(CryptsetupEncryptor, self).__init__(connection_info, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        # the device\u0027s path as given to libvirt -- e.g., /dev/disk/by-path/..."},{"line_number":41,"context_line":"        self.symlink_path \u003d connection_info[\u0027data\u0027][\u0027device_path\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # the device\u0027s actual path on the compute host -- e.g., /dev/sd_"},{"line_number":44,"context_line":"        self.dev_path \u003d os.path.realpath(self.symlink_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_734726bc","line":41,"in_reply_to":"fa32b979_07e786ac","updated":"2015-07-09 14:42:20.000000000","message":"It\u0027s actually used in subclasses, too: http://git.openstack.org/cgit/openstack/nova/tree/nova/volume/encryptors/luks.py#n120","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"39de04825329c346c19045ecb644b3be8fb5eb53","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # the device\u0027s actual path on the compute host -- e.g., /dev/sd_"},{"line_number":44,"context_line":"        self.dev_path \u003d os.path.realpath(self.symlink_path)"},{"line_number":45,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":46,"context_line":"        if (\u0027volume_id\u0027 in connection_info[\u0027data\u0027] and"},{"line_number":47,"context_line":"                uuidutils.is_uuid_like(connection_info[\u0027data\u0027][\u0027volume_id\u0027])):"},{"line_number":48,"context_line":"            self.dev_name \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":49,"context_line":"        # if we cannot get the uuid of device, use its iSCSI iqn name"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_6718d2d3","line":46,"updated":"2015-06-18 12:22:03.000000000","message":"Minor nit: we\u0027re doing dictionary lookup thrice here in three consecutive lines. A variable could be created and referenced three times","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"883cfb609967f5f8b61eef652a25ea2d37bd2d1d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # the device\u0027s actual path on the compute host -- e.g., /dev/sd_"},{"line_number":44,"context_line":"        self.dev_path \u003d os.path.realpath(self.symlink_path)"},{"line_number":45,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":46,"context_line":"        if (\u0027volume_id\u0027 in connection_info[\u0027data\u0027] and"},{"line_number":47,"context_line":"                uuidutils.is_uuid_like(connection_info[\u0027data\u0027][\u0027volume_id\u0027])):"},{"line_number":48,"context_line":"            self.dev_name \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":49,"context_line":"        # if we cannot get the uuid of device, use its iSCSI iqn name"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_2fb02b8b","line":46,"in_reply_to":"fa32b979_6718d2d3","updated":"2016-04-22 10:46:02.000000000","message":"Done","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"55e96d240c793292384e2bdcfb49539891adb9e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            self.dev_name \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":49,"context_line":"        # if we cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":52,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":53,"context_line":"            raise exception.Invalid(_(\u0027device name %s is larger than max \u0027"},{"line_number":54,"context_line":"                                      \u0027length of 128\u0027) % self.dev_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_fc8c1837","line":51,"updated":"2015-05-06 07:34:24.000000000","message":"So we are still able to run command on devices that use iqn name and for those with more than 128 characters they probably failed to start.","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"39de04825329c346c19045ecb644b3be8fb5eb53","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":52,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":53,"context_line":"            raise exception.Invalid(_(\u0027device name %s is larger than max \u0027"},{"line_number":54,"context_line":"                                      \u0027length of 128\u0027) % self.dev_name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_passphrase(self, key):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_87763604","line":53,"updated":"2015-06-18 12:22:03.000000000","message":"\u0027d\u0027 of device can be capital. \u0027Length of 128\u0027 can be converted to \u0027length of 128 characters\u0027.","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"883cfb609967f5f8b61eef652a25ea2d37bd2d1d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"},{"line_number":52,"context_line":"        if len(self.dev_name) \u003e 128:"},{"line_number":53,"context_line":"            raise exception.Invalid(_(\u0027device name %s is larger than max \u0027"},{"line_number":54,"context_line":"                                      \u0027length of 128\u0027) % self.dev_name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_passphrase(self, key):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_6faa231b","line":53,"in_reply_to":"fa32b979_87763604","updated":"2016-04-22 10:46:02.000000000","message":"Done","commit_id":"557a2666c928472820d13713312e9236eec51689"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1576798529a31cd5e114a5b232a300a6f9607e91","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # the case of libvirt network volume drivers."},{"line_number":42,"context_line":"        data \u003d connection_info[\u0027data\u0027]"},{"line_number":43,"context_line":"        device_path \u003d data.get(\u0027device_path\u0027)"},{"line_number":44,"context_line":"        volume_id \u003d data.get(\u0027volume_id\u0027)"},{"line_number":45,"context_line":"        if not device_path:"},{"line_number":46,"context_line":"            raise exception.VolumeEncryptionNotSupported("},{"line_number":47,"context_line":"                volume_id\u003dvolume_id or connection_info.get(\u0027serial\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_6e7f17e0","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":41},"updated":"2017-06-02 15:24:57.000000000","message":"This should include \"or connection_info.get(\u0027serial\u0027)\"","commit_id":"e27cbd7fa970cf568b3b8797220f801c725535b8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"44267c8d832b73eecfbb3df4595b93955c1dd81c","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":56,"context_line":"        if uuidutils.is_uuid_like(volume_id):"},{"line_number":57,"context_line":"            self.dev_name \u003d volume_id"},{"line_number":58,"context_line":"        # if we cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_d0e610af","line":57,"updated":"2016-07-06 08:33:01.000000000","message":"Bit worried this means we break old encrypted connections?\n\nIf we reboot nova-compute, and the VM is still running, we probably need to use the old dev_name still, when we close that volume connection at a later date.\n\nMaybe we should double check to see if either of the options are currently in use?","commit_id":"e27cbd7fa970cf568b3b8797220f801c725535b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"774657fc8a1c4113f84ad4a0b0ee1751bc511861","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # a unique name for the volume -- e.g., the uuid of the device"},{"line_number":56,"context_line":"        if uuidutils.is_uuid_like(volume_id):"},{"line_number":57,"context_line":"            self.dev_name \u003d volume_id"},{"line_number":58,"context_line":"        # if we cannot get the uuid of device, use its iSCSI iqn name"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            self.dev_name \u003d self.symlink_path.split(\u0027/\u0027)[-1]"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_ce4503b6","line":57,"in_reply_to":"1aa78d24_d0e610af","updated":"2017-06-02 15:23:35.000000000","message":"Agree, could be handled like in this change:\n\nI01a3104025a9c479e40933ca24024355df9dfb8b","commit_id":"e27cbd7fa970cf568b3b8797220f801c725535b8"}]}