)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"84ab9b650bad444960b928f227c7ae72a2cadf02","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: make _get_instance_disk_info conservative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We want to make sure we never try to get the size of an attached volume"},{"line_number":10,"context_line":"when doing _get_instance_disk_info (as this can cause issues when"},{"line_number":11,"context_line":"gathering available resources)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"libvirt\u0027s get_available_resources will call upon it to determine the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ab451fb_20d6bbc5","line":10,"updated":"2015-04-17 19:03:03.000000000","message":"Issues being lvm locking up and making everything timeout since we\u0027re holding the \u0027compute_resources\u0027 lock in the resource tracker?","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5770a9deaabcebec2b5593d1cde8261a6c51524c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"volume or not."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ifb20655c32896b640672917e3840add81b136780"},{"line_number":23,"context_line":"Partial-bug: #1445021"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ab451fb_2088fbe6","line":23,"updated":"2015-04-17 19:00:58.000000000","message":"This is also partial/related to bug 1371677 right?  Sounds very similar to the discussion in that bug with danpb.","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3bd4e64f1eeff495e91f96aae1691bbbaa8a549","unresolved":false,"context_lines":[{"line_number":6787,"context_line":"        self.assertEqual(info[1][\u0027over_committed_disk_size\u0027], 18146236825)"},{"line_number":6788,"context_line":""},{"line_number":6789,"context_line":"    def test_get_instance_disk_info_no_bdinfo_passed(self):"},{"line_number":6790,"context_line":"        # NOTE(ndipanov): _get_disk_overcomitted_size_total calls this method"},{"line_number":6791,"context_line":"        # without access to Nova\u0027s block device information. We want to make"},{"line_number":6792,"context_line":"        # sure that we guess volumes mostly correctly in that case as well"},{"line_number":6793,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_3b170c53","line":6790,"updated":"2015-04-17 19:38:10.000000000","message":"nit: s/_get_disk_overcomitted_size_total/_get_disk_over_committed_size_total/","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3bd4e64f1eeff495e91f96aae1691bbbaa8a549","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"                    \"\u003cdisk type\u003d\u0027file\u0027\u003e\u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027raw\u0027/\u003e\""},{"line_number":6797,"context_line":"                    \"\u003csource file\u003d\u0027/test/disk\u0027/\u003e\""},{"line_number":6798,"context_line":"                    \"\u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e\u003c/disk\u003e\""},{"line_number":6799,"context_line":"                    \"\u003cdisk type\u003d\u0027block\u0027\u003e\u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027raw\u0027/\u003e\""},{"line_number":6800,"context_line":"                    \"\u003csource file\u003d\u0027/fake/path/to/volume1\u0027/\u003e\""},{"line_number":6801,"context_line":"                    \"\u003ctarget dev\u003d\u0027vdb\u0027 bus\u003d\u0027virtio\u0027/\u003e\u003c/disk\u003e\""},{"line_number":6802,"context_line":"                    \"\u003c/devices\u003e\u003c/domain\u003e\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_56206d9b","line":6799,"updated":"2015-04-17 19:38:10.000000000","message":"And because we don\u0027t have block_device_info passed in this is ignored.","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"078ea1f4e69a8c90c2f7d186c496585721987d64","unresolved":false,"context_lines":[{"line_number":6059,"context_line":"            if disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":6060,"context_line":"                dk_size \u003d int(os.path.getsize(path))"},{"line_number":6061,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":6062,"context_line":"                    dk_size \u003d lvm.get_volume_size(path)"},{"line_number":6063,"context_line":"            else:"},{"line_number":6064,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to\u0027"},{"line_number":6065,"context_line":"                          \u0027determine if volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_6fca79a3","line":6062,"updated":"2015-04-17 16:18:02.000000000","message":"nit, this indent doesn\u0027t look right","commit_id":"c62b282c4f8d57eb7adb29019ee929388f310a1b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e33a94eef3b02809dcff7e0df86e91628385c30d","unresolved":false,"context_lines":[{"line_number":6059,"context_line":"            if disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":6060,"context_line":"                dk_size \u003d int(os.path.getsize(path))"},{"line_number":6061,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":6062,"context_line":"                    dk_size \u003d lvm.get_volume_size(path)"},{"line_number":6063,"context_line":"            else:"},{"line_number":6064,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to\u0027"},{"line_number":6065,"context_line":"                          \u0027determine if volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_f503f6b6","line":6062,"in_reply_to":"3ab451fb_6fca79a3","updated":"2015-04-17 17:06:41.000000000","message":"Hardly a nit; consistent indentation is part of Python.","commit_id":"c62b282c4f8d57eb7adb29019ee929388f310a1b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e34629cee7d842811313483391d6aaf674065fdc","unresolved":false,"context_lines":[{"line_number":6059,"context_line":"            if disk_type \u003d\u003d \u0027file\u0027:"},{"line_number":6060,"context_line":"                dk_size \u003d int(os.path.getsize(path))"},{"line_number":6061,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":6062,"context_line":"                    dk_size \u003d lvm.get_volume_size(path)"},{"line_number":6063,"context_line":"            else:"},{"line_number":6064,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to\u0027"},{"line_number":6065,"context_line":"                          \u0027determine if volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_9d9058ee","line":6062,"in_reply_to":"3ab451fb_f503f6b6","updated":"2015-04-17 18:36:38.000000000","message":"Well technically this is valid and correct indentation for Python - but I will fix it of course :)","commit_id":"c62b282c4f8d57eb7adb29019ee929388f310a1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c99ee90a39a247d13b133413cbc6e57c7d9a988","unresolved":false,"context_lines":[{"line_number":4904,"context_line":"        # data format needs to be standardized across drivers"},{"line_number":4905,"context_line":"        data[\"cpu_info\"] \u003d jsonutils.dumps(self._get_cpu_info())"},{"line_number":4906,"context_line":""},{"line_number":4907,"context_line":"        disk_free_gb \u003d disk_info_dict[\u0027free\u0027]"},{"line_number":4908,"context_line":"        disk_over_committed \u003d self._get_disk_over_committed_size_total()"},{"line_number":4909,"context_line":"        available_least \u003d disk_free_gb * units.Gi - disk_over_committed"},{"line_number":4910,"context_line":"        data[\u0027disk_available_least\u0027] \u003d available_least / units.Gi"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_a0a76b4e","line":4907,"updated":"2015-04-17 19:08:01.000000000","message":"called from here","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c99ee90a39a247d13b133413cbc6e57c7d9a988","unresolved":false,"context_lines":[{"line_number":6061,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":6062,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"},{"line_number":6063,"context_line":"            else:"},{"line_number":6064,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to \u0027"},{"line_number":6065,"context_line":"                          \u0027determine if volume\u0027,"},{"line_number":6066,"context_line":"                          {\u0027path\u0027: path, \u0027target\u0027: target})"},{"line_number":6067,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_20491b8c","line":6064,"updated":"2015-04-17 19:08:01.000000000","message":"Would it make sense to log the instance_name in here also?","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7dd114297ec6fe6d993f6a820678f9cb1c7da769","unresolved":false,"context_lines":[{"line_number":6061,"context_line":"            elif disk_type \u003d\u003d \u0027block\u0027 and block_device_info:"},{"line_number":6062,"context_line":"                dk_size \u003d lvm.get_volume_size(path)"},{"line_number":6063,"context_line":"            else:"},{"line_number":6064,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) - unable to \u0027"},{"line_number":6065,"context_line":"                          \u0027determine if volume\u0027,"},{"line_number":6066,"context_line":"                          {\u0027path\u0027: path, \u0027target\u0027: target})"},{"line_number":6067,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_b65211dc","line":6064,"in_reply_to":"3ab451fb_20491b8c","updated":"2015-04-17 19:42:14.000000000","message":"I guess we don\u0027t in the other debug log messages here.","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c99ee90a39a247d13b133413cbc6e57c7d9a988","unresolved":false,"context_lines":[{"line_number":6110,"context_line":"        for dom in self._host.list_instance_domains():"},{"line_number":6111,"context_line":"            try:"},{"line_number":6112,"context_line":"                xml \u003d dom.XMLDesc(0)"},{"line_number":6113,"context_line":"                disk_infos \u003d jsonutils.loads("},{"line_number":6114,"context_line":"                        self._get_instance_disk_info(dom.name(), xml))"},{"line_number":6115,"context_line":"                for info in disk_infos:"},{"line_number":6116,"context_line":"                    disk_over_committed_size +\u003d int("}],"source_content_type":"text/x-python","patch_set":3,"id":"3ab451fb_406d4703","line":6113,"updated":"2015-04-17 19:08:01.000000000","message":"looping here","commit_id":"968fd2cecba7db3ab7029ae10a6c6b24fa36f116"}]}