)]}'
{"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"f9a6df6c22a21c8c96f3c630d5afefc0d33a19dc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    TIMEOUT_SCALING_FACTOR \u003d 2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    snake_walk \u003d False"},{"line_number":73,"context_line":"    downgrade \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_fbac0bef","line":73,"updated":"2015-04-20 15:00:35.000000000","message":"nit: these don\u0027t seem to be used for anything any more, or at least could be moved to be local to the only function that does refer to them.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"a7e7d61d7aeadeac58539e0bf80e9c7127fd168f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    TIMEOUT_SCALING_FACTOR \u003d 2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    snake_walk \u003d False"},{"line_number":73,"context_line":"    downgrade \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_d1b6ad3c","line":73,"in_reply_to":"dac4157f_2d5c7c24","updated":"2015-04-21 06:30:28.000000000","message":"A todo or comment here would be useful.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2d63f57ba1993ce891e48e86fe924d758c4965ef","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    TIMEOUT_SCALING_FACTOR \u003d 2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    snake_walk \u003d False"},{"line_number":73,"context_line":"    downgrade \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_d23481df","line":73,"in_reply_to":"dac4157f_7b17dba3","updated":"2015-04-20 18:07:13.000000000","message":"It would be nice to have a comment explaining that.  I would not expect anything outside of Nova to be relying on data defined in a test class.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"40380b753db641e47011361afc1450ea03fbfb7b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    TIMEOUT_SCALING_FACTOR \u003d 2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    snake_walk \u003d False"},{"line_number":73,"context_line":"    downgrade \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_2d5c7c24","line":73,"in_reply_to":"dac4157f_d23481df","updated":"2015-04-20 18:31:28.000000000","message":"I totally misunderstood this exchange.  I thought Sean was saying that something expected these to be defined on the class when really they\u0027re just passed to an oslo.db mixin.  This is a prime candidate for a later cleanup but not confusing or in need of a comment.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"68ad48771b9c98ffdf010ab3447e5ba268578a22","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    TIMEOUT_SCALING_FACTOR \u003d 2"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    snake_walk \u003d False"},{"line_number":73,"context_line":"    downgrade \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_7b17dba3","line":73,"in_reply_to":"dac4157f_fbac0bef","updated":"2015-04-20 15:06:01.000000000","message":"These are passed to a mixin that we don\u0027t control","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"dbe25a0161b17f7159aff9b19e9ef688ff25f872","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        super(NovaMigrationsCheckers, self).migrate_up(version, with_data)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_walk_versions(self):"},{"line_number":197,"context_line":"        self.walk_versions(self.snake_walk, self.downgrade)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _check_227(self, engine, data):"},{"line_number":200,"context_line":"        table \u003d oslodbutils.get_table(engine, \u0027project_user_quotas\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_325f3d74","line":197,"updated":"2015-04-20 18:22:05.000000000","message":"This is where snake_walk and downgrade are used, def walkversions is defined on the mix in. Eventually we can get rid of these in oslo.db.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"cff5406c0f144aac956373f250f240bfc53d13bd","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        super(NovaMigrationsCheckers, self).migrate_up(version, with_data)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_walk_versions(self):"},{"line_number":197,"context_line":"        self.walk_versions(self.snake_walk, self.downgrade)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _check_227(self, engine, data):"},{"line_number":200,"context_line":"        table \u003d oslodbutils.get_table(engine, \u0027project_user_quotas\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_e4ae8c97","line":197,"in_reply_to":"dac4157f_325f3d74","updated":"2015-04-21 08:01:37.000000000","message":"We could call this as:\n\n    self.walk_versions(snake_walk\u003dFalse, downgrade\u003dFalse)\n\nlike in alaski\u0027s followup patch. I think the confusion about lines 72/73 speaks for itself.","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"a7e7d61d7aeadeac58539e0bf80e9c7127fd168f","unresolved":false,"context_lines":[{"line_number":729,"context_line":"                    if \u0027def downgrade(\u0027 in line:"},{"line_number":730,"context_line":"                        has_downgrade \u003d True"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"                if has_upgrade and has_downgrade:"},{"line_number":733,"context_line":"                    fname \u003d os.path.basename(path)"},{"line_number":734,"context_line":"                    includes_downgrade.append(fname)"},{"line_number":735,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_f1b9b12f","line":732,"updated":"2015-04-21 06:30:28.000000000","message":"I don\u0027t know if we need has_upgrade checked here. We want to stop any downgrades from existing with this test surely?","commit_id":"747435245232df7730bdc67006b3974bc9ba9a81"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0f6049596edd29317241f8e055681336aa9c7c9e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        super(NovaMigrationsCheckers, self).migrate_up(version, with_data)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def test_walk_versions(self):"},{"line_number":194,"context_line":"        self.walk_versions(snake_walk\u003dFalse, downgrade\u003dFalse)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _check_227(self, engine, data):"},{"line_number":197,"context_line":"        table \u003d oslodbutils.get_table(engine, \u0027project_user_quotas\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dac4157f_6d16a6a8","line":194,"updated":"2015-04-22 11:57:02.000000000","message":"thanks.","commit_id":"e2e846f74b057f5f3ed72312b0b0ccf6ef97add2"}]}