)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c28b6598b44a5de168ce70e9d60a595aa9bb3f80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-12 05:57:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change libvirt qulity warning function and comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Got following error when start my compute node"},{"line_number":10,"context_line":"Change some function name to align its function behavior"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dac4157f_7d7beff5","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":21},"updated":"2015-04-22 15:01:35.000000000","message":"\"quality\" is misspelled.","commit_id":"62a841f7ee7e260f0d2efa2e36d770cb6566226d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b888cf1aefe082ddc883c91c7a4583927b177d3f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-12 05:57:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change libvirt qulity warning function and comment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Got following error when start my compute node"},{"line_number":10,"context_line":"Change some function name to align its function behavior"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab921fb_79c81175","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":21},"in_reply_to":"dac4157f_7d7beff5","updated":"2015-04-23 05:27:09.000000000","message":"please prefix this with libvirt:","commit_id":"62a841f7ee7e260f0d2efa2e36d770cb6566226d"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"99b0ca35b872faf18dd49901824df84fa3d19416","unresolved":false,"context_lines":[{"line_number":14,"context_line":"caps \u003d self._host.get_capabilities()"},{"line_number":15,"context_line":"File \"/usr/local/lib/python2.7/dist-packages/libvirt.py\", line 3153, in baselineCPU"},{"line_number":16,"context_line":"if ret is None: raise libvirtError (\u0027virConnectBaselineCPU() failed\u0027, conn\u003dself)"},{"line_number":17,"context_line":"libvirtError: XML error: Missing CPU model name"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0f72be3aaf9b122e3ed394fe82b9bdc272a1dc82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dac4157f_0c296737","line":17,"updated":"2015-04-22 13:48:32.000000000","message":"I really don\u0027t think it\u0027s a good idea to have backtrace in the commit message.\nHow do it help to understand what are you fixing here?\nJust write it in the bug and refer to it here, if you think this is helpful.","commit_id":"62a841f7ee7e260f0d2efa2e36d770cb6566226d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c28b6598b44a5de168ce70e9d60a595aa9bb3f80","unresolved":false,"context_lines":[{"line_number":14,"context_line":"caps \u003d self._host.get_capabilities()"},{"line_number":15,"context_line":"File \"/usr/local/lib/python2.7/dist-packages/libvirt.py\", line 3153, in baselineCPU"},{"line_number":16,"context_line":"if ret is None: raise libvirtError (\u0027virConnectBaselineCPU() failed\u0027, conn\u003dself)"},{"line_number":17,"context_line":"libvirtError: XML error: Missing CPU model name"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0f72be3aaf9b122e3ed394fe82b9bdc272a1dc82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dac4157f_dd255b09","line":17,"in_reply_to":"dac4157f_0c296737","updated":"2015-04-22 15:01:35.000000000","message":"Agreed","commit_id":"62a841f7ee7e260f0d2efa2e36d770cb6566226d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c28b6598b44a5de168ce70e9d60a595aa9bb3f80","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        unknown. Currently, only qemu or kvm on intel 32- or 64-bit systems"},{"line_number":505,"context_line":"        is tested upstream."},{"line_number":506,"context_line":"        Also, during compute start, it might raise libvirtError which"},{"line_number":507,"context_line":"        stops the whole compute service."},{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":510,"context_line":"        hostarch \u003d caps.host.cpu.arch"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_3de697b0","line":507,"updated":"2015-04-22 15:01:35.000000000","message":"Where does it do this? If get_capabilities() is failing, that\u0027s a real problem (other than just a failure to connect or something).\n\nThis method was never intended to interrupt the startup based on checks, so naming it as such does not seem right to me. If we need to catch and handle something, let\u0027s do that.","commit_id":"62a841f7ee7e260f0d2efa2e36d770cb6566226d"}]}