)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"9ad3269ba4c62433268ff2e4f130843c3b295f38","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"                                                   instance[\u0027name\u0027],"},{"line_number":1775,"context_line":"                                                   \"kernel.rescue\")"},{"line_number":1776,"context_line":"                    if CONF.libvirt_type \u003d\u003d \"xen\":"},{"line_number":1777,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1778,"context_line":"                    else:"},{"line_number":1779,"context_line":"                        guest.os_cmdline \u003d \"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1780,"context_line":"                        root_device_name or \"/dev/vda\",)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F8e4%3D","line":1777,"updated":"2012-12-05 17:45:56.000000000","message":"This xen path looks clearly wrong to me.  How would a kernel select a root device given kernel parameters of only \"ro\"?\n\nWouldn\u0027t it be a better solution (although requiring some post-2005 kernel/intiramfs) to use root\u003dUUID\u003d\u003c\u003e ?  That would seem a generic solution to both xen and kvm assuming the rescue image has support for booting via UUID and the guest\u0027s disk does not have that UUID.\n\nDo you have access to the rescue disk at this point?","commit_id":"b496d2a10a34406dd1a77d7430c287a3ee43584a"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"86dca1f21d306db68c168c45f4471aa24a42af82","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"                                                   instance[\u0027name\u0027],"},{"line_number":1775,"context_line":"                                                   \"kernel.rescue\")"},{"line_number":1776,"context_line":"                    if CONF.libvirt_type \u003d\u003d \"xen\":"},{"line_number":1777,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1778,"context_line":"                    else:"},{"line_number":1779,"context_line":"                        guest.os_cmdline \u003d \"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1780,"context_line":"                        root_device_name or \"/dev/vda\",)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F5T4%3D","line":1777,"in_reply_to":"AAAAMX%2F%2F8e4%3D","updated":"2012-12-10 05:58:06.000000000","message":"to use uuid may be a good idea, but it\u0027s not to be sloved by this commit, now I don\u0027t have a xen testing environment.so can\u0027t test this, the cmdline for xen is just a copy of the following code.","commit_id":"b496d2a10a34406dd1a77d7430c287a3ee43584a"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d067043803265c5b99b416809ed8628757d8ad40","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"                    if CONF.libvirt_type \u003d\u003d \"xen\":"},{"line_number":1768,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1769,"context_line":"                    else:"},{"line_number":1770,"context_line":"                        guest.os_cmdline \u003d \"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1771,"context_line":"                        root_device_name or \"/dev/vda\",)"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"                if rescue.get(\u0027ramdisk_id\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F5PQ%3D","line":1770,"updated":"2012-12-10 07:45:40.000000000","message":"Maybe this would look much better\n\nguest.os_cmdline \u003d (\"root\u003d%s console\u003dttyS0\" %\n                    (root_device_name or \"/dev/vda\",))","commit_id":"60060f909fa6a792cab723da3e4a26234cfbe205"},{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"ba99c6ed2cdf5cd5d58e2ef650cdd5cbe2b14377","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1769,"context_line":"                    else:"},{"line_number":1770,"context_line":"                        guest.os_cmdline \u003d \"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1771,"context_line":"                        root_device_name or \"/dev/vda\",)"},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"                if rescue.get(\u0027ramdisk_id\u0027):"},{"line_number":1774,"context_line":"                    guest.os_initrd \u003d os.path.join(CONF.instances_path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F2h4%3D","line":1771,"updated":"2012-12-12 17:02:17.000000000","message":"It seems like you have bad indentation here.  I would have expected pep8 to complain.","commit_id":"60060f909fa6a792cab723da3e4a26234cfbe205"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"2b3bc10abf42f0209015370ac0c5a22a51ddc1eb","unresolved":false,"context_lines":[{"line_number":1784,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1785,"context_line":"                    else:"},{"line_number":1786,"context_line":"                        guest.os_cmdline \u003d (\"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1787,"context_line":"                            root_device_name or \"/dev/vda\",))"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"                if rescue.get(\u0027ramdisk_id\u0027):"},{"line_number":1790,"context_line":"                    guest.os_initrd \u003d os.path.join(CONF.instances_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F1LI%3D","line":1787,"updated":"2012-12-13 16:14:05.000000000","message":"The point of Zhongyue Luo\u0027s comment was to move the trailing \u0027(\u0027 on line 1786 to the beginning of line 1787.","commit_id":"04b523adcc5d6f0f2171a5efecc873b2766e801d"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"f2e186a5a510b987cbb2aabf5978f4e2daefe84d","unresolved":false,"context_lines":[{"line_number":1784,"context_line":"                        guest.os_cmdline \u003d \"ro\""},{"line_number":1785,"context_line":"                    else:"},{"line_number":1786,"context_line":"                        guest.os_cmdline \u003d (\"root\u003d%s console\u003dttyS0\" % ("},{"line_number":1787,"context_line":"                            root_device_name or \"/dev/vda\",))"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"                if rescue.get(\u0027ramdisk_id\u0027):"},{"line_number":1790,"context_line":"                    guest.os_initrd \u003d os.path.join(CONF.instances_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F0PY%3D","line":1787,"in_reply_to":"AAAAMX%2F%2F1LI%3D","updated":"2012-12-14 07:49:59.000000000","message":"got it,thanks Kevin.","commit_id":"04b523adcc5d6f0f2171a5efecc873b2766e801d"}]}