)]}'
{"nova/tests/functional/v3/test_extension_info.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1e9a88b6ad4914cb2344b2662f2b940840258d32","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        response \u003d self._do_get(\u0027extensions\u0027)"},{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if(self._test \u003d\u003d \u0027v2\u0027):"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-get-resp\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_720ec335","line":46,"updated":"2015-05-07 05:33:13.000000000","message":"nit:\n\n if self._test \u003d\u003d \u0027v2\u0027:\n\nseems enough for here.","commit_id":"0c696d88cffdb94ba76dee0bc613532c647b3a18"},{"author":{"_account_id":13663,"name":"heijlong","email":"jhei@redhat.com","username":"parklong"},"change_message_id":"fbae1a670e981780514470255812c68d99cbd98d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        response \u003d self._do_get(\u0027extensions\u0027)"},{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if(self._test \u003d\u003d \u0027v2\u0027):"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-get-resp\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9af37de9_f1bafbbf","line":46,"in_reply_to":"1aca2d91_720ec335","updated":"2015-05-11 02:42:18.000000000","message":"Done","commit_id":"0c696d88cffdb94ba76dee0bc613532c647b3a18"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1e9a88b6ad4914cb2344b2662f2b940840258d32","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if(self._test \u003d\u003d \u0027v2\u0027):"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-get-resp\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_92095f2f","line":47,"updated":"2015-05-07 05:33:13.000000000","message":"I understand we need the separated templates for each v2 and v2.1 because these response of \"list extensions\" API are different. However, this filename difference seems to make confuse because the filename doesn\u0027t contain which version.\n\nSo how about renaming extensions-get-resp.json to extensions-list-resp-v2.json to explain it ?","commit_id":"0c696d88cffdb94ba76dee0bc613532c647b3a18"},{"author":{"_account_id":13663,"name":"heijlong","email":"jhei@redhat.com","username":"parklong"},"change_message_id":"fbae1a670e981780514470255812c68d99cbd98d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if(self._test \u003d\u003d \u0027v2\u0027):"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-get-resp\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9af37de9_91ca8f4e","line":47,"in_reply_to":"1aca2d91_92095f2f","updated":"2015-05-11 02:42:18.000000000","message":"Done","commit_id":"0c696d88cffdb94ba76dee0bc613532c647b3a18"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9031566f1b9c6beaf2f15a6d7102b0b80ed463e1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if self._test \u003d\u003d \u0027v2\u0027:"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-list-resp-v2\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_816a4919","line":47,"updated":"2015-05-14 09:02:46.000000000","message":"But /extension output should be same for both after https://review.openstack.org/#/c/138599/\n\nI think single file should work which reflect no changes between v2 and v2.1 response","commit_id":"ab3c8fd026f948f1ea656c547a33c70719539617"},{"author":{"_account_id":13663,"name":"heijlong","email":"jhei@redhat.com","username":"parklong"},"change_message_id":"0678c3fb448a999e90a6a2e37aaa2a5bcc68a7dd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":45,"context_line":"        template \u003d \u0027extensions-list-resp\u0027"},{"line_number":46,"context_line":"        if self._test \u003d\u003d \u0027v2\u0027:"},{"line_number":47,"context_line":"            template \u003d \u0027extensions-list-resp-v2\u0027"},{"line_number":48,"context_line":"        self._verify_response(template, subs, response, 200)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_2eff9268","line":47,"in_reply_to":"7a016987_816a4919","updated":"2015-06-09 06:44:08.000000000","message":"hello Ghanshyam\n\nI think https://review.openstack.org/#/c/138599/ ignored \"namespace\" and \"updated\" sections. The details for example as below\n\nextensions-list-resp-v2\n       {\n            \"namespace\": \"http://docs.openstack.org/compute/ext/multinic/api/v1.1\",\n            \"updated\": \"2011-06-09T00:00:00Z\"\n        },\n\nextensions-list-resp\n        {\n            \"namespace\": \"http://docs.openstack.org/compute/ext/fake_xml\",\n            \"updated\": \"2014-12-03T00:00:00Z\"\n        },\n\nwe could change the details by a new patch as https://review.openstack.org/#/c/138599/ or we could seperate into 2 different files.","commit_id":"ab3c8fd026f948f1ea656c547a33c70719539617"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9031566f1b9c6beaf2f15a6d7102b0b80ed463e1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class ExtensionInfoSamplesJsonTest(api_sample_base.ApiSampleTestBaseV3):"},{"line_number":52,"context_line":"    sample_dir \u003d \"extension-info\""},{"line_number":53,"context_line":"    extra_extensions_to_load \u003d [\"os-create-backup\"]"},{"line_number":54,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @mock.patch.object(api_extensions, \u0027os_compute_soft_authorizer\u0027)"},{"line_number":57,"context_line":"    def test_get_extensions(self, soft_auth):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_a1542554","line":54,"updated":"2015-05-14 09:02:46.000000000","message":"we should run this tests also for both as v3 endpoint going to be removed after all tests gets merged.","commit_id":"ab3c8fd026f948f1ea656c547a33c70719539617"},{"author":{"_account_id":13663,"name":"heijlong","email":"jhei@redhat.com","username":"parklong"},"change_message_id":"947fd00634e1f2f64d43242e6804b59a0a88d0b8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class ExtensionInfoSamplesJsonTest(api_sample_base.ApiSampleTestBaseV3):"},{"line_number":52,"context_line":"    sample_dir \u003d \"extension-info\""},{"line_number":53,"context_line":"    extra_extensions_to_load \u003d [\"os-create-backup\"]"},{"line_number":54,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @mock.patch.object(api_extensions, \u0027os_compute_soft_authorizer\u0027)"},{"line_number":57,"context_line":"    def test_get_extensions(self, soft_auth):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_7f909a43","line":54,"in_reply_to":"7a016987_a1542554","updated":"2015-06-09 03:16:36.000000000","message":"Thanks Ghanshyam for your review. \n\nAgree with your point, I tagged _api_version \u003d \u0027v3\u0027 here just because the extension \"os-create-backup\" is API v3 specified, also I noticed that the tests results should be the same with and without this tag.\n\nanyway, I will remove this tag first in the next version.","commit_id":"ab3c8fd026f948f1ea656c547a33c70719539617"}]}