)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"77b8342c1aac717ec640b5741b29a058143553e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new global option to handle input devices has"},{"line_number":10,"context_line":"been introduced. The specifc option use_usb_tablet in the"},{"line_number":11,"context_line":"group libvirt has been depecreated for liberty and should be"},{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_7224b60c","line":11,"updated":"2015-06-15 13:56:52.000000000","message":"depecreated \u003d\u003e deprecated","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9252ecd06a15f1969351be2da61ccd6e0ea8dddd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new global option to handle input devices has"},{"line_number":10,"context_line":"been introduced. The specifc option use_usb_tablet in the"},{"line_number":11,"context_line":"group libvirt has been depecreated for liberty and should be"},{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_d1bd15b8","line":11,"in_reply_to":"fa32b979_7224b60c","updated":"2015-06-17 12:55:18.000000000","message":"Done","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"77b8342c1aac717ec640b5741b29a058143553e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A new global option to handle input devices has"},{"line_number":10,"context_line":"been introduced. The specifc option use_usb_tablet in the"},{"line_number":11,"context_line":"group libvirt has been depecreated for liberty and should be"},{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"},{"line_number":15,"context_line":"           option pointer_model introduced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_b288fee8","line":12,"updated":"2015-06-15 13:56:52.000000000","message":"remove \u003d\u003e removed","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9252ecd06a15f1969351be2da61ccd6e0ea8dddd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A new global option to handle input devices has"},{"line_number":10,"context_line":"been introduced. The specifc option use_usb_tablet in the"},{"line_number":11,"context_line":"group libvirt has been depecreated for liberty and should be"},{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"},{"line_number":15,"context_line":"           option pointer_model introduced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_51ca654f","line":12,"in_reply_to":"fa32b979_b288fee8","updated":"2015-06-17 12:55:18.000000000","message":"Done","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3ae645079e4b87c26fdfe8fef83808cb123063ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A new global option to handle input devices has"},{"line_number":10,"context_line":"been introduced. The specifc option use_usb_tablet in the"},{"line_number":11,"context_line":"group libvirt has been depecreated for liberty and should be"},{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"},{"line_number":15,"context_line":"           option pointer_model introduced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a50d1a3_3099a57c","line":12,"updated":"2015-07-23 05:25:54.000000000","message":"remove \u003d\u003e removed","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3ae645079e4b87c26fdfe8fef83808cb123063ba","unresolved":false,"context_lines":[{"line_number":12,"context_line":"remove for M*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Liberty"},{"line_number":15,"context_line":"           option pointer_model introduced"},{"line_number":16,"context_line":"Related-To: blueprint virt-configure-usb-tablet-from-image"},{"line_number":17,"context_line":"Change-Id: I51186530a94d86c8ed14783c7d42d0a3bd601f59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a50d1a3_f0ac9d8d","line":15,"updated":"2015-07-23 05:25:54.000000000","message":"Can you please add a few explanations about that the pointer_model is. This sounds very cryptic","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"group libvirt has been depecreated for Newton and should be"},{"line_number":12,"context_line":"removed for O*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Mitaka"},{"line_number":15,"context_line":"           option pointer_model introduced"},{"line_number":16,"context_line":"Related-To: blueprint virt-configure-usb-tablet-from-image"},{"line_number":17,"context_line":"Change-Id: I51186530a94d86c8ed14783c7d42d0a3bd601f59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a061dce_f6018739","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-04-06 16:26:32.000000000","message":"Do we really need a DocImpact tag for this? It will generate a docs bug, but are there docs that need updating, for example, something in the openstack manuals or install guide? If not, and the point is just the config option changes, the config option docs are generated each release and the release note is sufficient for the deprecation notice.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"group libvirt has been depecreated for Newton and should be"},{"line_number":12,"context_line":"removed for O*"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact: option use_usb_tablet deprecated in Mitaka"},{"line_number":15,"context_line":"           option pointer_model introduced"},{"line_number":16,"context_line":"Related-To: blueprint virt-configure-usb-tablet-from-image"},{"line_number":17,"context_line":"Change-Id: I51186530a94d86c8ed14783c7d42d0a3bd601f59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9a061dce_b65d4f7b","line":14,"range":{"start_line":14,"start_character":47,"end_line":14,"end_character":53},"updated":"2016-04-06 16:26:32.000000000","message":"Newton","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"}],"nova/conf/virt.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    help\u003d\u0027Unused unresized base images younger than this will not \u0027"},{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027, choices\u003d[\u0027usbtablet\u0027],"},{"line_number":329,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_d10d6de9","line":327,"updated":"2016-04-06 16:26:32.000000000","message":"Why is this a global option nova in the DEFAULT group? Shouldn\u0027t this be in the libvirt group if it\u0027s replacing use_usb_tablet? Are other virt drivers going to be using this?","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    help\u003d\u0027Unused unresized base images younger than this will not \u0027"},{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027, choices\u003d[\u0027usbtablet\u0027],"},{"line_number":329,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_f124f1c5","line":327,"in_reply_to":"9a061dce_d10d6de9","updated":"2016-04-06 16:50:12.000000000","message":"use_usb_tablet has been introduced to be specific to libvirt, but that was a mistake, all virt drivers can want to implement such option, there is nothing specific to libvirt here.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027, choices\u003d[\u0027usbtablet\u0027],"},{"line_number":329,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Input device allow interaction with graphical framebuffer. For example"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_f68867c7","line":328,"range":{"start_line":328,"start_character":21,"end_line":328,"end_character":28},"updated":"2016-04-06 16:26:32.000000000","message":"Is None a choice by default if it\u0027s not explicitly listed? I\u0027ve always wondered this about choices with StrOpt.\n\nIt must be since test_get_guest_no_pointer_model_usb_tablet_not_set is passing.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027, choices\u003d[\u0027usbtablet\u0027],"},{"line_number":329,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"Input device allow interaction with graphical framebuffer. For example"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_8c28fc87","line":328,"in_reply_to":"9a061dce_f68867c7","updated":"2016-04-06 16:50:12.000000000","message":"So yes as you can see line 336, None is choice and actually the one by default. I can probably list it yes.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f2c0ca4f8f0639a078d4833f4c1c6553d8ba85e","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Interdependencies to other options:"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"* None"},{"line_number":347,"context_line":"\"\"\")"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a061dce_fe99e3d1","line":346,"updated":"2016-04-08 13:43:37.000000000","message":"For libvirt, you have to have VNC enabled or SPICE enabled and the SPICE agent disabled to use this, right? Seems that should be documented in here.\n\nAlso for libvirt, the host OS virt type has to be HVM compatible, right?","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"47e6bb21ffb27fe522c7dbb48fa7a3db8cf9e4ed","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Interdependencies to other options:"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"* None"},{"line_number":347,"context_line":"\"\"\")"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a1b2928_2bb678dc","line":346,"in_reply_to":"9a061dce_fe99e3d1","updated":"2016-04-11 11:44:38.000000000","message":"Yes I\u0027ll add note here.","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"80c39746e4074fc753ca1f9a3add43897eb8361b","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"Interdependencies to other options:"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"* usbtablet must be configured with VNC enabled or SPICE and SPICE"},{"line_number":347,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":348,"context_line":"  configured as configured as HVM."},{"line_number":349,"context_line":" \"\"\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a18252c_9932320f","line":346,"range":{"start_line":346,"start_character":51,"end_line":346,"end_character":56},"updated":"2016-04-13 17:01:34.000000000","message":"s/SPICE/SPICE enabled/","commit_id":"9d745befcfd190959bdf8b2a451232f614b58d6f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"80c39746e4074fc753ca1f9a3add43897eb8361b","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"* usbtablet must be configured with VNC enabled or SPICE and SPICE"},{"line_number":347,"context_line":"  agent disabled. When used with libvirt the instance mode should be"},{"line_number":348,"context_line":"  configured as configured as HVM."},{"line_number":349,"context_line":" \"\"\")"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a18252c_9964f222","line":348,"range":{"start_line":348,"start_character":2,"end_line":348,"end_character":29},"updated":"2016-04-13 17:01:34.000000000","message":"Just \"configured as\".","commit_id":"9d745befcfd190959bdf8b2a451232f614b58d6f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"251c6c380f34e80c1fabea48f6d2e75f6e0e3314","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    default\u003dNone, choices\u003d[None, \u0027usbtablet\u0027],"},{"line_number":330,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Input device allow interaction with graphical framebuffer. For example"},{"line_number":333,"context_line":"to provide a graphic tablet for absolute cursor movement."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a122d0e_ec9a0613","line":332,"range":{"start_line":332,"start_character":6,"end_line":332,"end_character":12},"updated":"2016-04-21 05:44:56.000000000","message":"\"Input devices allow interaction with a graphical framebuffer\"","commit_id":"596a16b50d7c1eee3f221b18d3c16fb2b06fc09d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"287e3eb5f84df8401027a2946700c9ec82bc40b4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027,"},{"line_number":329,"context_line":"    default\u003dNone, choices\u003d[None, \u0027usbtablet\u0027],"},{"line_number":330,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7aa08908_a705ffc2","line":328,"updated":"2016-06-17 18:18:08.000000000","message":"Now that I think about this, it\u0027s weird that we even make this configurable since it\u0027s a per image constraint really. If I migrate my instance between hosts that are configured differently I could go from having USB support on my instance to losing it, and vice-versa.\n\nSeems we shouldn\u0027t even have the configuration option and have it just be solely left up to the image metadata to tell us what to do for setting this in the guest.","commit_id":"73d5d1f4618aca3fc5fa9d7cac6ea39b5199a3ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b130508bc6b623f9f1ab8def8ea80ac85663e7af","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027,"},{"line_number":329,"context_line":"    default\u003dNone, choices\u003d[None, \u0027usbtablet\u0027],"},{"line_number":330,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7aa08908_c82f77f4","line":328,"in_reply_to":"7aa08908_a705ffc2","updated":"2016-06-17 20:35:28.000000000","message":"Also, isn\u0027t this changing the default? We\u0027ve replaced the use_usb_tablet option with pointer_model. The default for use_usb_tablet is True, but the default for pointer_model is None, that\u0027s a change in the default behavior for the replacement option, right?\n\nWe get by that today because if this is None we check use_usb_tablet here:\n\nhttps://review.openstack.org/#/c/176242/25/nova/virt/libvirt/driver.py@4698\n\nWhich defaults to True so it\u0027s backward compatible, but won\u0027t be once use_usb_tablet is removed in Ocata.","commit_id":"73d5d1f4618aca3fc5fa9d7cac6ea39b5199a3ca"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"df5e4c8e12e88455c4ae71b553125142283d25a3","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    \u0027be removed\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"pointer_model \u003d cfg.StrOpt("},{"line_number":328,"context_line":"    \u0027pointer_model\u0027,"},{"line_number":329,"context_line":"    default\u003dNone, choices\u003d[None, \u0027usbtablet\u0027],"},{"line_number":330,"context_line":"    help\u003d\"\"\"Generic property to specify the pointer type."},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5a9d85d2_6a96c595","line":328,"in_reply_to":"7aa08908_c82f77f4","updated":"2016-06-20 09:17:04.000000000","message":"Operators are warn for an entire release to update to pointer_model.","commit_id":"73d5d1f4618aca3fc5fa9d7cac6ea39b5199a3ca"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3ae645079e4b87c26fdfe8fef83808cb123063ba","unresolved":false,"context_lines":[{"line_number":2907,"context_line":""},{"line_number":2908,"context_line":"    def test_get_guest_usb_tablet_conflict_option(self):"},{"line_number":2909,"context_line":"        self.flags(use_usb_tablet\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":2910,"context_line":"        self.flags(pointer_model\u003dNone)"},{"line_number":2911,"context_line":""},{"line_number":2912,"context_line":"        tablet \u003d self._test_get_guest_usb_tablet(True, True, vm_mode.HVM)"},{"line_number":2913,"context_line":"        self.assertIsNone(tablet)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_d0bc01bd","line":2910,"updated":"2015-07-23 05:25:54.000000000","message":"by default this is None. Not sure why you need to set this here","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"    def test_get_guest_usb_tablet_conflict_option(self):"},{"line_number":3293,"context_line":"        self.flags(use_usb_tablet\u003dTrue, group\u003d\u0027libvirt\u0027)"},{"line_number":3294,"context_line":"        self.flags(pointer_model\u003dNone)"},{"line_number":3295,"context_line":""},{"line_number":3296,"context_line":"        tablet \u003d self._test_get_guest_usb_tablet(True, True, vm_mode.HVM)"},{"line_number":3297,"context_line":"        self.assertIsNotNone(tablet)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_f5fe3f6a","line":3294,"updated":"2015-12-17 16:16:30.000000000","message":"surely we should also be testing the case where the use_usb_table is not set? and the new setting you are adding is used?","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":3853,"context_line":""},{"line_number":3854,"context_line":"    def test_get_guest_pointer_model_usb_tablet(self):"},{"line_number":3855,"context_line":"        self.flags(use_usb_tablet\u003dFalse, group\u003d\u0027libvirt\u0027)"},{"line_number":3856,"context_line":"        self.flags(pointer_model\u003d\u0027usbtablet\u0027)"},{"line_number":3857,"context_line":"        tablet \u003d self._test_get_guest_usb_tablet(True, True, vm_mode.HVM)"},{"line_number":3858,"context_line":"        self.assertIsNotNone(tablet)"},{"line_number":3859,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_917655a2","line":3856,"updated":"2016-04-06 16:26:32.000000000","message":"Hmm, isn\u0027t this already the default?","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":3853,"context_line":""},{"line_number":3854,"context_line":"    def test_get_guest_pointer_model_usb_tablet(self):"},{"line_number":3855,"context_line":"        self.flags(use_usb_tablet\u003dFalse, group\u003d\u0027libvirt\u0027)"},{"line_number":3856,"context_line":"        self.flags(pointer_model\u003d\u0027usbtablet\u0027)"},{"line_number":3857,"context_line":"        tablet \u003d self._test_get_guest_usb_tablet(True, True, vm_mode.HVM)"},{"line_number":3858,"context_line":"        self.assertIsNotNone(tablet)"},{"line_number":3859,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_4c3384f6","line":3856,"in_reply_to":"9a061dce_917655a2","updated":"2016-04-06 16:50:12.000000000","message":"No, no the default is \u0027None\u0027, you can see on the help message what means \u0027None\u0027","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"}],"nova/virt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"77b8342c1aac717ec640b5741b29a058143553e0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    \u0027vif_plugging_is_fatal is False, events should not \u0027"},{"line_number":60,"context_line":"                    \u0027be expected to arrive at all.\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pointer_model\u0027,"},{"line_number":62,"context_line":"                default\u003dNone,"},{"line_number":63,"context_line":"                help\u003d\u0027Generic property to specify the pointer type. \u0027"},{"line_number":64,"context_line":"                     \u0027eg: ps2|xen|vmware|usbmouse|usbtablet|spice\u0027),"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_d24a6283","line":62,"updated":"2015-06-15 13:56:52.000000000","message":"the default value is None so you do not need this line.","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9252ecd06a15f1969351be2da61ccd6e0ea8dddd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    \u0027vif_plugging_is_fatal is False, events should not \u0027"},{"line_number":60,"context_line":"                    \u0027be expected to arrive at all.\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pointer_model\u0027,"},{"line_number":62,"context_line":"                default\u003dNone,"},{"line_number":63,"context_line":"                help\u003d\u0027Generic property to specify the pointer type. \u0027"},{"line_number":64,"context_line":"                     \u0027eg: ps2|xen|vmware|usbmouse|usbtablet|spice\u0027),"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_11a93d7b","line":62,"in_reply_to":"fa32b979_d24a6283","updated":"2015-06-17 12:55:18.000000000","message":"Done","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \u0027vif_plugging_is_fatal). If this is set to zero and \u0027"},{"line_number":59,"context_line":"                    \u0027vif_plugging_is_fatal is False, events should not \u0027"},{"line_number":60,"context_line":"                    \u0027be expected to arrive at all.\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pointer_model\u0027,"},{"line_number":62,"context_line":"                help\u003d\u0027Generic property to specify the pointer type. \u0027"},{"line_number":63,"context_line":"                     \u0027eg: ps2|xen|vmware|usbmouse|usbtablet|spice\u0027),"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_5abae2c1","line":61,"updated":"2015-12-17 16:16:30.000000000","message":"we should use the \"choices\" parameter here to validate the config:\nhttp://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.StrOpt","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    \u0027be expected to arrive at all.\u0027),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pointer_model\u0027,"},{"line_number":62,"context_line":"                help\u003d\u0027Generic property to specify the pointer type. \u0027"},{"line_number":63,"context_line":"                     \u0027eg: ps2|xen|vmware|usbmouse|usbtablet|spice\u0027),"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"]"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_84731315","line":63,"updated":"2015-12-17 16:16:30.000000000","message":"can you please describe what happens by default?\n\nIt doesn\u0027t look like we support anything other that None (the default) and usbtablet? Why have we included the others? Feels like the only choice should be usbtablet?","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3105a47eabd054121bc7b2b66189e8e4587a3977","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                     \u00270 \u003d\u003e not partitioned, \u003e0 \u003d\u003e partition number\u0027),"},{"line_number":140,"context_line":"    cfg.BoolOpt(\u0027use_usb_tablet\u0027,"},{"line_number":141,"context_line":"                default\u003dTrue,"},{"line_number":142,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_type) Sync virtual and \u0027"},{"line_number":143,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":145,"context_line":"               default\u003d\"qemu+tcp://%s/system\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_285c1cec","line":142,"updated":"2015-04-22 12:08:05.000000000","message":"s/pointer_type/pointer_model","commit_id":"afb8392bd0efd79ac15f1be3047181108d9847bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"794a4f31bce46176ae02e1ee44271dd73a3cef77","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                     \u00270 \u003d\u003e not partitioned, \u003e0 \u003d\u003e partition number\u0027),"},{"line_number":140,"context_line":"    cfg.BoolOpt(\u0027use_usb_tablet\u0027,"},{"line_number":141,"context_line":"                default\u003dTrue,"},{"line_number":142,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_type) Sync virtual and \u0027"},{"line_number":143,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":145,"context_line":"               default\u003d\"qemu+tcp://%s/system\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c3045019","line":142,"updated":"2015-06-09 09:34:28.000000000","message":"You say \u0027pointer_type\u0027 here but it is called \u0027pointer_model\u0027 in the property. Fix either one...","commit_id":"95e60935601bcca33d5fccd112e5c59de43e6128"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a88ecdc68b023dee620b09a4096712abe6b27b73","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                     \u00270 \u003d\u003e not partitioned, \u003e0 \u003d\u003e partition number\u0027),"},{"line_number":140,"context_line":"    cfg.BoolOpt(\u0027use_usb_tablet\u0027,"},{"line_number":141,"context_line":"                default\u003dTrue,"},{"line_number":142,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_type) Sync virtual and \u0027"},{"line_number":143,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":145,"context_line":"               default\u003d\"qemu+tcp://%s/system\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_bef72658","line":142,"in_reply_to":"3afb71cf_c3045019","updated":"2015-06-09 10:52:45.000000000","message":"Done","commit_id":"95e60935601bcca33d5fccd112e5c59de43e6128"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a88ecdc68b023dee620b09a4096712abe6b27b73","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        self._conn_supports_start_paused \u003d CONF.libvirt.virt_type in (\u0027kvm\u0027,"},{"line_number":438,"context_line":"                                                                      \u0027qemu\u0027)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        CONF.set_default(\u0027pointer_model\u0027, \u0027usbtablet\u0027)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        for mode_str in CONF.libvirt.disk_cachemodes:"},{"line_number":443,"context_line":"            disk_type, sep, cache_mode \u003d mode_str.partition(\u0027\u003d\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_3ea2164c","line":440,"updated":"2015-06-09 10:52:45.000000000","message":"Will also add note here.","commit_id":"95e60935601bcca33d5fccd112e5c59de43e6128"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"77b8342c1aac717ec640b5741b29a058143553e0","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        # until the next release M*. It means operators can continue"},{"line_number":443,"context_line":"        # to use the depecrated option \"use_usb_tablet\" or set a"},{"line_number":444,"context_line":"        # specific device to use."},{"line_number":445,"context_line":"        CONF.set_default(\u0027pointer_model\u0027, \u0027usbtablet\u0027)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        for mode_str in CONF.libvirt.disk_cachemodes:"},{"line_number":448,"context_line":"            disk_type, sep, cache_mode \u003d mode_str.partition(\u0027\u003d\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_b57308b1","line":445,"updated":"2015-06-15 13:56:52.000000000","message":"what if use_usb_tablet is False?","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9252ecd06a15f1969351be2da61ccd6e0ea8dddd","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        # until the next release M*. It means operators can continue"},{"line_number":443,"context_line":"        # to use the depecrated option \"use_usb_tablet\" or set a"},{"line_number":444,"context_line":"        # specific device to use."},{"line_number":445,"context_line":"        CONF.set_default(\u0027pointer_model\u0027, \u0027usbtablet\u0027)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        for mode_str in CONF.libvirt.disk_cachemodes:"},{"line_number":448,"context_line":"            disk_type, sep, cache_mode \u003d mode_str.partition(\u0027\u003d\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_d196753e","line":445,"in_reply_to":"fa32b979_b57308b1","updated":"2015-06-17 12:55:18.000000000","message":"If you look at it line 4201 the feature will be disable like the old behavior","commit_id":"ad156dd84400315ef31b53217c1e820bc55918ec"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ca11dda7e2bd11575c654dcf1c39ae4520b9e0e7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027use_usb_tablet\u0027,"},{"line_number":142,"context_line":"                default\u003dTrue,"},{"line_number":143,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_model) Sync virtual and \u0027"},{"line_number":144,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":146,"context_line":"               default\u003d\"qemu+tcp://%s/system\","},{"line_number":147,"context_line":"               help\u003d\u0027Migration target URI \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c94ed46e","line":144,"updated":"2015-07-08 12:02:49.000000000","message":"isn\u0027t there a deprecated flag we are supposed to set here as well?","commit_id":"f26dd0a872f0596ba844e1c4faf4e6dd864a1524"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7b6e736bb33e0b12278bac2de1607d97c39d314c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    cfg.BoolOpt(\u0027use_usb_tablet\u0027,"},{"line_number":142,"context_line":"                default\u003dTrue,"},{"line_number":143,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_model) Sync virtual and \u0027"},{"line_number":144,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":146,"context_line":"               default\u003d\"qemu+tcp://%s/system\","},{"line_number":147,"context_line":"               help\u003d\u0027Migration target URI \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_dad3bb02","line":144,"in_reply_to":"ba3cc151_c94ed46e","updated":"2015-07-09 08:25:32.000000000","message":"I think it was when we move a option (deprecated_group, deprecated_name) - Here we are looking to remove this option for an other one more general. So I do not know, what should I do?","commit_id":"f26dd0a872f0596ba844e1c4faf4e6dd864a1524"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3ae645079e4b87c26fdfe8fef83808cb123063ba","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        # until the next release M*. It means operators can continue"},{"line_number":444,"context_line":"        # to use the depecrated option \"use_usb_tablet\" or set a"},{"line_number":445,"context_line":"        # specific device to use."},{"line_number":446,"context_line":"        CONF.set_default(\u0027pointer_model\u0027, \u0027usbtablet\u0027)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        for mode_str in CONF.libvirt.disk_cachemodes:"},{"line_number":449,"context_line":"            disk_type, sep, cache_mode \u003d mode_str.partition(\u0027\u003d\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_b0f1356d","line":446,"updated":"2015-07-23 05:25:54.000000000","message":"I am not 100% sure about this. Please see my comments in get_pointer_model","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"286316c9bf40e2f5b7c086aee2468dba9225aed7","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        # until the next release M*. It means operators can continue"},{"line_number":444,"context_line":"        # to use the depecrated option \"use_usb_tablet\" or set a"},{"line_number":445,"context_line":"        # specific device to use."},{"line_number":446,"context_line":"        CONF.set_default(\u0027pointer_model\u0027, \u0027usbtablet\u0027)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        for mode_str in CONF.libvirt.disk_cachemodes:"},{"line_number":449,"context_line":"            disk_type, sep, cache_mode \u003d mode_str.partition(\u0027\u003d\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_e5fffa31","line":446,"in_reply_to":"3a50d1a3_b0f1356d","updated":"2015-07-29 08:36:57.000000000","message":"Done","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3ae645079e4b87c26fdfe8fef83808cb123063ba","unresolved":false,"context_lines":[{"line_number":4192,"context_line":""},{"line_number":4193,"context_line":"        return guest"},{"line_number":4194,"context_line":""},{"line_number":4195,"context_line":"    def _get_guest_pointer_model(self, os_type):"},{"line_number":4196,"context_line":"        pointer_model \u003d CONF.pointer_model"},{"line_number":4197,"context_line":"        if pointer_model \u003d\u003d \"usbtablet\":"},{"line_number":4198,"context_line":"            return self._get_guest_usb_tablet(os_type)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_10a58945","line":4195,"updated":"2015-07-23 05:25:54.000000000","message":"model \u003d CONF.pointer_model\nif model is None and CONF.libvirt.use_usb_tablet:\n    model \u003d \"usbtablet\"\nif model \u003d\u003d \"usbtablet\":\n    return self._get_guest_usb_tablet(os_type)\n\nThen when you deprecate the use_usb tablet it is just a matter of delting the 2 linesa bove","commit_id":"b44a86701cc83e3fed82e34a13733467b95acf19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"207d1bc74fddc5b147f9134a5cd9d4f9916debab","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                default\u003dTrue,"},{"line_number":144,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":145,"context_line":"                help\u003d\u0027(Deprecated, please see pointer_model) Sync virtual and \u0027"},{"line_number":146,"context_line":"                     \u0027real mouse cursors in Windows VMs\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":148,"context_line":"               default\u003d\"qemu+tcp://%s/system\","},{"line_number":149,"context_line":"               help\u003d\u0027Migration target URI \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_4e0336b9","line":146,"updated":"2015-08-03 17:46:05.000000000","message":"Should probably note that the config is ignored if the pointer_model is set, probably good to give the exact name of the config in here too please.","commit_id":"f8a7762588e22bc1ae092db864ee1809f8d230fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":4388,"context_line":"        tablet \u003d None"},{"line_number":4389,"context_line":"        if os_type \u003d\u003d vm_mode.HVM:"},{"line_number":4390,"context_line":"            if CONF.libvirt.use_usb_tablet:"},{"line_number":4391,"context_line":"                LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4392,"context_line":"                                \u0027deprecate for Mitaka in favor of the more \u0027"},{"line_number":4393,"context_line":"                                \u0027generic \"pointer_model\". Please update \u0027"},{"line_number":4394,"context_line":"                                \u0027nova.conf to address this change.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_1f720cae","line":4391,"updated":"2015-12-17 16:16:30.000000000","message":"Nit: Why not move this log message into line 4372 or similar? so all the use of the deprecated option are together?","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":4389,"context_line":"        if os_type \u003d\u003d vm_mode.HVM:"},{"line_number":4390,"context_line":"            if CONF.libvirt.use_usb_tablet:"},{"line_number":4391,"context_line":"                LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4392,"context_line":"                                \u0027deprecate for Mitaka in favor of the more \u0027"},{"line_number":4393,"context_line":"                                \u0027generic \"pointer_model\". Please update \u0027"},{"line_number":4394,"context_line":"                                \u0027nova.conf to address this change.\u0027))"},{"line_number":4395,"context_line":"            tablet \u003d vconfig.LibvirtConfigGuestInput()"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_2419ff88","line":4392,"updated":"2015-12-17 16:16:30.000000000","message":"Nit: s/deprecate for/deprecated in/","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":4397,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4398,"context_line":"        else:"},{"line_number":4399,"context_line":"            LOG.warning(_LW(\u0027Using usb tablet is only supported in HVM mode\u0027))"},{"line_number":4400,"context_line":"        return tablet"},{"line_number":4401,"context_line":""},{"line_number":4402,"context_line":"    def _get_guest_xml(self, context, instance, network_info, disk_info,"},{"line_number":4403,"context_line":"                       image_meta, rescue\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a7e1126_3a7a76f2","line":4400,"updated":"2015-12-17 16:16:30.000000000","message":"Nit: The logs above to happen per build, which feels very... spam-ey. But I don\u0027t think there is a better alternative.","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":323,"context_line":"CONF.import_group(\u0027workarounds\u0027, \u0027nova.utils\u0027)"},{"line_number":324,"context_line":"CONF.import_opt(\u0027iscsi_use_multipath\u0027, \u0027nova.virt.libvirt.volume.iscsi\u0027,"},{"line_number":325,"context_line":"                group\u003d\u0027libvirt\u0027)"},{"line_number":326,"context_line":"CONF.import_opt(\u0027pointer_model\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"DEFAULT_FIREWALL_DRIVER \u003d \"%s.%s\" % ("},{"line_number":329,"context_line":"    libvirt_firewall.__name__,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_d1f1ed02","line":326,"range":{"start_line":326,"start_character":34,"end_line":326,"end_character":50},"updated":"2016-04-06 16:26:32.000000000","message":"Shouldn\u0027t this be nova.conf.virt where the option is defined?","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":4668,"context_line":"        pointer_model \u003d CONF.pointer_model"},{"line_number":4669,"context_line":"        if pointer_model is None and CONF.libvirt.use_usb_tablet:"},{"line_number":4670,"context_line":"            # TODO(sahid): We set pointer_model to keep compatibility"},{"line_number":4671,"context_line":"            # until the next release N*. It means operators can continue"},{"line_number":4672,"context_line":"            # to use the depecrated option \"use_usb_tablet\" or set a"},{"line_number":4673,"context_line":"            # specific device to use"},{"line_number":4674,"context_line":"            pointer_model \u003d \"usbtablet\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_f1f871c5","line":4671,"range":{"start_line":4671,"start_character":37,"end_line":4671,"end_character":38},"updated":"2016-04-06 16:26:32.000000000","message":"O","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":4673,"context_line":"            # specific device to use"},{"line_number":4674,"context_line":"            pointer_model \u003d \"usbtablet\""},{"line_number":4675,"context_line":"            LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4676,"context_line":"                            \u0027deprecate for Mitaka in favor of the more \u0027"},{"line_number":4677,"context_line":"                            \u0027generic \"pointer_model\". Please update \u0027"},{"line_number":4678,"context_line":"                            \u0027nova.conf to address this change.\u0027))"},{"line_number":4679,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_11236557","line":4676,"range":{"start_line":4676,"start_character":43,"end_line":4676,"end_character":49},"updated":"2016-04-06 16:26:32.000000000","message":"Newton","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":4673,"context_line":"            # specific device to use"},{"line_number":4674,"context_line":"            pointer_model \u003d \"usbtablet\""},{"line_number":4675,"context_line":"            LOG.warning(_LW(\u0027The option \"use_usb_tablet\" has been \u0027"},{"line_number":4676,"context_line":"                            \u0027deprecate for Mitaka in favor of the more \u0027"},{"line_number":4677,"context_line":"                            \u0027generic \"pointer_model\". Please update \u0027"},{"line_number":4678,"context_line":"                            \u0027nova.conf to address this change.\u0027))"},{"line_number":4679,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_7133c1ab","line":4676,"range":{"start_line":4676,"start_character":29,"end_line":4676,"end_character":38},"updated":"2016-04-06 16:26:32.000000000","message":"deprecated","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":4687,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4688,"context_line":"            else:"},{"line_number":4689,"context_line":"                LOG.warning(_LW(\u0027To use usb tablet, VNC shold be enabled or \u0027"},{"line_number":4690,"context_line":"                                \u0027SPICE and SPICE agent disabled\u0027))"},{"line_number":4691,"context_line":""},{"line_number":4692,"context_line":"    def _get_guest_usb_tablet(self, os_type):"},{"line_number":4693,"context_line":"        tablet \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_11988577","line":4690,"range":{"start_line":4690,"start_character":33,"end_line":4690,"end_character":38},"updated":"2016-04-06 16:26:32.000000000","message":"SPICE enabled?","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":4687,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4688,"context_line":"            else:"},{"line_number":4689,"context_line":"                LOG.warning(_LW(\u0027To use usb tablet, VNC shold be enabled or \u0027"},{"line_number":4690,"context_line":"                                \u0027SPICE and SPICE agent disabled\u0027))"},{"line_number":4691,"context_line":""},{"line_number":4692,"context_line":"    def _get_guest_usb_tablet(self, os_type):"},{"line_number":4693,"context_line":"        tablet \u003d None"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_4c76e406","line":4690,"in_reply_to":"9a061dce_11988577","updated":"2016-04-06 16:50:12.000000000","message":"I will double check that algo...","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":4696,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4697,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4698,"context_line":"        else:"},{"line_number":4699,"context_line":"            LOG.warning(_LW(\u0027Using usb tablet is only supported in HVM mode\u0027))"},{"line_number":4700,"context_line":"        return tablet"},{"line_number":4701,"context_line":""},{"line_number":4702,"context_line":"    def _get_guest_xml(self, context, instance, network_info, disk_info,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_71962140","line":4699,"updated":"2016-04-06 16:26:32.000000000","message":"Should this be a warning? Where does os_type come from? If the image, then it seems this shouldn\u0027t be a warning. If the host, then warning might make sense.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":4696,"context_line":"            tablet.type \u003d \"tablet\""},{"line_number":4697,"context_line":"            tablet.bus \u003d \"usb\""},{"line_number":4698,"context_line":"        else:"},{"line_number":4699,"context_line":"            LOG.warning(_LW(\u0027Using usb tablet is only supported in HVM mode\u0027))"},{"line_number":4700,"context_line":"        return tablet"},{"line_number":4701,"context_line":""},{"line_number":4702,"context_line":"    def _get_guest_xml(self, context, instance, network_info, disk_info,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a061dce_4c1f04b7","line":4699,"in_reply_to":"9a061dce_71962140","updated":"2016-04-06 16:50:12.000000000","message":"It\u0027s coming from the host, based on the kind of virtualization used.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c31c8acaffc3417212e976c847fabdfd07cd41d8","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                group\u003d\u0027libvirt\u0027)"},{"line_number":323,"context_line":"CONF.import_opt(\u0027iscsi_use_multipath\u0027, \u0027nova.virt.libvirt.volume.iscsi\u0027,"},{"line_number":324,"context_line":"                group\u003d\u0027libvirt\u0027)"},{"line_number":325,"context_line":"CONF.import_opt(\u0027pointer_model\u0027, \u0027nova.virt.driver\u0027)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"DEFAULT_FIREWALL_DRIVER \u003d \"%s.%s\" % ("},{"line_number":328,"context_line":"    libvirt_firewall.__name__,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a061dce_97b8ae2b","line":325,"range":{"start_line":325,"start_character":0,"end_line":325,"end_character":52},"updated":"2016-04-08 00:37:46.000000000","message":"This line is unnecessary.\n(\u0027pointer_model\u0027 does not exist in nova/virt/driver.py)","commit_id":"bcd0b8795bb1ec82841752cf5a04b7c43b880cd2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f2c0ca4f8f0639a078d4833f4c1c6553d8ba85e","unresolved":false,"context_lines":[{"line_number":4685,"context_line":"                return self._get_guest_usb_tablet(os_type)"},{"line_number":4686,"context_line":"            else:"},{"line_number":4687,"context_line":"                # We don\u0027t want to raise an error here in order to"},{"line_number":4688,"context_line":"                # do not break an upgrade with that option badly"},{"line_number":4689,"context_line":"                # configured."},{"line_number":4690,"context_line":"                LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4691,"context_line":"                                \u0027configuration, in order to accept this \u0027"},{"line_number":4692,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a061dce_fe4ba35d","line":4689,"range":{"start_line":4688,"start_character":59,"end_line":4689,"end_character":29},"updated":"2016-04-08 13:43:37.000000000","message":"By \u0027badly configured\u0027 do you mean setting pointer_model to a value that conflicts with VNC/SPICE being enabled? Since pointer_model has \u0027choices\u0027 oslo.config handles the misconfiguration there, so I\u0027m just trying to clarify that this is a bad configuration of multiple options not working together.","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"47e6bb21ffb27fe522c7dbb48fa7a3db8cf9e4ed","unresolved":false,"context_lines":[{"line_number":4686,"context_line":"            else:"},{"line_number":4687,"context_line":"                # We don\u0027t want to raise an error here in order to"},{"line_number":4688,"context_line":"                # do not break an upgrade with that option badly"},{"line_number":4689,"context_line":"                # configured."},{"line_number":4690,"context_line":"                LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4691,"context_line":"                                \u0027configuration, in order to accept this \u0027"},{"line_number":4692,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a1b2928_6bb4f0f1","line":4689,"in_reply_to":"9a061dce_fe4ba35d","updated":"2016-04-11 11:44:38.000000000","message":"I think my comment is little bit confusing I had in my mind to raise an exception but since until up to now we just passed on this I preferred to add log and write a comment. Also in the next path I\u0027ve added a condition where an user is setting pointer_model from the image properties, in that case we raise an exception.\n\nI can try to rephrase it.","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f2c0ca4f8f0639a078d4833f4c1c6553d8ba85e","unresolved":false,"context_lines":[{"line_number":4688,"context_line":"                # do not break an upgrade with that option badly"},{"line_number":4689,"context_line":"                # configured."},{"line_number":4690,"context_line":"                LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4691,"context_line":"                                \u0027configuration, in order to accept this \u0027"},{"line_number":4692,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4693,"context_line":"                                \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4694,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a061dce_23d508b9","line":4691,"range":{"start_line":4691,"start_character":45,"end_line":4691,"end_character":50},"updated":"2016-04-08 13:43:37.000000000","message":"nit: \"configuration. In order\"","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"47e6bb21ffb27fe522c7dbb48fa7a3db8cf9e4ed","unresolved":false,"context_lines":[{"line_number":4688,"context_line":"                # do not break an upgrade with that option badly"},{"line_number":4689,"context_line":"                # configured."},{"line_number":4690,"context_line":"                LOG.warning(_LW(\u0027USB tablet requested for guests by host \u0027"},{"line_number":4691,"context_line":"                                \u0027configuration, in order to accept this \u0027"},{"line_number":4692,"context_line":"                                \u0027request VNC should be enabled or SPICE \u0027"},{"line_number":4693,"context_line":"                                \u0027and SPICE agent disabled on host.\u0027))"},{"line_number":4694,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a1b2928_abce0881","line":4691,"in_reply_to":"9a061dce_23d508b9","updated":"2016-04-11 11:44:38.000000000","message":"Done","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"}],"releasenotes/notes/pointer-model-b4a1828c43e8d523.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  - User may wants ability to configure pointer model, currently Nova"},{"line_number":4,"context_line":"    only supports USB tablet which provide absolute cursor"},{"line_number":5,"context_line":"    movement. Libvirt provides support for more than USB tablet.  More"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a7e1126_844553b4","line":2,"updated":"2015-12-17 16:16:30.000000000","message":"Please do not use the prelude:\nhttp://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed\n\nsee how it renders:\nhttp://docs-draft.openstack.org/42/176242/16/check/gate-nova-releasenotes/68f53c7//releasenotes/build/html/unreleased.html#b1-245","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"  - Adds options to configure differents pointer model"},{"line_number":10,"context_line":"  - Adds ability for user to configure pointer model based on image"},{"line_number":11,"context_line":"    properties"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - Nova option use_usb_tablet will be deprecated in favor of"},{"line_number":14,"context_line":"    pointer_model."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a7e1126_a4272f11","line":11,"updated":"2015-12-17 16:16:30.000000000","message":"It would be nice to reference the adding image property and config in this text.","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f90ab3ac41c0e1b6e63f305d57c2c0406c7b2dda","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - Adds ability for user to configure pointer model based on image"},{"line_number":11,"context_line":"    properties"},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - Nova option use_usb_tablet will be deprecated in favor of"},{"line_number":14,"context_line":"    pointer_model."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3a7e1126_e4e8d77e","line":13,"updated":"2015-12-17 16:16:30.000000000","message":"should we not mention its in the libvirt group of options. Not sure the best way to say that. Maybe libvirt.use_usb_tablet config option?\n\nNit: I would rather it says config option rather than just option. This is aimed at users, not developers.","commit_id":"18dc5d7b0faef8a19e928996ff6692e80dc14cb9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"  - Adds ability for user to configure pointer model based on image"},{"line_number":5,"context_line":"    properties \u0027hw_pointer_model\u0027"},{"line_number":6,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a061dce_11d405ea","line":3,"range":{"start_line":3,"start_character":30,"end_line":3,"end_character":40},"updated":"2016-04-06 16:26:32.000000000","message":"different","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42c4f3be27f51ac3e8ffd52e79d4b848d44d8b4e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"  - Adds ability for user to configure pointer model based on image"},{"line_number":5,"context_line":"    properties \u0027hw_pointer_model\u0027"},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - Nova option \u0027use_usb_tablet\u0027 will be deprecated in favor of"},{"line_number":8,"context_line":"    \u0027pointer_model\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a061dce_51f15d94","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":32},"updated":"2016-04-06 16:26:32.000000000","message":"Where is this used in this change? Seems unrelated.","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"19d1638827af2919652e4096b7c9985d128c301c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"  - Adds ability for user to configure pointer model based on image"},{"line_number":5,"context_line":"    properties \u0027hw_pointer_model\u0027"},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - Nova option \u0027use_usb_tablet\u0027 will be deprecated in favor of"},{"line_number":8,"context_line":"    \u0027pointer_model\u0027"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a061dce_0c57cc58","line":5,"in_reply_to":"9a061dce_51f15d94","updated":"2016-04-06 16:50:12.000000000","message":"Ok so I have to update this, in the next patch ?","commit_id":"320623befb926067591f8c275fbe1fcc5c30ea71"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0f2c0ca4f8f0639a078d4833f4c1c6553d8ba85e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - Nova option \u0027use_usb_tablet\u0027 will be deprecated in favor of"},{"line_number":6,"context_line":"    \u0027pointer_model\u0027"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9a061dce_7e715377","line":3,"updated":"2016-04-08 13:43:37.000000000","message":"s/options/option/\n\ns/differents/different/\n\nThis still reads a bit weird to me, maybe say something like:\n\n\"The pointer_model configuration option was added to specify different pointer models for input devices. This replaces the now deprecated use_usb_tablet option.\"","commit_id":"852440018a5d20685254022ff5e8c12e6a57db38"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"80c39746e4074fc753ca1f9a3add43897eb8361b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - Nova option \u0027use_usb_tablet\u0027 will be deprecated in favor of"},{"line_number":6,"context_line":"    \u0027pointer_model\u0027"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5a18252c_b4457518","line":3,"updated":"2016-04-13 17:01:34.000000000","message":"Copied from patch set 22:\n\ns/options/option/\ns/differents/different/\nThis still reads a bit weird to me, maybe say something like:\n\"The pointer_model configuration option was added to specify different pointer models for input devices. This replaces the now deprecated use_usb_tablet option.\"","commit_id":"9d745befcfd190959bdf8b2a451232f614b58d6f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b05d0c6ef7b57277440b3cada803d7ee75926efc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds options to configure differents pointer model \u0027pointer_model\u0027"},{"line_number":4,"context_line":"deprecations:"},{"line_number":5,"context_line":"  - Nova option \u0027use_usb_tablet\u0027 will be deprecated in favor of"},{"line_number":6,"context_line":"    \u0027pointer_model\u0027"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1a122d0e_7ec9d325","line":3,"in_reply_to":"5a18252c_b4457518","updated":"2016-04-19 16:31:39.000000000","message":"Yes clearly better.","commit_id":"9d745befcfd190959bdf8b2a451232f614b58d6f"}]}