)]}'
{"nova/crypto.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ffcfba551300b31014136b670a82cd8768458b3","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"def generate_winrm_x509_cert(user_id, project_id, bits\u003d2048):"},{"line_number":369,"context_line":"    \"\"\"Generate a cert for passwordless auth for user in project.\"\"\""},{"line_number":370,"context_line":"    subject \u003d \u0027/CN\u003d%s\u0027 % user_id"},{"line_number":371,"context_line":"    upn \u003d \u0027%s@localhost\u0027 % user_id"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    with utils.tempdir() as tmpdir:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_550dad8e","line":370,"updated":"2015-04-24 17:23:32.000000000","message":"With this change, the project_id parameter isn\u0027t used so we could technically clean that up.\n\nHowever, from looking at the error in the log:\n\nhttp://logs.openstack.org/58/136458/24/check/check-novaclient-dsvm-functional/ae7b130/logs/screen-n-api.txt.gz?level\u003dTRACE#_2015-04-23_09_23_16_289\n\nstring too long:a_mbstr.c:154:maxsize\u003d64\n\nIt says the maxsize is 64.  Couldn\u0027t we just truncate the subject to 64?","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9c8ab1cacaf84cb1227d9799d0ef3c8331f4d544","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"def generate_winrm_x509_cert(user_id, project_id, bits\u003d2048):"},{"line_number":369,"context_line":"    \"\"\"Generate a cert for passwordless auth for user in project.\"\"\""},{"line_number":370,"context_line":"    subject \u003d \u0027/CN\u003d%s\u0027 % user_id"},{"line_number":371,"context_line":"    upn \u003d \u0027%s@localhost\u0027 % user_id"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    with utils.tempdir() as tmpdir:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_dd4943d2","line":370,"in_reply_to":"bab921fb_550dad8e","updated":"2015-04-28 09:22:25.000000000","message":"Good catch.\n\nWell, we can do that, but I would rather not have truncated subjects. Having a truncated project_id or user_id serves no purpose. Having only the user_id as the subject is fine, IMO.","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"}],"nova/tests/unit/compute/test_keypairs.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ffcfba551300b31014136b670a82cd8768458b3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.keypair_type \u003d keypair_obj.KEYPAIR_TYPE_X509"},{"line_number":181,"context_line":"        self._check_success()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_x509_bug_1447653(self):"},{"line_number":184,"context_line":"        # X509 keypairs will fail if the Subject they\u0027re created with"},{"line_number":185,"context_line":"        # is longer than 64 characters. The previous unit tests could not"},{"line_number":186,"context_line":"        # detect the issue because the ctxt.user_id was too short."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_555b6d87","line":183,"updated":"2015-04-24 17:23:32.000000000","message":"I\u0027d prefer to leave the bug ID out of the test name and name it something like \u0027test_x509_subject_too_long\u0027","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9c8ab1cacaf84cb1227d9799d0ef3c8331f4d544","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.keypair_type \u003d keypair_obj.KEYPAIR_TYPE_X509"},{"line_number":181,"context_line":"        self._check_success()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def test_x509_bug_1447653(self):"},{"line_number":184,"context_line":"        # X509 keypairs will fail if the Subject they\u0027re created with"},{"line_number":185,"context_line":"        # is longer than 64 characters. The previous unit tests could not"},{"line_number":186,"context_line":"        # detect the issue because the ctxt.user_id was too short."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_fd799f30","line":183,"in_reply_to":"bab921fb_555b6d87","updated":"2015-04-28 09:22:25.000000000","message":"Done","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ffcfba551300b31014136b670a82cd8768458b3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # is longer than 64 characters. The previous unit tests could not"},{"line_number":186,"context_line":"        # detect the issue because the ctxt.user_id was too short."},{"line_number":187,"context_line":"        # This unit tests is added to prove this issue."},{"line_number":188,"context_line":"        # See bug: https://bugs.launchpad.net/nova/+bug/1447653"},{"line_number":189,"context_line":"        self.keypair_type \u003d keypair_obj.KEYPAIR_TYPE_X509"},{"line_number":190,"context_line":"        self.ctxt.user_id \u003d \u0027a\u0027 * 65"},{"line_number":191,"context_line":"        self.assertRaises(processutils.ProcessExecutionError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_156f352c","line":188,"updated":"2015-04-24 17:23:32.000000000","message":"We don\u0027t need the bug reference in here, that\u0027s in the commit message so we can find it from git history later.","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"9c8ab1cacaf84cb1227d9799d0ef3c8331f4d544","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # is longer than 64 characters. The previous unit tests could not"},{"line_number":186,"context_line":"        # detect the issue because the ctxt.user_id was too short."},{"line_number":187,"context_line":"        # This unit tests is added to prove this issue."},{"line_number":188,"context_line":"        # See bug: https://bugs.launchpad.net/nova/+bug/1447653"},{"line_number":189,"context_line":"        self.keypair_type \u003d keypair_obj.KEYPAIR_TYPE_X509"},{"line_number":190,"context_line":"        self.ctxt.user_id \u003d \u0027a\u0027 * 65"},{"line_number":191,"context_line":"        self.assertRaises(processutils.ProcessExecutionError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_3d871711","line":188,"in_reply_to":"bab921fb_156f352c","updated":"2015-04-28 09:22:25.000000000","message":"Done","commit_id":"b01aba11a1d59b7e70d4ef6b71420c79a2810c8b"}]}