)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"35070e40b06aaefda6215749de82242b23353ded","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                LOG.warning(_LW(\u0027Node %(uuid)s has a malformed \"%(prop)s\". \u0027"},{"line_number":237,"context_line":"                                \u0027It should be an integer.\u0027),"},{"line_number":238,"context_line":"                            {\u0027uuid\u0027: node.uuid, \u0027prop\u0027: prop})"},{"line_number":239,"context_line":"                properties[prop] \u003d 0"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        raw_cpu_arch \u003d node.properties.get(\u0027cpu_arch\u0027, None)"},{"line_number":242,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_f70c1344","line":239,"updated":"2015-04-28 13:08:35.000000000","message":"I was concerned about this default, but zero seems to be already treated as an error below anyway.","commit_id":"5245445bbda9552ba5128ce00ccb508b6ec7e507"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b5f1639cc95aee77c53ec04ea0d0a9dc9518487c","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        try:"},{"line_number":243,"context_line":"            cpu_arch \u003d arch.canonicalize(raw_cpu_arch)"},{"line_number":244,"context_line":"        except exception.InvalidArchitectureName:"},{"line_number":245,"context_line":"            LOG.warning(_LW(\"cpu_arch not defined for node \u0027%s\u0027\"), node.uuid)"},{"line_number":246,"context_line":"            cpu_arch \u003d None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d cpu_arch"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_2178fe8e","line":245,"updated":"2015-06-03 00:11:20.000000000","message":"I thing the if not cpu_arch is still needed.\n\nAs arch.canonicalize can return None.  And in that case the message is not generated.","commit_id":"5245445bbda9552ba5128ce00ccb508b6ec7e507"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"6c22c56a2b42b70e8ed7ca62c730248388e31c7b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        try:"},{"line_number":243,"context_line":"            cpu_arch \u003d arch.canonicalize(raw_cpu_arch)"},{"line_number":244,"context_line":"        except exception.InvalidArchitectureName:"},{"line_number":245,"context_line":"            LOG.warning(_LW(\"cpu_arch not defined for node \u0027%s\u0027\"), node.uuid)"},{"line_number":246,"context_line":"            cpu_arch \u003d None"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d cpu_arch"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_0745126f","line":245,"in_reply_to":"5afe65bd_2178fe8e","updated":"2015-06-03 02:06:16.000000000","message":"I agree, it\u0027s still possible for raw_cpu_arch to be None, and hence for arch.canonicalize() to return None.  We should keep the check in place.","commit_id":"5245445bbda9552ba5128ce00ccb508b6ec7e507"}]}