)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"35a91f8ac86e762e4f5c046cf8beee6d9b63892c","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            # NOTE: the wrong setting of system may raise exception"},{"line_number":533,"context_line":"            # and makes the whol compute service to start ,see bug 1447342"},{"line_number":534,"context_line":"            LOG.warn(_LW(\"Exceptions occurs during quality check: %(error)s\"),"},{"line_number":535,"context_line":"                     {\u0027error\u0027: e})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":538,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_d84b922a","line":535,"updated":"2015-05-06 15:17:09.000000000","message":"This is really very wrong. If you look at the stack trace in the bug report the problem is that *Nova* is calling baselineCPU with XML that doesn\u0027t contain a CPU model. At the very most we should catch the error from baselineCPU and ignore it. We certainly should not catch \u0026 ignore exceptions at this level.","commit_id":"efd2a53bc57d7ce1537a320f11296697c61b8955"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"88fb219b40dda78e20007d4a1d86165ba3a3ea96","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            # NOTE: the wrong setting of system may raise exception"},{"line_number":533,"context_line":"            # and makes the whol compute service to start ,see bug 1447342"},{"line_number":534,"context_line":"            LOG.warn(_LW(\"Exceptions occurs during quality check: %(error)s\"),"},{"line_number":535,"context_line":"                     {\u0027error\u0027: e})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":538,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_739ca169","line":535,"in_reply_to":"1aca2d91_18446a72","updated":"2015-05-06 15:39:46.000000000","message":"Well we need some information on what the root cause of the stack trace is. The bug report doesn\u0027t really contain enough info to determine whether this is a genuine issue we should handle/workaround, or whether its a fatal problem that should abort startup","commit_id":"efd2a53bc57d7ce1537a320f11296697c61b8955"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"40e76214d8111db0d962981ad67ba8b78e50f5a9","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            # NOTE: the wrong setting of system may raise exception"},{"line_number":533,"context_line":"            # and makes the whol compute service to start ,see bug 1447342"},{"line_number":534,"context_line":"            LOG.warn(_LW(\"Exceptions occurs during quality check: %(error)s\"),"},{"line_number":535,"context_line":"                     {\u0027error\u0027: e})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":538,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_d30c9544","line":535,"in_reply_to":"1aca2d91_739ca169","updated":"2015-05-06 15:47:39.000000000","message":"ok, my env is a 2nd level machine (I created 2 vm on a x86 host)\neach of them acts as a compute \n\nI am not sure this kind of situation is not allowed or configuraiton is wrong on my 2nd level machine\n\nat least, when I add this patch, I can deploy a cirros image on my compute host without problem ,so I think we should allow this kind of situation...\n\nwhat kind of additional info might be helpful? I can dig into the system and add into bug list","commit_id":"efd2a53bc57d7ce1537a320f11296697c61b8955"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"03b60d1bca5c3be0a1fe7c06a864383678c3bf85","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            # NOTE: the wrong setting of system may raise exception"},{"line_number":533,"context_line":"            # and makes the whol compute service to start ,see bug 1447342"},{"line_number":534,"context_line":"            LOG.warn(_LW(\"Exceptions occurs during quality check: %(error)s\"),"},{"line_number":535,"context_line":"                     {\u0027error\u0027: e})"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":538,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_18446a72","line":535,"in_reply_to":"1aca2d91_d84b922a","updated":"2015-05-06 15:31:27.000000000","message":"Thanks, Daniel\n\nbaselineCPU is used in get_capabilities\nwhile get_capabilities was called several place \n\nActually there is a catch/except \nbut only libvirt.VIR_ERR_NO_SUPPORT will \nreport a warning\n\nshould we add this or let it be, to make the compute service not able to start?","commit_id":"efd2a53bc57d7ce1537a320f11296697c61b8955"}]}