)]}'
{"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b2d3de0f28ce51956ca095d7bfebef369c4719cb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        if CONF.upgrade_levels.compute \u003d\u003d \u0027kilo\u0027:"},{"line_number":68,"context_line":"            base_version \u003d \u00273.0\u0027"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            base_version \u003d rpcapi.client.target.version"},{"line_number":71,"context_line":"        expected_version \u003d kwargs.pop(\u0027version\u0027, base_version)"},{"line_number":72,"context_line":"        nova_network \u003d kwargs.pop(\u0027nova_network\u0027, False)"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abe1de1_8c4bb32b","line":70,"updated":"2015-04-27 11:14:23.000000000","message":"The above line is why the tests did pass. Since they used it\u0027s own rpcapi client class the base_version was still 3.0.\n\nThe first thing I tried before fixing anything was setting this explicitly to 4.0 and then the security group related tests would fail.","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e5dc07d1dc1ab306c2762389dff2d9fd471a24a","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                instance\u003dself.fake_instance_obj, device\u003d\u0027device\u0027,"},{"line_number":562,"context_line":"                volume_id\u003d\u0027id\u0027, disk_bus\u003d\u0027ide\u0027, device_type\u003d\u0027cdrom\u0027,"},{"line_number":563,"context_line":"                version\u003d\u00274.0\u0027,"},{"line_number":564,"context_line":"                _return_value\u003dobjects_block_dev.BlockDeviceMapping())"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":567,"context_line":"        self._test_compute_api(\u0027reserve_block_device_name\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_b60b687d","line":564,"updated":"2015-04-27 13:48:07.000000000","message":"Here...","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e5dc07d1dc1ab306c2762389dff2d9fd471a24a","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        self._test_compute_api(\u0027reserve_block_device_name\u0027, \u0027call\u0027,"},{"line_number":568,"context_line":"                instance\u003dself.fake_instance_obj, device\u003d\u0027device\u0027,"},{"line_number":569,"context_line":"                volume_id\u003d\u0027id\u0027, disk_bus\u003d\u0027ide\u0027, device_type\u003d\u0027cdrom\u0027,"},{"line_number":570,"context_line":"                version\u003d\u00273.35\u0027, return_bdm_object\u003dTrue)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def refresh_provider_fw_rules(self):"},{"line_number":573,"context_line":"        self._test_compute_api(\u0027refresh_provider_fw_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_f611e0b0","line":570,"updated":"2015-04-27 13:48:07.000000000","message":"...and here.","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0cbd15a7baf739257fbf1b288d79f231aad57ef","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def test_refresh_security_group_rules(self):"},{"line_number":581,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"},{"line_number":582,"context_line":"                security_group_id\u003d\u0027id\u0027, host\u003d\u0027host\u0027)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":585,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abe1de1_11e9fc1a","line":582,"updated":"2015-04-27 10:46:18.000000000","message":"do we need to add version\u003d\u00274.0\u0027 here?","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a809daead992c32a9db5f8d0a581fbab6358e8d7","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def test_refresh_security_group_rules(self):"},{"line_number":581,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"},{"line_number":582,"context_line":"                security_group_id\u003d\u0027id\u0027, host\u003d\u0027host\u0027)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":585,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_d9e177d2","line":582,"in_reply_to":"7ad32947_763f1026","updated":"2015-04-27 14:02:13.000000000","message":"Dan, thanks for clarifying, thats what I was thinking here.\n\nI think that should cover the change to support v4.0 in the rpcapi","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"783a7edf4b3faa842702aa96759406744e7a1e3e","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def test_refresh_security_group_rules(self):"},{"line_number":581,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"},{"line_number":582,"context_line":"                security_group_id\u003d\u0027id\u0027, host\u003d\u0027host\u0027)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":585,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_39c4eb3e","line":582,"in_reply_to":"7ad32947_763f1026","updated":"2015-04-27 14:05:13.000000000","message":"Ok, I see what you mean. Yes, we should have them tested like the others.","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"b2d3de0f28ce51956ca095d7bfebef369c4719cb","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def test_refresh_security_group_rules(self):"},{"line_number":581,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"},{"line_number":582,"context_line":"                security_group_id\u003d\u0027id\u0027, host\u003d\u0027host\u0027)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":585,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abe1de1_4c6c7b9c","line":582,"in_reply_to":"9abe1de1_11e9fc1a","updated":"2015-04-27 11:14:23.000000000","message":"See comment above","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e5dc07d1dc1ab306c2762389dff2d9fd471a24a","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def test_refresh_security_group_rules(self):"},{"line_number":581,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"},{"line_number":582,"context_line":"                security_group_id\u003d\u0027id\u0027, host\u003d\u0027host\u0027)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        self.flags(compute\u003d\u0027kilo\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":585,"context_line":"        self._test_compute_api(\u0027refresh_security_group_rules\u0027, \u0027cast\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_763f1026","line":582,"in_reply_to":"9abe1de1_4c6c7b9c","updated":"2015-04-27 13:48:07.000000000","message":"Hans, I think what he\u0027s asking is: don\u0027t we need a 3.0 and 4.0 test to make sure that we\u0027re sending the right versions based on the upgrade_levels.compute flag? That would test the compat_version change, and is present on the other ones that diverge (see note above).","commit_id":"9c7d56e58acc308c146222d9a03ced1e40b032ca"}]}