)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3fb13e3a5c4a41fcecd1d866e3b0471c4f9ddfe1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add os_shutdown_timeout support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow a \u0027clean\u0027 shutdown to instances, the timeout value"},{"line_number":10,"context_line":"is coming from image metadata (os_shutdown_timeout) or"},{"line_number":11,"context_line":"compute configuration (compute.shutdown_timeout). But it won\u0027t fit"},{"line_number":12,"context_line":"for special purpose for specified instance on the host."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_dcdeba6c","line":10,"updated":"2015-05-01 12:52:25.000000000","message":"you mean image_os_shutdown_timeout","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"866ddad3d8c4497787ef9bbb320f3a4bbcc26a05","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add os_shutdown_timeout support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova allow a \u0027clean\u0027 shutdown to instances, the timeout value"},{"line_number":10,"context_line":"is coming from image metadata (os_shutdown_timeout) or"},{"line_number":11,"context_line":"compute configuration (compute.shutdown_timeout). But it won\u0027t fit"},{"line_number":12,"context_line":"for special purpose for specified instance on the host."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_f7aabe6f","line":10,"in_reply_to":"3acd31a7_dcdeba6c","updated":"2015-06-02 15:53:58.000000000","message":"yes, right","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"3fb13e3a5c4a41fcecd1d866e3b0471c4f9ddfe1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Nova allow a \u0027clean\u0027 shutdown to instances, the timeout value"},{"line_number":10,"context_line":"is coming from image metadata (os_shutdown_timeout) or"},{"line_number":11,"context_line":"compute configuration (compute.shutdown_timeout). But it won\u0027t fit"},{"line_number":12,"context_line":"for special purpose for specified instance on the host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch add os_shutdown_timeout as first priority to be used."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_5c5f4ae5","line":12,"updated":"2015-05-01 12:52:25.000000000","message":"This last sentence is pretty hard to understand. Perhaps:\n\n    However there\u0027s no way to specify a custom shutdown timeout for a particular instance.","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"866ddad3d8c4497787ef9bbb320f3a4bbcc26a05","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Nova allow a \u0027clean\u0027 shutdown to instances, the timeout value"},{"line_number":10,"context_line":"is coming from image metadata (os_shutdown_timeout) or"},{"line_number":11,"context_line":"compute configuration (compute.shutdown_timeout). But it won\u0027t fit"},{"line_number":12,"context_line":"for special purpose for specified instance on the host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch add os_shutdown_timeout as first priority to be used."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_97b02adf","line":12,"in_reply_to":"3acd31a7_5c5f4ae5","updated":"2015-06-02 15:53:58.000000000","message":"right, thanks","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"58c2c5386da1d79b6c80b498e9a4c8d374b3ba3a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This patch add os_shutdown_timeout as first priority to be used."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1446741"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9cef544f59a97120bc6dbe3d11c0ee1a8ec07f15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_3da6cc53","line":18,"updated":"2015-06-03 13:00:47.000000000","message":"nit: undesirable blank line","commit_id":"124af62c90d3ec2893faac8b7472a00d004bbe8e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4be46c91518547791835fce70127bda7760ec14f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This patch add os_shutdown_timeout as first priority to be used."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1446741"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9cef544f59a97120bc6dbe3d11c0ee1a8ec07f15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_00698df8","line":18,"in_reply_to":"5afe65bd_3da6cc53","updated":"2015-07-03 13:37:08.000000000","message":"Done","commit_id":"124af62c90d3ec2893faac8b7472a00d004bbe8e"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"58c2c5386da1d79b6c80b498e9a4c8d374b3ba3a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1446741"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9cef544f59a97120bc6dbe3d11c0ee1a8ec07f15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_1d643020","line":20,"updated":"2015-06-03 13:00:47.000000000","message":"nit: undesirable blank line","commit_id":"124af62c90d3ec2893faac8b7472a00d004bbe8e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4be46c91518547791835fce70127bda7760ec14f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1446741"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9cef544f59a97120bc6dbe3d11c0ee1a8ec07f15"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_a06b01f0","line":20,"in_reply_to":"5afe65bd_1d643020","updated":"2015-07-03 13:37:08.000000000","message":"should this leave a blank? thanks :)","commit_id":"124af62c90d3ec2893faac8b7472a00d004bbe8e"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b9c89a40e235cc88e41cf2939cae700fa32b42bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba3cc151_5329ade4","updated":"2015-07-03 13:54:23.000000000","message":"See https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure for an example of correct formatting","commit_id":"cba10f77e7adb0cb09acc19bb5dac5d3dabbb6e5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9ab68aadd5de488393e7fbd807dbdabcc4e9afca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba3cc151_736b911e","in_reply_to":"ba3cc151_5329ade4","updated":"2015-07-03 13:56:12.000000000","message":"ok, got it ,thanks a lot~","commit_id":"cba10f77e7adb0cb09acc19bb5dac5d3dabbb6e5"}],"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ceac12bd32522b04c4657a106fbff7679ed66388","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"            try:"},{"line_number":2543,"context_line":"                metadata \u003d dict(instance.metadata)"},{"line_number":2544,"context_line":"                timeout \u003d int(metadata.get(\u0027os_shutdown_timeout\u0027, 0))"},{"line_number":2545,"context_line":"            except (AttributeError, ValueError):"},{"line_number":2546,"context_line":"                timeout \u003d 0"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_b07bba27","line":2545,"updated":"2015-04-26 07:44:07.000000000","message":"there isn\u0027t AttributeError I guess.","commit_id":"8777d4266e7993b5c494d4579d8687b85fbb1e18"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a2a949823cc7f9d761df6ad724ed268eb75336cc","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"            try:"},{"line_number":2543,"context_line":"                metadata \u003d dict(instance.metadata)"},{"line_number":2544,"context_line":"                timeout \u003d int(metadata.get(\u0027os_shutdown_timeout\u0027, 0))"},{"line_number":2545,"context_line":"            except (AttributeError, ValueError):"},{"line_number":2546,"context_line":"                timeout \u003d 0"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_9e2ac12b","line":2545,"in_reply_to":"bab921fb_b07bba27","updated":"2015-04-28 16:58:52.000000000","message":"Done","commit_id":"8777d4266e7993b5c494d4579d8687b85fbb1e18"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ceac12bd32522b04c4657a106fbff7679ed66388","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"            except (AttributeError, ValueError):"},{"line_number":2546,"context_line":"                timeout \u003d 0"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c\u003d 0:"},{"line_number":2549,"context_line":"                timeout \u003d compute_utils.get_value_from_system_metadata("},{"line_number":2550,"context_line":"                                instance, key\u003d\u0027image_os_shutdown_timeout\u0027,"},{"line_number":2551,"context_line":"                                type\u003dint, default\u003dCONF.shutdown_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_7071a243","line":2548,"updated":"2015-04-26 07:44:07.000000000","message":"Maybe user didn\u0027t want to wait for any second, so maybe 0 is valid value also.","commit_id":"8777d4266e7993b5c494d4579d8687b85fbb1e18"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a2a949823cc7f9d761df6ad724ed268eb75336cc","unresolved":false,"context_lines":[{"line_number":2545,"context_line":"            except (AttributeError, ValueError):"},{"line_number":2546,"context_line":"                timeout \u003d 0"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c\u003d 0:"},{"line_number":2549,"context_line":"                timeout \u003d compute_utils.get_value_from_system_metadata("},{"line_number":2550,"context_line":"                                instance, key\u003d\u0027image_os_shutdown_timeout\u0027,"},{"line_number":2551,"context_line":"                                type\u003dint, default\u003dCONF.shutdown_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_be257d5d","line":2548,"in_reply_to":"bab921fb_7071a243","updated":"2015-04-28 16:58:52.000000000","message":"ok, reasonable","commit_id":"8777d4266e7993b5c494d4579d8687b85fbb1e18"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"235ddb1b158a907ec0f89797d79be149c42b90ec","unresolved":false,"context_lines":[{"line_number":2540,"context_line":"        \"\"\"Get the timing configuration for powering down this instance.\"\"\""},{"line_number":2541,"context_line":"        if clean_shutdown:"},{"line_number":2542,"context_line":"            try:"},{"line_number":2543,"context_line":"                metadata \u003d dict(instance.metadata)"},{"line_number":2544,"context_line":"                timeout \u003d int(metadata.get(\u0027os_shutdown_timeout\u0027, -1))"},{"line_number":2545,"context_line":"            except ValueError:"},{"line_number":2546,"context_line":"                timeout \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_5b9850c0","line":2543,"updated":"2015-05-04 08:24:10.000000000","message":"This does not need to live in the block try..catch","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"866ddad3d8c4497787ef9bbb320f3a4bbcc26a05","unresolved":false,"context_lines":[{"line_number":2540,"context_line":"        \"\"\"Get the timing configuration for powering down this instance.\"\"\""},{"line_number":2541,"context_line":"        if clean_shutdown:"},{"line_number":2542,"context_line":"            try:"},{"line_number":2543,"context_line":"                metadata \u003d dict(instance.metadata)"},{"line_number":2544,"context_line":"                timeout \u003d int(metadata.get(\u0027os_shutdown_timeout\u0027, -1))"},{"line_number":2545,"context_line":"            except ValueError:"},{"line_number":2546,"context_line":"                timeout \u003d -1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_577d121b","line":2543,"in_reply_to":"3acd31a7_5b9850c0","updated":"2015-06-02 15:53:58.000000000","message":"Done","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9aeffce480fe924d9329282c95ad6b6f10c56e8a","unresolved":false,"context_lines":[{"line_number":2546,"context_line":"                timeout \u003d -1"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c 0:"},{"line_number":2549,"context_line":"                timeout \u003d compute_utils.get_value_from_system_metadata("},{"line_number":2550,"context_line":"                                instance, key\u003d\u0027image_os_shutdown_timeout\u0027,"},{"line_number":2551,"context_line":"                                type\u003dint, default\u003dCONF.shutdown_timeout)"},{"line_number":2552,"context_line":"            retry_interval \u003d self.SHUTDOWN_RETRY_INTERVAL"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_5baf2994","line":2549,"updated":"2015-05-04 13:52:53.000000000","message":"Hum... compute_utils.get_value_from_system_metadata will first check for \"image_os_shutdown_timeout\"  which is actually what you want here.","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"866ddad3d8c4497787ef9bbb320f3a4bbcc26a05","unresolved":false,"context_lines":[{"line_number":2546,"context_line":"                timeout \u003d -1"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"            if timeout \u003c 0:"},{"line_number":2549,"context_line":"                timeout \u003d compute_utils.get_value_from_system_metadata("},{"line_number":2550,"context_line":"                                instance, key\u003d\u0027image_os_shutdown_timeout\u0027,"},{"line_number":2551,"context_line":"                                type\u003dint, default\u003dCONF.shutdown_timeout)"},{"line_number":2552,"context_line":"            retry_interval \u003d self.SHUTDOWN_RETRY_INTERVAL"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_17779a3b","line":2549,"in_reply_to":"3acd31a7_5baf2994","updated":"2015-06-02 15:53:58.000000000","message":"yes, os_shutdown_timeout \u003e image_os_shutdown_timeout \u003e CONF.shutdown_timeout\n\nany proposed changes here? Thanks a lot","commit_id":"b0484ba4bb6899774676ad695300a4af54e33d9f"}]}