)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"044d156d7ae70bdef5aa12b63b1fdddf06759201","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: add get hardware info method to Host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Moves code from libvirt.driver to libvirt.host to"},{"line_number":10,"context_line":"get hardware information"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I615249eb14b6972f1aedb5de1a24952291930160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abe1de1_3a585d56","line":10,"updated":"2015-04-27 09:09:20.000000000","message":"This commit message doesn\u0027t really say very much of use.\n\nCan you change this so it mentions the names of the methods that we moved.","commit_id":"967ad46ded05adf4c9a8b8743cecff57a420180d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"62624db2884bb1a7df27d678e49de5f7fccff4f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: add get hardware info method to Host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Moves code from libvirt.driver to libvirt.host to"},{"line_number":10,"context_line":"get hardware information"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I615249eb14b6972f1aedb5de1a24952291930160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abe1de1_3648715b","line":10,"in_reply_to":"9abe1de1_3a585d56","updated":"2015-04-27 12:13:32.000000000","message":"Done","commit_id":"967ad46ded05adf4c9a8b8743cecff57a420180d"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff667e7a73783ff802f722423ae304ffd38df13d","unresolved":false,"context_lines":[{"line_number":11043,"context_line":"            def _get_memory_mb_used():"},{"line_number":11044,"context_line":"                return 88"},{"line_number":11045,"context_line":""},{"line_number":11046,"context_line":"            self._host.get_memory_mb_total \u003d _get_memory_mb_total"},{"line_number":11047,"context_line":"            self._host.get_memory_mb_used \u003d _get_memory_mb_used"},{"line_number":11048,"context_line":""},{"line_number":11049,"context_line":"        def _get_vcpu_total(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_24bb7774","line":11046,"updated":"2015-04-28 12:45:36.000000000","message":"why do we need the methods on line 11040 and 11044?\nyou could just set the values directly\n\nshould this not be: self._host.get_memory_mb_total \u003d _get_memory_mb_total()\nand\nself._host.get_memory_mb_used \u003d _get_memory_mb_used()","commit_id":"dff360b6397b8d96aaaf61ecca2933c36b45957e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"828b2c0d17adfe9522eb0d99364bd817ef3a9510","unresolved":false,"context_lines":[{"line_number":11043,"context_line":"            def _get_memory_mb_used():"},{"line_number":11044,"context_line":"                return 88"},{"line_number":11045,"context_line":""},{"line_number":11046,"context_line":"            self._host.get_memory_mb_total \u003d _get_memory_mb_total"},{"line_number":11047,"context_line":"            self._host.get_memory_mb_used \u003d _get_memory_mb_used"},{"line_number":11048,"context_line":""},{"line_number":11049,"context_line":"        def _get_vcpu_total(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_9a9ce66a","line":11046,"in_reply_to":"7ad32947_24bb7774","updated":"2015-04-28 13:16:34.000000000","message":"I do not think we can do that, this class is used to replace the driver libvirt, in the driver some methods are calling _host.get_memory_*() so we need to replace them. Actually the name of this class is really bad.","commit_id":"dff360b6397b8d96aaaf61ecca2933c36b45957e"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"94ec7c9fe6d95c4e56edc62317ea729a9f8aff80","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        Note that the memory size is reported in MiB instead of KiB."},{"line_number":875,"context_line":"        \"\"\""},{"line_number":876,"context_line":"        return self.get_connection().getInfo()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_f1b746d6","line":876,"updated":"2015-04-24 12:59:09.000000000","message":"This method returns an list but each caller only cares about a single item in the list. I think it would be nicer if we setup direct methods for each field we care about, so callers don\u0027t have to remember which list index is which. eg  get_cpu_frequency(), get_memory_mb(), get_cpu_count().\n\nAlso, lets have a test for these new methods in test_host.py","commit_id":"8c77f2c05caad6ab7e12603652e61800433e4647"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"aeab2db1f7fa83ce676a28d5a95fa2d93ddc42fd","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        Note that the memory size is reported in MiB instead of KiB."},{"line_number":875,"context_line":"        \"\"\""},{"line_number":876,"context_line":"        return self.get_connection().getInfo()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_a62ab37c","line":876,"in_reply_to":"bab921fb_f1b746d6","updated":"2015-04-24 13:14:11.000000000","message":"Yes I will do.","commit_id":"8c77f2c05caad6ab7e12603652e61800433e4647"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff667e7a73783ff802f722423ae304ffd38df13d","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        idx1 \u003d m.index(\u0027MemFree:\u0027)"},{"line_number":903,"context_line":"        idx2 \u003d m.index(\u0027Buffers:\u0027)"},{"line_number":904,"context_line":"        idx3 \u003d m.index(\u0027Cached:\u0027)"},{"line_number":905,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027:"},{"line_number":906,"context_line":"            used \u003d 0"},{"line_number":907,"context_line":"            for dom in self.list_instance_domains(only_guests\u003dFalse):"},{"line_number":908,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_84180b86","line":905,"updated":"2015-04-28 12:45:36.000000000","message":"if you are doing a refactor then can you please split out lines 906 - 926 to a helper method?\nIt will enable us to test the flows","commit_id":"dff360b6397b8d96aaaf61ecca2933c36b45957e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"828b2c0d17adfe9522eb0d99364bd817ef3a9510","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        idx1 \u003d m.index(\u0027MemFree:\u0027)"},{"line_number":903,"context_line":"        idx2 \u003d m.index(\u0027Buffers:\u0027)"},{"line_number":904,"context_line":"        idx3 \u003d m.index(\u0027Cached:\u0027)"},{"line_number":905,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027:"},{"line_number":906,"context_line":"            used \u003d 0"},{"line_number":907,"context_line":"            for dom in self.list_instance_domains(only_guests\u003dFalse):"},{"line_number":908,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ad32947_bac44240","line":905,"in_reply_to":"7ad32947_84180b86","updated":"2015-04-28 13:16:34.000000000","message":"Well as you can see i just move the code currently I believe we can consider doing this job in an other patch to also address new tests in relation.","commit_id":"dff360b6397b8d96aaaf61ecca2933c36b45957e"}]}