)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"562892c758ad5b93279279cf0fadaa43e386d653","unresolved":false,"context_lines":[{"line_number":6021,"context_line":"        :param block_migration: if true, post operation of block_migration."},{"line_number":6022,"context_line":"        \"\"\""},{"line_number":6023,"context_line":"        # Define migrated instance, otherwise, suspend/destroy does not work."},{"line_number":6024,"context_line":"        dom_list \u003d self._host.list_instance_domains()"},{"line_number":6025,"context_line":"        if instance.name not in dom_list:"},{"line_number":6026,"context_line":"            image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":6027,"context_line":"                instance.system_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_7a8935ca","line":6024,"updated":"2015-04-27 09:06:56.000000000","message":"Hmm, this logic isn\u0027t quite the same.\n\nThe listDefinedDomains method would only return a list of guests which have config files, but are *not* currently running.\n\nThe list_instance_domains() method will return a list of all guests both running and shutoff, regardless of whether they have a config file.\n\nWhat\u0027s more fun, is that after live migration, the guest is always running, so the old code \n\ndom_list \u003d self._conn.listDefinedDomains()\nif instance.name not in dom_list:\n   ..\n\nIs functionally equivalent to\n\n   if True:\n     ...\n\n\nGiven that, I\u0027d say we should just remove the call to listDefinedDomains, and unconditionally call defineXML().","commit_id":"34fc7f1187ab59128b89324196c163e209573689"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0e1b5d4bd72dcf02636ef8a5798c7200bc151ebd","unresolved":false,"context_lines":[{"line_number":6021,"context_line":"        :param block_migration: if true, post operation of block_migration."},{"line_number":6022,"context_line":"        \"\"\""},{"line_number":6023,"context_line":"        # Define migrated instance, otherwise, suspend/destroy does not work."},{"line_number":6024,"context_line":"        dom_list \u003d self._host.list_instance_domains()"},{"line_number":6025,"context_line":"        if instance.name not in dom_list:"},{"line_number":6026,"context_line":"            image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":6027,"context_line":"                instance.system_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_39c5025b","line":6024,"in_reply_to":"9abe1de1_632f4da2","updated":"2015-04-27 12:46:04.000000000","message":"Yes, live migration requires that the guest is running (at most it can be paused).","commit_id":"34fc7f1187ab59128b89324196c163e209573689"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"61abd14eb229a1d2c2ae652cb4b1ca4ab8b87a60","unresolved":false,"context_lines":[{"line_number":6021,"context_line":"        :param block_migration: if true, post operation of block_migration."},{"line_number":6022,"context_line":"        \"\"\""},{"line_number":6023,"context_line":"        # Define migrated instance, otherwise, suspend/destroy does not work."},{"line_number":6024,"context_line":"        dom_list \u003d self._host.list_instance_domains()"},{"line_number":6025,"context_line":"        if instance.name not in dom_list:"},{"line_number":6026,"context_line":"            image_meta \u003d utils.get_image_from_system_metadata("},{"line_number":6027,"context_line":"                instance.system_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_632f4da2","line":6024,"in_reply_to":"9abe1de1_7a8935ca","updated":"2015-04-27 12:09:22.000000000","message":"That said i did not find the response, but i guess we cannot operate a live migration with instance stopped, right?","commit_id":"34fc7f1187ab59128b89324196c163e209573689"}]}