)]}'
{"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b6f90a874bb4439b820b2902c73a3075df9b266b","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            mock_conn().defineXML.assert_called_once_with(\"domxml\")"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def test_device_lookup_by_name(self):"},{"line_number":838,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":839,"context_line":"            mock_conn().nodeDeviceLookupByName.return_value \u003d \"dev\""},{"line_number":840,"context_line":"            self.assertEqual(\"dev\", self.host.device_lookup_by_name(\"foo\"))"},{"line_number":841,"context_line":"            mock_conn().nodeDeviceLookupByName.assert_called_once_with(\"foo\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad32947_040d1b3e","line":838,"updated":"2015-04-28 12:46:02.000000000","message":"Again prefer to see the method annotated with  @mock.patch.object(fakelibvirt.virConnect, \"nodeDeviceLookupByName\")","commit_id":"f3642b5760b84444e6823abb613e5e1d14b04688"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b6f90a874bb4439b820b2902c73a3075df9b266b","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def test_device_lookup_by_name(self):"},{"line_number":838,"context_line":"        with mock.patch.object(host.Host, \"get_connection\") as mock_conn:"},{"line_number":839,"context_line":"            mock_conn().nodeDeviceLookupByName.return_value \u003d \"dev\""},{"line_number":840,"context_line":"            self.assertEqual(\"dev\", self.host.device_lookup_by_name(\"foo\"))"},{"line_number":841,"context_line":"            mock_conn().nodeDeviceLookupByName.assert_called_once_with(\"foo\")"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad32947_a403070f","line":839,"updated":"2015-04-28 12:46:02.000000000","message":"And this should return a fakelibvirt.virNodeDevice instance rather than a string.","commit_id":"f3642b5760b84444e6823abb613e5e1d14b04688"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6593423213cb9fb22f95d106b943e01665e2f18a","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        return self.get_connection().defineXML(xml)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def device_lookup_by_name(self, name):"},{"line_number":948,"context_line":"        \"\"\"Lookup a node device by its name.\"\"\""},{"line_number":949,"context_line":"        return self.get_connection().nodeDeviceLookupByName(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abe1de1_a0ce80b2","line":948,"updated":"2015-04-27 09:36:54.000000000","message":"Can you document the return type here","commit_id":"2edba6204da5b38ba2789419b39992f638a77f47"}]}