)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e9026932b6ff10272dca539bad8bde31dbf1653f","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                self._version_to_string(MIN_LIBVIRT_PARALLELS_VERSION))"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    # TODO(sahid): Should be removed but tests need also to be updated."},{"line_number":557,"context_line":"    # No call to libvirt should be present here. see Host."},{"line_number":558,"context_line":"    def _get_connection(self):"},{"line_number":559,"context_line":"        return self._host.get_connection()"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abe1de1_74adc187","line":557,"updated":"2015-04-27 13:11:57.000000000","message":"Lets expand this text a bit more for benefit of people unfamiliar with the design goals\n\n  # TODO(sahid): This method is targetted for removal when the tests have been\n  # updated to avoid its use\n  #\n  # All libvirt API calls on the libvirt.Connect object should be encapsulated by\n  # methods on the nova.virt.libvirt.host.Host object, rather than directly invoking\n  # the libvirt APIs. The goal is to avoid a direct dependency on the libvirt API\n  # from the driver.py file.","commit_id":"6e5b8616a8ff32e4122bc49ba7119721330811b8"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eb9be7832eab46dc329a69a9464c3b03a42b60","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    # is to avoid a direct dependency on the libvirt API from the"},{"line_number":562,"context_line":"    # driver.py file."},{"line_number":563,"context_line":"    def _get_connection(self):"},{"line_number":564,"context_line":"        return self._host.get_connection()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    _conn \u003d property(_get_connection)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_a382c192","line":564,"updated":"2015-05-01 09:00:56.000000000","message":"should we rename Host.get_connection() to Host._get_connection() also? Avoid people use Host.get_connection() also.","commit_id":"319e166157042d101245169e712fb4a7ed97bda7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d460c2c21567d8152a29a037e2b6deb133c3cd01","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    # is to avoid a direct dependency on the libvirt API from the"},{"line_number":562,"context_line":"    # driver.py file."},{"line_number":563,"context_line":"    def _get_connection(self):"},{"line_number":564,"context_line":"        return self._host.get_connection()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    _conn \u003d property(_get_connection)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_bd619c3b","line":564,"in_reply_to":"3acd31a7_a382c192","updated":"2015-05-04 06:44:34.000000000","message":"Well I believe we want to keep currently a public interface to retrieve a libvirt connection some other modules need it. (cf: firewall)","commit_id":"319e166157042d101245169e712fb4a7ed97bda7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"fc5f417bc7c3284522f4ed1d35503b68d8981239","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    # is to avoid a direct dependency on the libvirt API from the"},{"line_number":562,"context_line":"    # driver.py file."},{"line_number":563,"context_line":"    def _get_connection(self):"},{"line_number":564,"context_line":"        return self._host.get_connection()"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    _conn \u003d property(_get_connection)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3acd31a7_d1c9b127","line":564,"in_reply_to":"3acd31a7_bd619c3b","updated":"2015-05-05 14:37:15.000000000","message":"Eventually we might be able to declare it private, but no rush since firewall code uses it.","commit_id":"319e166157042d101245169e712fb4a7ed97bda7"}]}