)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2af0ef1a1e397dc0bedcd9e16d62989a20c4b924","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"            if with_meta:"},{"line_number":1144,"context_line":"                inst_ref[\u0027system_metadata\u0027][\u0027image_hw_disk_bus\u0027] \u003d \u0027ide\u0027"},{"line_number":1145,"context_line":"            instance \u003d objects.Instance(**inst_ref)"},{"line_number":1146,"context_line":"            instance[\u0027image_ref\u0027] \u003d \u002770a599e0-31e7-49b7-b260-868f221a761e\u0027"},{"line_number":1147,"context_line":"            return instance"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        def _check_xml_bus(xml):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_c5adcd32","line":1146,"updated":"2015-05-12 20:14:54.000000000","message":"this is an object so you can do:\ninstance.image_ref","commit_id":"7bb8e3ff92b746d3dd4a3137718172a5677cff0f"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"5d6cb314c140acf59b06451800a8f912353a0a7e","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"            if with_meta:"},{"line_number":1144,"context_line":"                inst_ref[\u0027system_metadata\u0027][\u0027image_hw_disk_bus\u0027] \u003d \u0027ide\u0027"},{"line_number":1145,"context_line":"            instance \u003d objects.Instance(**inst_ref)"},{"line_number":1146,"context_line":"            instance[\u0027image_ref\u0027] \u003d \u002770a599e0-31e7-49b7-b260-868f221a761e\u0027"},{"line_number":1147,"context_line":"            return instance"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        def _check_xml_bus(xml):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_c46daa05","line":1146,"in_reply_to":"9a0c5dc1_c5adcd32","updated":"2015-05-13 15:47:48.000000000","message":"Done","commit_id":"7bb8e3ff92b746d3dd4a3137718172a5677cff0f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d85393de6f55626d0711b340fd01f3b79a5f44e0","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"    def test_get_guest_xml(self):"},{"line_number":1140,"context_line":"        def _get_inst(with_meta\u003dTrue):"},{"line_number":1141,"context_line":"            inst_ref \u003d self.test_instance"},{"line_number":1142,"context_line":"            inst_ref[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":1143,"context_line":"            if with_meta:"},{"line_number":1144,"context_line":"                inst_ref[\u0027system_metadata\u0027][\u0027image_hw_disk_bus\u0027] \u003d \u0027ide\u0027"},{"line_number":1145,"context_line":"            instance \u003d objects.Instance(**inst_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_678641bb","line":1142,"updated":"2015-06-01 20:54:53.000000000","message":"Why is the above uuid-set necessary?","commit_id":"e93cd4f3ba2cf288548f55cdd04e658d71d26fdf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d85393de6f55626d0711b340fd01f3b79a5f44e0","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"            if with_meta:"},{"line_number":1144,"context_line":"                inst_ref[\u0027system_metadata\u0027][\u0027image_hw_disk_bus\u0027] \u003d \u0027ide\u0027"},{"line_number":1145,"context_line":"            instance \u003d objects.Instance(**inst_ref)"},{"line_number":1146,"context_line":"            instance.image_ref \u003d \u002770a599e0-31e7-49b7-b260-868f221a761e\u0027"},{"line_number":1147,"context_line":"            return instance"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"        def _check_xml_bus(xml):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_c20de338","line":1146,"updated":"2015-06-01 20:54:53.000000000","message":"Why is the above necessary? And what is significant about the UUID beginning with \u002770a\u0027?","commit_id":"e93cd4f3ba2cf288548f55cdd04e658d71d26fdf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d85393de6f55626d0711b340fd01f3b79a5f44e0","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        _get_guest_xml(instance)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        instance \u003d _get_inst(with_meta\u003dFalse)"},{"line_number":1178,"context_line":"        _get_guest_xml(instance)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def _test_get_guest_memory_backing_config("},{"line_number":1181,"context_line":"            self, host_topology, inst_topology, numatune):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_02bf7bd1","line":1178,"updated":"2015-06-01 20:54:53.000000000","message":"OK, so if I get this right, all the above test is verifying is that if an admin sets the \u0027image_hw_disk_bus\u0027 key to \u0027ide\u0027 in the image metadata, that the XML libvirt generates for the guest will have a \u003cdevices\u003e\u003cdisk\u003e\u003ctarget\u003e element that has a \u003cbus\u003e element with the text \"ide\" in it. Is that correct?\n\nIf so, then I think *either* this test doesn\u0027t belong here (since all these tests are actually checking to see that the correct vconfig.LibvirtConfigGuest* objects are created properly by driver._get_guest_config()) OR that this code is already covered completely by the other tests that verify the construction of the vconfig.LibvirtConfigGuestDisk object here:\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_config.py#L535\n\nIn short, I\u0027m not sure this test provides much value at all...","commit_id":"e93cd4f3ba2cf288548f55cdd04e658d71d26fdf"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a46a34b12c85ce734b686648fb412185d908347c","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        _get_guest_xml(instance)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        instance \u003d _get_inst(with_meta\u003dFalse)"},{"line_number":1178,"context_line":"        _get_guest_xml(instance)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def _test_get_guest_memory_backing_config("},{"line_number":1181,"context_line":"            self, host_topology, inst_topology, numatune):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_06dd3d42","line":1178,"in_reply_to":"5afe65bd_02bf7bd1","updated":"2015-06-02 08:52:11.000000000","message":"Yep, I\u0027m not really seeing what this adds that isn\u0027t already checked in the various test_get_guest_config_* test cases.","commit_id":"e93cd4f3ba2cf288548f55cdd04e658d71d26fdf"}]}