)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4b0e746b503c0478c6dcfe945657eb3aab7e0f77","unresolved":false,"context_lines":[{"line_number":2080,"context_line":""},{"line_number":2081,"context_line":"        # NOTE (rmk): Re-populate any missing backing files."},{"line_number":2082,"context_line":"        disk_info_json \u003d self.get_instance_disk_info(instance,"},{"line_number":2083,"context_line":"                                                     block_device_info)"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"        if context.auth_token is not None:"},{"line_number":2086,"context_line":"            self._create_images_and_backing(context, instance, instance_dir,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_b76e722d","line":2083,"updated":"2015-05-15 13:35:24.000000000","message":"This intentionally called _get_instance_disk_info because it avoids use re-fetching the XML again.\n\nI guess you changed this because you needed to the json-ified disk info here, but in fact what you should have done is changed  _create_images_and_backing so it accepts a disk_info dict, instead of the json-ified disk info.","commit_id":"c06d18f65f28cc37d01b4f1f78cdd6fe062c4902"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"95683b777ea43ee11a344ef094135f9ce1ae5308","unresolved":false,"context_lines":[{"line_number":2080,"context_line":""},{"line_number":2081,"context_line":"        # NOTE (rmk): Re-populate any missing backing files."},{"line_number":2082,"context_line":"        disk_info_json \u003d self.get_instance_disk_info(instance,"},{"line_number":2083,"context_line":"                                                     block_device_info)"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"        if context.auth_token is not None:"},{"line_number":2086,"context_line":"            self._create_images_and_backing(context, instance, instance_dir,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_a773ab14","line":2083,"in_reply_to":"7a016987_b76e722d","updated":"2015-05-18 15:25:10.000000000","message":"Thanks! I missed that when making the change. I\u0027ll try to spin a new patch this week (in between summit sessions).","commit_id":"c06d18f65f28cc37d01b4f1f78cdd6fe062c4902"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f79d26d1dbdea21ce488606c2bbd2621e41f8a80","unresolved":false,"context_lines":[{"line_number":6051,"context_line":"        return disk_info"},{"line_number":6052,"context_line":""},{"line_number":6053,"context_line":"    def get_instance_disk_info(self, instance,"},{"line_number":6054,"context_line":"                               block_device_info\u003dNone):"},{"line_number":6055,"context_line":"        try:"},{"line_number":6056,"context_line":"            dom \u003d self._host.get_domain(instance)"},{"line_number":6057,"context_line":"            xml \u003d dom.XMLDesc(0)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_9fe07d2a","line":6054,"updated":"2015-05-25 04:07:32.000000000","message":"maybe it is worthwhile adding a doc string here indicating the returned data format","commit_id":"569d7f86ac3cd9e985e861b8839d207695b35c98"}]}