)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"7f4b83961c64cde8f565519753db15e07482cb6a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"So, let\u0027s remove the code (including the outdated TODO item and an"},{"line_number":28,"context_line":"expired pastebin) that inherits backing file properties since qcow2"},{"line_number":29,"context_line":"overlay images do not inherit (except for \u0027size\u0027 of the disk image, if"},{"line_number":30,"context_line":"it isn\u0027t specified)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"NOTES:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abe1de1_efa45c09","line":30,"updated":"2015-04-27 13:27:38.000000000","message":"Huh, this is basically reverting that commit above which seems wrong.\n\nYou\u0027ve said that qcow2 overlays do *not* inherit these properties by default. For openstack we *wanted* them to be inherited. Thus we must explicitly set the properties on the CLI, as is done in the current code. Your change is removing all the inheritance which just undoes Joshua\u0027s change, which makes no sense.\n\nFor completely different reason, I\u0027m fine with us deleting the encryption flag, since even if the base image is encrypted, Nova has no support for unencrypting it. So setting that flag serves no purpose.\n\nLikewise it is fine to update the broken link in the comment.\n\nBoth of those should be separate commits from each other.","commit_id":"0cea90897fc3024bf968abd6e9a040d6c4b147c9"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"994674ed153c6dc7422c78aceecf9ff65b39048b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"So, let\u0027s remove the code (including the outdated TODO item and an"},{"line_number":28,"context_line":"expired pastebin) that inherits backing file properties since qcow2"},{"line_number":29,"context_line":"overlay images do not inherit (except for \u0027size\u0027 of the disk image, if"},{"line_number":30,"context_line":"it isn\u0027t specified)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"NOTES:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ad32947_d05704c9","line":30,"in_reply_to":"7ad32947_b66c8809","updated":"2015-04-27 15:30:22.000000000","message":"\u003e You\u0027ve said that qcow2 overlays do *not* inherit these properties by default.\n\nJust to clarify on the above point if yours, I meant there\u0027s no _explicit_ code in QEMU that ensures it.\n\nYeah, there\u0027s a default cluster_sie of \u002765536\u0027 (i.e. 64 KiB):\n\n  $ qemu-img create -f qcow2 base.qcow2 1G \n  [. . .] cluster_size\u003d65536 lazy_refcounts\u003doff\n\n  $ qemu-img create -f qcow2 -b ./base.qcow2 -F qcow2 overlay1.qcow2 \n  [. . .] cluster_size\u003d65536 lazy_refcounts\u003doff\n\nBut it\u0027s \"global\", if a base image is created with a non-default \u0027cluster_size\u0027, then indeed the qcow2 overlay image does not inherit that value.\n\nDan also mentioned a valid point on why we might want to retain the behavior of overlay inheriting the cluster_size value for  from base:  qcow2 cluster_size has changed in the past (last in June 2009, for version 0.11, checked w/ QEMU folks) and depending on what version of qemu people used to create an image they upload, it might affect things.","commit_id":"0cea90897fc3024bf968abd6e9a040d6c4b147c9"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"7056e988d12069d69eee20af2aa4c3474497bd36","unresolved":false,"context_lines":[{"line_number":27,"context_line":"So, let\u0027s remove the code (including the outdated TODO item and an"},{"line_number":28,"context_line":"expired pastebin) that inherits backing file properties since qcow2"},{"line_number":29,"context_line":"overlay images do not inherit (except for \u0027size\u0027 of the disk image, if"},{"line_number":30,"context_line":"it isn\u0027t specified)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"NOTES:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ad32947_b66c8809","line":30,"in_reply_to":"9abe1de1_efa45c09","updated":"2015-04-27 14:09:51.000000000","message":"Hmm, actually I tried to find the reason why OpenStack wanted to inherit the properties from base, but I couldn\u0027t find any (and the blueprint doesn\u0027t explain _why_):\n\n    https://blueprints.launchpad.net/nova/+spec/backing-file-options\n\nSecond, before this, I submitted a separate change where I just cleaned up comments without removing the code, I\u0027ll rework it appropriately.\n\n    https://review.openstack.org/#/c/172458/\n\nSo, since you confirmed, OpenStack wants to inherit the properties from base:\n\n(a) Update this change to add a better comment in the said code\n\n     https://review.openstack.org/#/c/172458/ \n\n(b) Yes -- will send a separate commit for removing the encryption flag.\n\nThanks for the review.","commit_id":"0cea90897fc3024bf968abd6e9a040d6c4b147c9"}]}