)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d2d341245ee1b4c36c79f22954284fb34a043a38","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The wrong unit(Mbps) is used in the option description"},{"line_number":10,"context_line":"of CONF.libvirt.live_migration_bandwidth, it mislead the"},{"line_number":11,"context_line":"users, corrected it to MiB/s."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1448844"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab921fb_e255e1c1","line":11,"updated":"2015-04-27 07:55:17.000000000","message":"Also update the help to refer the error when incompatible hypervisors.","commit_id":"107d02a901c5a90a1196ef38edda0fd925744989"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5cc78eb25a90fcb198fa1f9d3490534a740ca992","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The wrong unit(Mbps) is used in the option description"},{"line_number":10,"context_line":"of CONF.libvirt.live_migration_bandwidth, it mislead the"},{"line_number":11,"context_line":"users, corrected it to MiB/s."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1448844"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I032440dc5e743c77595ae653ba859183fa38097b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab921fb_6201d1ae","line":12,"updated":"2015-04-27 07:56:02.000000000","message":"You missed to add a doc tag here","commit_id":"107d02a901c5a90a1196ef38edda0fd925744989"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1daea7ad05d0659a374db4d0c9fdad95b0d064b6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":157,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":158,"context_line":"               default\u003d0,"},{"line_number":159,"context_line":"               help\u003d\u0027Maximum bandwidth to be used during migration, in MiB/s\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":161,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":162,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_6701e3ae","line":159,"updated":"2015-04-27 06:34:07.000000000","message":"Please see the libvirt documentation. It says that this should be Mbps\nhttps://libvirt.org/sources/java/javadoc/org/libvirt/Domain.html","commit_id":"0c7de10437ad58826a5827e59d4bad8b0242206e"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"57f31dcb7962e90d0c9dd85e15738bb1d30d3ad6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":157,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":158,"context_line":"               default\u003d0,"},{"line_number":159,"context_line":"               help\u003d\u0027Maximum bandwidth to be used during migration, in MiB/s\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":161,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":162,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_8724f7c4","line":159,"in_reply_to":"bab921fb_071907d7","updated":"2015-04-27 07:37:27.000000000","message":"Thank everybody for reviewing.","commit_id":"0c7de10437ad58826a5827e59d4bad8b0242206e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"72c5c86c318f922f1b48fea0fe005b4c67f006c1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":157,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":158,"context_line":"               default\u003d0,"},{"line_number":159,"context_line":"               help\u003d\u0027Maximum bandwidth to be used during migration, in MiB/s\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":161,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":162,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_47edbfb5","line":159,"in_reply_to":"bab921fb_27d52b1b","updated":"2015-04-27 07:12:34.000000000","message":"Thanks!\n\nHow about having the following text as the message then: \"The maximum bandwidth (in MiB/s) that will be used to do migration can be specified with the bandwidth parameter. If set to 0, libvirt will choose a suitable default. Some hypervisors do not support this feature and will return an error if bandwidth is not 0.\"\n\nThat is far more informative","commit_id":"0c7de10437ad58826a5827e59d4bad8b0242206e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1c9cfbd3097c98659c6dac825376f501898c7939","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":157,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":158,"context_line":"               default\u003d0,"},{"line_number":159,"context_line":"               help\u003d\u0027Maximum bandwidth to be used during migration, in MiB/s\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":161,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":162,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_071907d7","line":159,"in_reply_to":"bab921fb_47edbfb5","updated":"2015-04-27 07:17:17.000000000","message":"+1 to use the same doc as python libvirt.","commit_id":"0c7de10437ad58826a5827e59d4bad8b0242206e"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"022b1c5e1c75e400e40ed49eb013f82b4fd14eb6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               help\u003d\u0027Migration flags to be set for block migration\u0027),"},{"line_number":157,"context_line":"    cfg.IntOpt(\u0027live_migration_bandwidth\u0027,"},{"line_number":158,"context_line":"               default\u003d0,"},{"line_number":159,"context_line":"               help\u003d\u0027Maximum bandwidth to be used during migration, in MiB/s\u0027),"},{"line_number":160,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":161,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":162,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_27d52b1b","line":159,"in_reply_to":"bab921fb_6701e3ae","updated":"2015-04-27 06:55:09.000000000","message":"Emm...\n\nI think it\u0027s a Java API bug, in libvirt API and python-libvirt API, it\u0027s MiB/s.\n\nlibvirt API:\n\nhttp://www.libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateToURI2\n\npython-libvirt API:\n\nThe maximum bandwidth (in MiB/s) that will be used to do migration can be specified with the bandwidth parameter.  If set to 0, libvirt will choose a suitable default.  Some hypervisors do not support this feature and will return an error if bandwidth is not 0.","commit_id":"0c7de10437ad58826a5827e59d4bad8b0242206e"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"df1e284cea59c49745418ee83243a5ad4b877d05","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    \u0027migration can be specified with the bandwidth parameter. \u0027"},{"line_number":161,"context_line":"                    \u0027If set to 0, libvirt will choose a suitable default. \u0027"},{"line_number":162,"context_line":"                    \u0027Some hypervisors do not support this feature and will \u0027"},{"line_number":163,"context_line":"                    \u0027return an error if bandwidth is not 0.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027snapshot_image_format\u0027,"},{"line_number":165,"context_line":"               help\u003d\u0027Snapshot image format (valid options are : \u0027"},{"line_number":166,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abe1de1_fdcf7fb1","line":163,"updated":"2015-04-27 09:13:32.000000000","message":"hi Rui, seems it dup with my patch https://review.openstack.org/#/c/168258/","commit_id":"e67d955fa26dd3354a2d7c2b59beb3a79975693e"}]}