)]}'
{"nova/api/openstack/compute/contrib/simple_tenant_usage.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"779ef9087b07c37c1c3abc5c78172abef1f98326","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            # can\u0027t bill if there is no flavor"},{"line_number":100,"context_line":"            flavor_ref \u003d None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return flavor_ref"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _tenant_usages_for_period(self, context, period_start,"},{"line_number":105,"context_line":"                                  period_stop, tenant_id\u003dNone, detailed\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_e063e2da","side":"PARENT","line":102,"updated":"2015-05-08 13:44:10.000000000","message":"You can\u0027t remove this. It\u0027s pretty much the only place we have to keep this stuff. Since we didn\u0027t migrate deleted instances, we have to support this billing fallback position. Further, as you see, this actually accounts for the thing before the thing we just replaced, which is that no flavor is attached to the instance at all. If we hit a really old instance in the DB, we look up flavor info by id here, which is not present anywhere else.\n\nSo, I think we need to leave this. It\u0027s not much code, so I don\u0027t think we\u0027re gaining much by removing it.","commit_id":"9d77ab1290f19973655fdfbc35e9770f9adaffd4"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ffd4675132aef76918f8f97821611ed05b83453d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            # can\u0027t bill if there is no flavor"},{"line_number":100,"context_line":"            flavor_ref \u003d None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return flavor_ref"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _tenant_usages_for_period(self, context, period_start,"},{"line_number":105,"context_line":"                                  period_stop, tenant_id\u003dNone, detailed\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_8eceee81","side":"PARENT","line":102,"in_reply_to":"1aca2d91_e063e2da","updated":"2015-05-11 01:08:49.000000000","message":"hi Dan, thanks for so elaborate explanation, I will abandon this.","commit_id":"9d77ab1290f19973655fdfbc35e9770f9adaffd4"}],"nova/api/openstack/compute/plugins/v3/simple_tenant_usage.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e52095c6833c091a5a5f3e2ceaae38ef01e9d1f1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            info[\u0027hours\u0027] \u003d self._hours_for(instance,"},{"line_number":89,"context_line":"                                            period_start,"},{"line_number":90,"context_line":"                                            period_stop)"},{"line_number":91,"context_line":"#            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":92,"context_line":"            flavor \u003d instance.flavor"},{"line_number":93,"context_line":"            if not flavor:"},{"line_number":94,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_0bdc06e3","line":91,"updated":"2015-04-28 14:12:30.000000000","message":"I guess you forget remove this line","commit_id":"20acd8fc937d09d805bed7a4a3eb2adec42335ad"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"3ccb87d321a440bf39f838f064720ae7ece65c24","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            info[\u0027hours\u0027] \u003d self._hours_for(instance,"},{"line_number":89,"context_line":"                                            period_start,"},{"line_number":90,"context_line":"                                            period_stop)"},{"line_number":91,"context_line":"#            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":92,"context_line":"            flavor \u003d instance.flavor"},{"line_number":93,"context_line":"            if not flavor:"},{"line_number":94,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_8881394d","line":91,"in_reply_to":"7ad32947_0bdc06e3","updated":"2015-04-28 14:34:48.000000000","message":"Yes good\n Catch","commit_id":"20acd8fc937d09d805bed7a4a3eb2adec42335ad"}]}