)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"aacee87d77791aef0149b07c97300df25203f8d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5afe65bd_5fdd4013","line":14,"updated":"2015-06-02 05:43:47.000000000","message":"NIT: I\u0027d like to see Related-Bug: 1438226 here as you\u0027re cleaning up the fix to that bug.","commit_id":"0129bbfdd51db5852c42412612a1c8391426d8d7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff47a0dea0eaafe54ea7ea41601ee32ee7eeb745","unresolved":false,"context_lines":[{"line_number":4746,"context_line":"        if not self._host.has_min_version(MIN_LIBVIRT_NUMA_VERSION):"},{"line_number":4747,"context_line":"            return False"},{"line_number":4748,"context_line":""},{"line_number":4749,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4750,"context_line":"            if self._host.has_version(ver):"},{"line_number":4751,"context_line":"                return False"},{"line_number":4752,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_b573334d","line":4749,"updated":"2015-04-28 13:31:58.000000000","message":"Can\u0027t the distro backport a patch to this version to fix libvirt?","commit_id":"2e966713eb1cf9a99f07b8fbcea8d4194aef8bbb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"49f9bec6e738f5f1f179c142a19cef2faa33c382","unresolved":false,"context_lines":[{"line_number":4746,"context_line":"        if not self._host.has_min_version(MIN_LIBVIRT_NUMA_VERSION):"},{"line_number":4747,"context_line":"            return False"},{"line_number":4748,"context_line":""},{"line_number":4749,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4750,"context_line":"            if self._host.has_version(ver):"},{"line_number":4751,"context_line":"                return False"},{"line_number":4752,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_9b2413b0","line":4749,"in_reply_to":"7ad32947_b573334d","updated":"2015-04-28 16:32:54.000000000","message":"Matt...it\u0027d have to be every distro using it.  Upstream libvirt presumably released 1.2.9.3 with a fix, but 1.2.9.2 would be forever broken.\n\nLooks like Stephen already has 1.2.9.2 and 1.2.10 listed as BAD_LIBVIRT_CPU_POLICY_VERSIONS, so there is some precedent for this.","commit_id":"2e966713eb1cf9a99f07b8fbcea8d4194aef8bbb"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9a3880b57aada85b189f5ef9ace3453ec40b6c9f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"# used by the guest may not match what was requested"},{"line_number":363,"context_line":"MIN_LIBVIRT_HUGEPAGE_VERSION \u003d (1, 2, 8)"},{"line_number":364,"context_line":"# missing libvirt cpu pinning support"},{"line_number":365,"context_line":"BAD_LIBVIRT_CPU_POLICY_VERSIONS \u003d [(1, 2, 9, 2), (1, 2, 10)]"},{"line_number":366,"context_line":"# qemu 2.1 introduces support for pinning memory on host"},{"line_number":367,"context_line":"# NUMA nodes, along with the ability to specify hugepage"},{"line_number":368,"context_line":"# sizes per guest NUMA node"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ee4145aa","side":"PARENT","line":365,"updated":"2015-05-20 22:48:13.000000000","message":"Suggestion: We cannot do pinning without NUMA so we can probably remove the version 1.2.9.2 from this tuple.","commit_id":"c13f693d496f4ea5dbc78244fefd9ec2d6ea8de5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"004e4ad0c5cff2dfe9c7195aab2c73600dc4749b","unresolved":false,"context_lines":[{"line_number":4736,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64]"},{"line_number":4737,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4738,"context_line":""},{"line_number":4739,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4740,"context_line":"            if self._host.has_version(ver):"},{"line_number":4741,"context_line":"                return False"},{"line_number":4742,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_2bb99215","line":4739,"updated":"2015-05-20 18:47:19.000000000","message":"You need a simple unit test to validate that this happens and isn\u0027t regressed.","commit_id":"9d508add140438c5bb9b4f120269d10598eec8fe"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9a3880b57aada85b189f5ef9ace3453ec40b6c9f","unresolved":false,"context_lines":[{"line_number":4736,"context_line":"        supported_archs \u003d [arch.I686, arch.X86_64]"},{"line_number":4737,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4738,"context_line":""},{"line_number":4739,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4740,"context_line":"            if self._host.has_version(ver):"},{"line_number":4741,"context_line":"                return False"},{"line_number":4742,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_eefa6574","line":4739,"in_reply_to":"7a016987_2bb99215","updated":"2015-05-20 22:48:13.000000000","message":"Yes.","commit_id":"9d508add140438c5bb9b4f120269d10598eec8fe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"098b66f52f7f3500502b2848e5f332f6daf582be","unresolved":false,"context_lines":[{"line_number":4739,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4740,"context_line":""},{"line_number":4741,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4742,"context_line":"            if self._host.has_version(ver):"},{"line_number":4743,"context_line":"                return False"},{"line_number":4744,"context_line":""},{"line_number":4745,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_9ed58c1d","line":4742,"updated":"2015-06-04 11:07:22.000000000","message":"if you respin can you add a log - it may be useful for someone hitting is issue","commit_id":"f50eb8ed3a89df1f5a6483907a3cdd84fb67e81d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24caa1443709576b08348c541d0734f94c6a34e0","unresolved":false,"context_lines":[{"line_number":4739,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4740,"context_line":""},{"line_number":4741,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4742,"context_line":"            if self._host.has_version(ver):"},{"line_number":4743,"context_line":"                return False"},{"line_number":4744,"context_line":""},{"line_number":4745,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_e3fe20ad","line":4742,"in_reply_to":"5afe65bd_9ed58c1d","updated":"2015-06-04 14:13:39.000000000","message":"I think this is a good point for serviceability.  I\u0027ll push up a change that depends on this which adds the logging since I don\u0027t want to block this change.","commit_id":"f50eb8ed3a89df1f5a6483907a3cdd84fb67e81d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a2460da21f361bc566617fa2fa2d53adfd6fb53","unresolved":false,"context_lines":[{"line_number":4739,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":4740,"context_line":""},{"line_number":4741,"context_line":"        for ver in BAD_LIBVIRT_NUMA_VERSIONS:"},{"line_number":4742,"context_line":"            if self._host.has_version(ver):"},{"line_number":4743,"context_line":"                return False"},{"line_number":4744,"context_line":""},{"line_number":4745,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_49a633af","line":4742,"in_reply_to":"5afe65bd_e3fe20ad","updated":"2015-06-04 14:54:05.000000000","message":"https://review.openstack.org/#/c/188427/","commit_id":"f50eb8ed3a89df1f5a6483907a3cdd84fb67e81d"}]}