)]}'
{"nova/scheduler/filters/aggregate_multitenancy_isolation.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6a3416382f63b11164fa303243086d50d0fc61ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                if tenant_id not in configured_tenant_ids:"},{"line_number":50,"context_line":"                    LOG.debug(\"%s fails tenant id on aggregate\", host_state)"},{"line_number":51,"context_line":"                    return False"},{"line_number":52,"context_line":"                LOG.debug(\"Host tenant id %s matched\", tenant_id)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"No tenant id\u0027s defined on host. Host passes.\")"},{"line_number":55,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_0c7a95bd","line":52,"updated":"2015-08-19 21:50:03.000000000","message":"I\u0027m not really liking this one, because we usually know when a filter is succesful - it just gives us the number of hosts passing.\n\nHere that log doesn\u0027t carry much information so I prefer to -1 it and ask you to remove it.","commit_id":"d0df97e4e9178a22d4f5b2683439897f6b9d6cc9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"561d89a00f8d1a281b44170b3d949e8c36e9b5d8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                if tenant_id not in configured_tenant_ids:"},{"line_number":50,"context_line":"                    LOG.debug(\"%s fails tenant id on aggregate\", host_state)"},{"line_number":51,"context_line":"                    return False"},{"line_number":52,"context_line":"                LOG.debug(\"Host tenant id %s matched\", tenant_id)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"No tenant id\u0027s defined on host. Host passes.\")"},{"line_number":55,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_a73382aa","line":52,"in_reply_to":"fa1b9901_0c7a95bd","updated":"2015-08-19 22:01:14.000000000","message":"that is really nitpicking","commit_id":"d0df97e4e9178a22d4f5b2683439897f6b9d6cc9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e3bea15f8e97be60558b22faa93de4bd82df463e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                if tenant_id not in configured_tenant_ids:"},{"line_number":50,"context_line":"                    LOG.debug(\"%s fails tenant id on aggregate\", host_state)"},{"line_number":51,"context_line":"                    return False"},{"line_number":52,"context_line":"                LOG.debug(\"Host tenant id %s matched\", tenant_id)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"No tenant id\u0027s defined on host. Host passes.\")"},{"line_number":55,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_c7ef96e7","line":52,"in_reply_to":"fa1b9901_a73382aa","updated":"2015-08-19 22:03:10.000000000","message":"in actual fact it is very important for debugging as we want to know if the tenant is matched or if there is no tenants defined. it can be a configuration issue. please read the commit message","commit_id":"d0df97e4e9178a22d4f5b2683439897f6b9d6cc9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f75c3b3816dd923224198100548e24563d13e11","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                if tenant_id not in configured_tenant_ids:"},{"line_number":50,"context_line":"                    LOG.debug(\"%s fails tenant id on aggregate\", host_state)"},{"line_number":51,"context_line":"                    return False"},{"line_number":52,"context_line":"                LOG.debug(\"Host tenant id %s matched\", tenant_id)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"No tenant id\u0027s defined on host. Host passes.\")"},{"line_number":55,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_93aa5670","line":52,"in_reply_to":"fa1b9901_c7ef96e7","updated":"2015-08-25 15:11:57.000000000","message":"Well, do you think we really need to get the debug log for knowing the difference ? Here, the filter answers always True unless there is a related aggregate having the filter_tenant_id key.\nIf I would be an operator, I could easily figure out which hosts are part of those aggregates and which aren\u0027t so that a related success would be understandable.\n\nSo, let\u0027s say it\u0027s nitpicking, fair enough I can +1 but I don\u0027t really like the idea that we can put DEBUG logs for any branch we have because Ops.","commit_id":"d0df97e4e9178a22d4f5b2683439897f6b9d6cc9"}]}