)]}'
{"nova/objects/numa.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e49c3f9f0fdce0c70140a9f19174fe84c94ec2bc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":115,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_to_primitive(self, target_version\u003dNone):"},{"line_number":118,"context_line":"        self.obj_reset_changes()"},{"line_number":119,"context_line":"        return super(NUMACell,"},{"line_number":120,"context_line":"                     self).obj_to_primitive(target_version)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_e6a447a7","line":117,"updated":"2015-05-01 10:24:36.000000000","message":"not a fan of repetitiveness there, and still feel this should be allowed for by objects.\n\nHow hard would it be to add something like:\n\ntrack_changes\u003dTrue to objects (in some capacity) that can just be flipped to false?","commit_id":"e39f56c33bc3e31a75f748fab2de0edd533314d4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e3ca78f7329323a949f6dfef39c175329b15a6e7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":115,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_to_primitive(self, target_version\u003dNone):"},{"line_number":118,"context_line":"        self.obj_reset_changes()"},{"line_number":119,"context_line":"        return super(NUMACell,"},{"line_number":120,"context_line":"                     self).obj_to_primitive(target_version)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b76317dc","line":117,"in_reply_to":"3acd31a7_c6cdcb5e","updated":"2015-05-01 13:39:41.000000000","message":"I really don\u0027t like altering the behavior of the object at runtime. Getting the list of changes to an object before you save it is still potentially useful. For example, you pull the object, run a bunch of subroutines on it, and then at the end, check to see if anything changed and if so, save it.\n\nIMHO, to make this cleaner, we should just reset changes in save() before we shove it into the database.","commit_id":"e39f56c33bc3e31a75f748fab2de0edd533314d4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"08d0f33dca22134d3dbdac61cc16debeb8c26c62","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                   cpu_usage\u003dcpu_usage, memory_usage\u003dmemory_usage,"},{"line_number":115,"context_line":"                   mempages\u003d[], pinned_cpus\u003dset([]), siblings\u003d[])"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def obj_to_primitive(self, target_version\u003dNone):"},{"line_number":118,"context_line":"        self.obj_reset_changes()"},{"line_number":119,"context_line":"        return super(NUMACell,"},{"line_number":120,"context_line":"                     self).obj_to_primitive(target_version)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c6cdcb5e","line":117,"in_reply_to":"3acd31a7_e6a447a7","updated":"2015-05-01 10:33:35.000000000","message":"Yes, we could add a constructor parameter to the base Nova Object accepting such a parameter. Or could add a class property that subclasses override to false. Depends if we want it to be tweakable per instance or per class or something else.\n\nI\u0027m sure DanS will have an opinion on a good way.","commit_id":"e39f56c33bc3e31a75f748fab2de0edd533314d4"}]}