)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b2c74427f8414eef895da0778e3d4dd957d76891","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This means we don\u0027t need to the max_nbd_devices flag any more at all."},{"line_number":10,"context_line":"Resolves bug 1088339."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5c6218122ab09781d8a2ecd6d8b76a74be4a6e91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAMX%2F%2F3Kg%3D","line":11,"updated":"2012-12-12 00:30:03.000000000","message":"May be worth mentioning the /dev/foo -\u003e foo change.","commit_id":"3409e1f3385c98566f5f1fe82c757360b6ac9e4e"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1ec1bf8ff0114aa69f1b2ecd4571e89ff3945c6f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This means we don\u0027t need to the max_nbd_devices flag any more at all."},{"line_number":10,"context_line":"Resolves bug 1088339."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5c6218122ab09781d8a2ecd6d8b76a74be4a6e91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAMX%2F%2F3Ik%3D","line":11,"in_reply_to":"AAAAMX%2F%2F3Kg%3D","updated":"2012-12-12 03:33:26.000000000","message":"Done","commit_id":"3409e1f3385c98566f5f1fe82c757360b6ac9e4e"}],"nova/virt/disk/mount/nbd.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b2c74427f8414eef895da0778e3d4dd957d76891","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\"Detect nbd device files.\"\"\""},{"line_number":72,"context_line":"        for ent in os.listdir(\u0027/sys/block/\u0027):"},{"line_number":73,"context_line":"            if NBD_DEVICE_RE.match(ent):"},{"line_number":74,"context_line":"                yield ent"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _allocate_nbd(self):"},{"line_number":77,"context_line":"        if not os.path.exists(\"/sys/block/nbd0\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F3Ks%3D","line":74,"updated":"2012-12-12 00:30:03.000000000","message":"I would write that as:\nreturn filter(NBD_DEVICE_RE.match, os.listdir(\u0027/sys/block/\u0027))\n\nAnd its barely worth having as a standalone function at that point (but you may want it so for testing).\n\n(use ifilter if you need the iterator)","commit_id":"3409e1f3385c98566f5f1fe82c757360b6ac9e4e"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"1ec1bf8ff0114aa69f1b2ecd4571e89ff3945c6f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\"Detect nbd device files.\"\"\""},{"line_number":72,"context_line":"        for ent in os.listdir(\u0027/sys/block/\u0027):"},{"line_number":73,"context_line":"            if NBD_DEVICE_RE.match(ent):"},{"line_number":74,"context_line":"                yield ent"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _allocate_nbd(self):"},{"line_number":77,"context_line":"        if not os.path.exists(\"/sys/block/nbd0\"):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F3Ig%3D","line":74,"in_reply_to":"AAAAMX%2F%2F3Ks%3D","updated":"2012-12-12 03:33:26.000000000","message":"I want to keep this method, as it makes it easier for people to stub / mock, or add new device entry names if some distro does it differently.","commit_id":"3409e1f3385c98566f5f1fe82c757360b6ac9e4e"},{"author":{"_account_id":321,"name":"Lorin Hochstein","email":"lorinh@gmail.com","username":"lorinh"},"change_message_id":"f71e8b624305ba7703e01452cdeee51fb80754e2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    mode \u003d \u0027nbd\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # NOTE(padraig): There are three issues with this nbd device handling"},{"line_number":46,"context_line":"    #  1. max_nbd_devices should be inferred (#861504)"},{"line_number":47,"context_line":"    #  2. We assume nothing else on the system uses nbd devices"},{"line_number":48,"context_line":"    #  3. Multiple workers on a system can race against each other"},{"line_number":49,"context_line":"    # A patch has been proposed in Nov 2011, to add add a -f option to"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3Hg%3D","line":46,"updated":"2012-12-12 02:24:51.000000000","message":"Does the propose change render 1. in this comment obsolete?","commit_id":"31cb8f3e7f3b77b12d2a33f9c7636e079a0712ab"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"5e51bc9b3e90c6e1da9abeacb340686308d699d1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    mode \u003d \u0027nbd\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # NOTE(padraig): There are three issues with this nbd device handling"},{"line_number":46,"context_line":"    #  1. max_nbd_devices should be inferred (#861504)"},{"line_number":47,"context_line":"    #  2. We assume nothing else on the system uses nbd devices"},{"line_number":48,"context_line":"    #  3. Multiple workers on a system can race against each other"},{"line_number":49,"context_line":"    # A patch has been proposed in Nov 2011, to add add a -f option to"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3FE%3D","line":46,"in_reply_to":"AAAAMX%2F%2F3Hg%3D","updated":"2012-12-12 04:17:01.000000000","message":"Yes. I\u0027ll fix that now.","commit_id":"31cb8f3e7f3b77b12d2a33f9c7636e079a0712ab"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"d1d561043907453af0e4ad4c2b59d89177fad18b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"qemu-nbd support disk images.\"\"\""},{"line_number":43,"context_line":"    mode \u003d \u0027nbd\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # NOTE(padraig): There are three issues with this nbd device handling"},{"line_number":46,"context_line":"    #  1. We assume nothing else on the system uses nbd devices"},{"line_number":47,"context_line":"    #  2. Multiple workers on a system can race against each other"},{"line_number":48,"context_line":"    # A patch has been proposed in Nov 2011, to add add a -f option to"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F28o%3D","line":45,"updated":"2012-12-12 09:12:17.000000000","message":"s/three/two/ :)","commit_id":"0a81757b292af57fd1e5aceac45c7826d0625412"}]}