)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2f1103fad3755f2e825a2e75d4e62b9f89e5c8f3","unresolved":false,"context_lines":[{"line_number":5412,"context_line":"            self.cells_rpcapi.consoleauth_delete_tokens("},{"line_number":5413,"context_line":"                ctxt, instance.uuid)"},{"line_number":5414,"context_line":"        else:"},{"line_number":5415,"context_line":"            self.consoleauth_rpcapi.delete_tokens_for_instance("},{"line_number":5416,"context_line":"                ctxt, instance.uuid)"},{"line_number":5417,"context_line":""},{"line_number":5418,"context_line":"    @object_compat"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_1cf98bc7","line":5415,"updated":"2015-05-05 09:54:37.000000000","message":"well this is not ideal because we may not be running the consoleauth service at all. Granted this is a bit of a far-fetched scenario (most distributions and deployments would run the service anyway), but we should be expressing our assumptions clearly in code.\n\nConsolidating into a method and a single list of \"clean_tokens_required\" is one option of doing it, but there are other ways. Under the circumstances - keeping it as is (and maybe making the code less repetitive) is the right thing to do imho.","commit_id":"483f49c5976e75391e37cd3b0eca52ae0d0bd454"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c580c5b74f031b9f5a5b48d1d0af8821f7131a48","unresolved":false,"context_lines":[{"line_number":5412,"context_line":"            self.cells_rpcapi.consoleauth_delete_tokens("},{"line_number":5413,"context_line":"                ctxt, instance.uuid)"},{"line_number":5414,"context_line":"        else:"},{"line_number":5415,"context_line":"            self.consoleauth_rpcapi.delete_tokens_for_instance("},{"line_number":5416,"context_line":"                ctxt, instance.uuid)"},{"line_number":5417,"context_line":""},{"line_number":5418,"context_line":"    @object_compat"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_5fcdb5b5","line":5415,"in_reply_to":"3acd31a7_1cf98bc7","updated":"2015-05-05 10:29:00.000000000","message":"Done","commit_id":"483f49c5976e75391e37cd3b0eca52ae0d0bd454"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7c9a70f9acfa2218de7a0d451786f8134f9b8ab8","unresolved":false,"context_lines":[{"line_number":5407,"context_line":"        self._clean_instance_console_tokens(ctxt, instance)"},{"line_number":5408,"context_line":""},{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_4a12950a","line":5410,"updated":"2015-05-05 11:07:37.000000000","message":"comments may need update or \nremove it since logic is straighforward","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"60d3fb94f1261f6311112f4ca69facc57756cda4","unresolved":false,"context_lines":[{"line_number":5407,"context_line":"        self._clean_instance_console_tokens(ctxt, instance)"},{"line_number":5408,"context_line":""},{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_d01532e5","line":5410,"in_reply_to":"3acd31a7_4a12950a","updated":"2015-05-05 12:15:07.000000000","message":"I do not see a pain to have a comment here, can you tell me what is the problem with it?","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a9620e42ff1e039385d6c9858548d9e86ff1f615","unresolved":false,"context_lines":[{"line_number":5407,"context_line":"        self._clean_instance_console_tokens(ctxt, instance)"},{"line_number":5408,"context_line":""},{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_eb6043d1","line":5410,"in_reply_to":"3acd31a7_d01532e5","updated":"2015-05-05 12:23:22.000000000","message":"yes, I agree no pain , Just I was told either detailed description or nothing if it\u0027s straightforward :)","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7c9a70f9acfa2218de7a0d451786f8134f9b8ab8","unresolved":false,"context_lines":[{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""},{"line_number":5414,"context_line":"    def _clean_instance_console_tokens(self, ctxt, instance):"},{"line_number":5415,"context_line":"        \"\"\"Clean console tokens stored for an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_0ad13dfa","line":5412,"updated":"2015-05-05 11:07:37.000000000","message":"for serial_console, It\u0027s a bug, we don\u0027t do it before, right?","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5987284cd8300f9f5f773b9b36268358e524f35a","unresolved":false,"context_lines":[{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""},{"line_number":5414,"context_line":"    def _clean_instance_console_tokens(self, ctxt, instance):"},{"line_number":5415,"context_line":"        \"\"\"Clean console tokens stored for an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_85e41ee1","line":5412,"in_reply_to":"3acd31a7_0ad13dfa","updated":"2015-05-05 11:44:49.000000000","message":"I think the point is that we should - if that\u0027s the case - let\u0027s acutally have a bug to track it.","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"60d3fb94f1261f6311112f4ca69facc57756cda4","unresolved":false,"context_lines":[{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""},{"line_number":5414,"context_line":"    def _clean_instance_console_tokens(self, ctxt, instance):"},{"line_number":5415,"context_line":"        \"\"\"Clean console tokens stored for an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_10f96ac7","line":5412,"in_reply_to":"3acd31a7_85e41ee1","updated":"2015-05-05 12:15:07.000000000","message":"Ok will report a bug","commit_id":"3024ee71c38d0f84fa4922a364b8ab89b9b9a202"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"160b43ea10e975e2b7b8bcb767d1bc91c4ed67c6","unresolved":false,"context_lines":[{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""},{"line_number":5414,"context_line":"    def _clean_instance_console_tokens(self, ctxt, instance):"},{"line_number":5415,"context_line":"        \"\"\"Clean console tokens stored for an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_b5e11301","line":5412,"updated":"2015-05-06 08:48:52.000000000","message":"style nit - any(...)","commit_id":"a92fa5ac83c2c433fe989bea136ba92e88a2ab8a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c867d03c1e0a52d6c54ebe7be3d5b68ce39cd62","unresolved":false,"context_lines":[{"line_number":5409,"context_line":"    def _consoles_enabled(self):"},{"line_number":5410,"context_line":"        \"\"\"Returns whether a console is enable.\"\"\""},{"line_number":5411,"context_line":"        return (CONF.vnc_enabled or CONF.spice.enabled or"},{"line_number":5412,"context_line":"                CONF.rdp.enabled or CONF.serial_console.enabled)"},{"line_number":5413,"context_line":""},{"line_number":5414,"context_line":"    def _clean_instance_console_tokens(self, ctxt, instance):"},{"line_number":5415,"context_line":"        \"\"\"Clean console tokens stored for an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_4874619b","line":5412,"in_reply_to":"1aca2d91_b5e11301","updated":"2015-05-06 10:54:14.000000000","message":"ah yes...","commit_id":"a92fa5ac83c2c433fe989bea136ba92e88a2ab8a"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5987284cd8300f9f5f773b9b36268358e524f35a","unresolved":false,"context_lines":[{"line_number":4015,"context_line":""},{"line_number":4016,"context_line":"    def test_delete_instance_deletes_console_auth_tokens(self):"},{"line_number":4017,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":4018,"context_line":"        self.flags(vnc_enabled\u003dTrue)"},{"line_number":4019,"context_line":""},{"line_number":4020,"context_line":"        self.tokens_deleted \u003d False"},{"line_number":4021,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_85ce5e2c","side":"PARENT","line":4018,"updated":"2015-05-05 11:44:49.000000000","message":"um - why do we have to remove this?","commit_id":"9c523638ac4f0ba335b36476d419b3a494ec9be5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"60d3fb94f1261f6311112f4ca69facc57756cda4","unresolved":false,"context_lines":[{"line_number":4015,"context_line":""},{"line_number":4016,"context_line":"    def test_delete_instance_deletes_console_auth_tokens(self):"},{"line_number":4017,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":4018,"context_line":"        self.flags(vnc_enabled\u003dTrue)"},{"line_number":4019,"context_line":""},{"line_number":4020,"context_line":"        self.tokens_deleted \u003d False"},{"line_number":4021,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_30dea6dd","side":"PARENT","line":4018,"in_reply_to":"3acd31a7_85ce5e2c","updated":"2015-05-05 12:15:07.000000000","message":"It was previously when I have removed the condition with CONF","commit_id":"9c523638ac4f0ba335b36476d419b3a494ec9be5"}]}