)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-12 08:15:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactory test cases for live-migrate error case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_e4796f94","line":7,"updated":"2015-05-29 14:38:36.000000000","message":"Refactory \u003d\u003e Refactors","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactory test cases for live-migrate error case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"},{"line_number":11,"context_line":"more exceptions handling and refactory the util function"},{"line_number":12,"context_line":"with mock."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_c4531315","line":9,"updated":"2015-05-29 14:38:36.000000000","message":"few of exceptions can \u003d\u003e few exceptions that can","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"},{"line_number":11,"context_line":"more exceptions handling and refactory the util function"},{"line_number":12,"context_line":"with mock."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6b225756efcc17bdcd6402606287c35464a3c1d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_4448435c","line":11,"updated":"2015-05-29 14:38:36.000000000","message":"refactory \u003d\u003e refactors","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b47d271cb13ff295dbe251be3a7cd72ac814916d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-02 10:02:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactory test cases for live-migrate error case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_b44a9f24","line":7,"updated":"2015-07-02 11:33:29.000000000","message":"Refactory \u003d\u003e Refactor","commit_id":"07f185eac0b2cee17569106f0a501f1bf8df8b6b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"613e674119192938615a166f8dbe97166994c8fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-02 10:02:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactory test cases for live-migrate error case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_cc2d1eff","line":7,"in_reply_to":"ba3cc151_b44a9f24","updated":"2015-07-03 15:05:49.000000000","message":"Done","commit_id":"07f185eac0b2cee17569106f0a501f1bf8df8b6b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b47d271cb13ff295dbe251be3a7cd72ac814916d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"},{"line_number":11,"context_line":"more exceptions handling and refactory the util function"},{"line_number":12,"context_line":"with mock."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6b225756efcc17bdcd6402606287c35464a3c1d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_d455e3c1","line":11,"updated":"2015-07-02 11:33:29.000000000","message":"refactory \u003d\u003e refactors","commit_id":"07f185eac0b2cee17569106f0a501f1bf8df8b6b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"613e674119192938615a166f8dbe97166994c8fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a few of exceptions can be raised from live-migrate"},{"line_number":10,"context_line":"function in conductor, this patch added some cases for"},{"line_number":11,"context_line":"more exceptions handling and refactory the util function"},{"line_number":12,"context_line":"with mock."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6b225756efcc17bdcd6402606287c35464a3c1d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_ac369a4e","line":11,"in_reply_to":"ba3cc151_d455e3c1","updated":"2015-07-03 15:05:49.000000000","message":"Done","commit_id":"07f185eac0b2cee17569106f0a501f1bf8df8b6b"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"    @mock.patch.object(scheduler_utils, \u0027set_vm_state_and_notify\u0027)"},{"line_number":1509,"context_line":"    @mock.patch.object(live_migrate, \u0027execute\u0027)"},{"line_number":1510,"context_line":"    def _test_migrate_server_deals_with_expected_exceptions(self, ex,"},{"line_number":1511,"context_line":"        mock_execute, mock_set):"},{"line_number":1512,"context_line":"        instance \u003d fake_instance.fake_db_instance(uuid\u003d\u0027uuid\u0027,"},{"line_number":1513,"context_line":"                                                  vm_state\u003dvm_states.ACTIVE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_c4055310","line":1510,"updated":"2015-05-29 14:38:36.000000000","message":"nit: I think self and ex could be put on the next line, before mock_execute, so the arguments are on the same line.","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"            {\u0027host\u0027: \u0027destination\u0027}, True, False, None, \u0027block_migration\u0027,"},{"line_number":1562,"context_line":"            \u0027disk_over_commit\u0027)"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"    def test_migrate_server_deals_with_expected_exception(self):"},{"line_number":1565,"context_line":"        exs \u003d [exc.InstanceInvalidState(instance_uuid\u003d\"fake\", attr\u003d\u0027\u0027,"},{"line_number":1566,"context_line":"                                        state\u003d\u0027\u0027, method\u003d\u0027\u0027),"},{"line_number":1567,"context_line":"               exc.DestinationHypervisorTooOld(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_01323d10","line":1564,"updated":"2015-05-29 14:38:36.000000000","message":"expected_exceptions*","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae8d67b3aa2fd767acd49cb368b6d75b6ea1161f","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"               exc.InvalidHypervisorType(),"},{"line_number":1575,"context_line":"               exc.InvalidCPUInfo(reason\u003d\u0027dummy\u0027),"},{"line_number":1576,"context_line":"               exc.UnableToMigrateToSelf(instance_id\u003d\u0027dummy\u0027, host\u003d\u0027dummy\u0027),"},{"line_number":1577,"context_line":"               exc.InvalidLocalStorage(path\u003d\u0027dummy\u0027, reason\u003d\u0027dummy\u0027)]"},{"line_number":1578,"context_line":"        for ex in exs:"},{"line_number":1579,"context_line":"            self._test_migrate_server_deals_with_expected_exceptions(ex)"},{"line_number":1580,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6470df72","line":1577,"updated":"2015-05-29 14:38:36.000000000","message":"I would have preferred that those exceptions to be in the same order as in: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L630\n\nthat way it would have been easier to see and validate the fact that all the exceptions are here.","commit_id":"97ed3b554c785bfbacc8425222393635959b6f66"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ec7d03851167fd7a1bda23af3242fdbbb0802a2","unresolved":false,"context_lines":[{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"    def test_migrate_server_deals_with_LiveMigrationWithOldNovaNotSafe(self):"},{"line_number":1604,"context_line":"        ex \u003d exc.LiveMigrationWithOldNovaNotSafe(server\u003d\u0027dummy\u0027)"},{"line_number":1605,"context_line":"        self._test_migrate_server_deals_with_expected_exceptions(ex)"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"    @mock.patch.object(scheduler_utils, \u0027set_vm_state_and_notify\u0027)"},{"line_number":1608,"context_line":"    @mock.patch.object(live_migrate.LiveMigrationTask, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_ced0f1f8","side":"PARENT","line":1605,"updated":"2015-08-20 13:21:48.000000000","message":"Nit: I do prefer having one test for each exception type, as its much easier to debug failures.\n\nBut it would suck for so many exceptions.","commit_id":"c0d0e5ccf62f45498f084ed59e776c3b370e9137"}]}